From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard@nod.at>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Eric Biggers <ebiggers3@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
jaegeuk@kernel.org, hch@infradead.org, arnd@arndb.de,
dedekind1@gmail.com, linux-mtd@lists.infradead.org,
adrian.hunter@intel.com, linux-ext4@vger.kernel.org,
ebiggers@google.com, rdunlap@infradead.org, david@sigma-star.at
Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions
Date: Mon, 9 Jan 2017 05:33:49 -0800 [thread overview]
Message-ID: <20170109133349.GA19577@infradead.org> (raw)
In-Reply-To: <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at>
On Sat, Jan 07, 2017 at 11:40:15PM +0100, Richard Weinberger wrote:
> Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled.
> UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs.
> This will enable ENCRYPTION even when no block support is available.
It's the good old select vs depends mess once again.
> I can make UBIFS depend on BLOCK as intermediate fix.
> But the real fix is this patch.
And despite the diffstat it's simple and trivial as it just moves code.
There is no good reason not to take it for 4.10.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Richard Weinberger <richard@nod.at>
Cc: david@sigma-star.at, rdunlap@infradead.org,
Theodore Ts'o <tytso@mit.edu>,
arnd@arndb.de, dedekind1@gmail.com,
Eric Biggers <ebiggers3@gmail.com>,
linux-kernel@vger.kernel.org, ebiggers@google.com,
adrian.hunter@intel.com, hch@infradead.org,
linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] fscrypt: Factor out bio specific functions
Date: Mon, 9 Jan 2017 05:33:49 -0800 [thread overview]
Message-ID: <20170109133349.GA19577@infradead.org> (raw)
In-Reply-To: <21de1dd8-b491-8c59-e874-6834978f1e2e@nod.at>
On Sat, Jan 07, 2017 at 11:40:15PM +0100, Richard Weinberger wrote:
> Kconfig is tricky. We face a build error with CONFIG_BLOCK=n with UBIFS_FS_ENCRYPTION enabled.
> UBIFS file encryption does "select FS_ENCRYPTION" just like ext4 and f2fs.
> This will enable ENCRYPTION even when no block support is available.
It's the good old select vs depends mess once again.
> I can make UBIFS depend on BLOCK as intermediate fix.
> But the real fix is this patch.
And despite the diffstat it's simple and trivial as it just moves code.
There is no good reason not to take it for 4.10.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2017-01-09 13:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 10:50 [PATCH] fscrypt: Factor out bio specific functions Richard Weinberger
2016-12-16 15:37 ` David Gstir
2016-12-16 15:37 ` David Gstir
2016-12-16 20:48 ` Richard Weinberger
2016-12-16 22:14 ` Eric Biggers
2016-12-16 22:18 ` Richard Weinberger
2016-12-19 10:39 ` Christoph Hellwig
2016-12-19 11:25 ` [PATCH v2] " Richard Weinberger
2016-12-19 22:40 ` Eric Biggers
2016-12-20 5:56 ` Christoph Hellwig
2016-12-20 6:42 ` David Gstir
2017-01-01 21:47 ` Theodore Ts'o
2017-01-03 9:49 ` Richard Weinberger
2017-01-03 14:28 ` Theodore Ts'o
2017-01-04 20:10 ` Eric Biggers
2017-01-04 22:52 ` Richard Weinberger
2017-01-07 19:24 ` Theodore Ts'o
2017-01-07 22:40 ` Richard Weinberger
2017-01-09 13:33 ` Christoph Hellwig [this message]
2017-01-09 13:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109133349.GA19577@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=david@sigma-star.at \
--cc=dedekind1@gmail.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.