All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Guochun Mao <guochun.mao@mediatek.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@atmel.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings
Date: Fri, 13 Jan 2017 15:13:26 +0100	[thread overview]
Message-ID: <20170113151326.11e9451a@bbrezillon> (raw)
In-Reply-To: <1484291609-20195-2-git-send-email-guochun.mao@mediatek.com>

On Fri, 13 Jan 2017 15:13:28 +0800
Guochun Mao <guochun.mao@mediatek.com> wrote:

> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index fb314f0..f83d31d 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -1,7 +1,9 @@
>  * Serial NOR flash controller for MTK MT81xx (and similar)
>  
>  Required properties:
> -- compatible: 	  should be "mediatek,mt8173-nor";
> +- compatible: 	  should contain:
> +		  "mediatek,mt2701-nor" for MT2701,
> +		  "mediatek,mt8173-nor" for MT8173.

Do you need to define a new compatible? If the IPs are exactly the same
in both SoCs it shouldn't be needed.

>  - reg: 		  physical base address and length of the controller's register
>  - clocks: 	  the phandle of the clocks needed by the nor controller
>  - clock-names: 	  the names of the clocks

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
	Brian Norris
	<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
	Cyrille Pitchen
	<cyrille.pitchen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings
Date: Fri, 13 Jan 2017 15:13:26 +0100	[thread overview]
Message-ID: <20170113151326.11e9451a@bbrezillon> (raw)
In-Reply-To: <1484291609-20195-2-git-send-email-guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

On Fri, 13 Jan 2017 15:13:28 +0800
Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> wrote:

> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index fb314f0..f83d31d 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -1,7 +1,9 @@
>  * Serial NOR flash controller for MTK MT81xx (and similar)
>  
>  Required properties:
> -- compatible: 	  should be "mediatek,mt8173-nor";
> +- compatible: 	  should contain:
> +		  "mediatek,mt2701-nor" for MT2701,
> +		  "mediatek,mt8173-nor" for MT8173.

Do you need to define a new compatible? If the IPs are exactly the same
in both SoCs it shouldn't be needed.

>  - reg: 		  physical base address and length of the controller's register
>  - clocks: 	  the phandle of the clocks needed by the nor controller
>  - clock-names: 	  the names of the clocks

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings
Date: Fri, 13 Jan 2017 15:13:26 +0100	[thread overview]
Message-ID: <20170113151326.11e9451a@bbrezillon> (raw)
In-Reply-To: <1484291609-20195-2-git-send-email-guochun.mao@mediatek.com>

On Fri, 13 Jan 2017 15:13:28 +0800
Guochun Mao <guochun.mao@mediatek.com> wrote:

> Add "mediatek,mt2701-nor" for nor flash node's compatible.
> 
> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
> ---
>  .../devicetree/bindings/mtd/mtk-quadspi.txt        |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> index fb314f0..f83d31d 100644
> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
> @@ -1,7 +1,9 @@
>  * Serial NOR flash controller for MTK MT81xx (and similar)
>  
>  Required properties:
> -- compatible: 	  should be "mediatek,mt8173-nor";
> +- compatible: 	  should contain:
> +		  "mediatek,mt2701-nor" for MT2701,
> +		  "mediatek,mt8173-nor" for MT8173.

Do you need to define a new compatible? If the IPs are exactly the same
in both SoCs it shouldn't be needed.

>  - reg: 		  physical base address and length of the controller's register
>  - clocks: 	  the phandle of the clocks needed by the nor controller
>  - clock-names: 	  the names of the clocks

  reply	other threads:[~2017-01-13 14:13 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  7:13 [PATCH v1 0/2] add nor flash node for mt2701 Guochun Mao
2017-01-13  7:13 ` Guochun Mao
2017-01-13  7:13 ` Guochun Mao
2017-01-13  7:13 ` [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao
2017-01-13  7:13   ` Guochun Mao
2017-01-13  7:13   ` Guochun Mao
2017-01-13 14:13   ` Boris Brezillon [this message]
2017-01-13 14:13     ` Boris Brezillon
2017-01-13 14:13     ` Boris Brezillon
2017-01-18 22:08     ` Rob Herring
2017-01-18 22:08       ` Rob Herring
2017-01-18 22:08       ` Rob Herring
2017-01-13  7:13 ` [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Guochun Mao
2017-01-13  7:13   ` Guochun Mao
2017-01-13  7:13   ` Guochun Mao
2017-01-13 12:49   ` Marek Vasut
2017-01-13 12:49     ` Marek Vasut
2017-01-13 12:49     ` Marek Vasut
2017-01-13 14:17   ` Boris Brezillon
2017-01-13 14:17     ` Boris Brezillon
2017-01-13 14:17     ` Boris Brezillon
2017-01-13 15:12     ` Matthias Brugger
2017-01-13 15:12       ` Matthias Brugger
2017-01-13 15:12       ` Matthias Brugger
2017-01-13 15:21       ` Boris Brezillon
2017-01-13 15:21         ` Boris Brezillon
2017-01-13 16:13       ` Marek Vasut
2017-01-13 16:13         ` Marek Vasut
2017-01-13 16:13         ` Marek Vasut
2017-01-13 16:28         ` Boris Brezillon
2017-01-13 16:28           ` Boris Brezillon
2017-01-13 16:44           ` Marek Vasut
2017-01-13 16:44             ` Marek Vasut
2017-01-13 16:44             ` Marek Vasut
2017-01-13 16:56             ` Boris Brezillon
2017-01-13 16:56               ` Boris Brezillon
2017-01-13 16:56               ` Boris Brezillon
2017-01-13 17:33               ` Marek Vasut
2017-01-13 17:33                 ` Marek Vasut
2017-01-13 17:33                 ` Marek Vasut
2017-01-14  8:29                 ` Boris Brezillon
2017-01-14  8:29                   ` Boris Brezillon
2017-01-14  8:29                   ` Boris Brezillon
2017-01-15  0:23                   ` Marek Vasut
2017-01-15  0:23                     ` Marek Vasut
2017-01-16  8:40                     ` Boris Brezillon
2017-01-16  8:40                       ` Boris Brezillon
2017-01-16  8:40                       ` Boris Brezillon
2017-01-16 16:09                       ` Marek Vasut
2017-01-16 16:09                         ` Marek Vasut
2017-01-16 16:09                         ` Marek Vasut
2017-01-17  3:36                       ` Thomas Petazzoni
2017-01-17  3:36                         ` Thomas Petazzoni
2017-01-18 22:20                         ` Rob Herring
2017-01-18 22:20                           ` Rob Herring
2017-01-18 22:20                           ` Rob Herring
2017-01-18 23:38                           ` Thomas Petazzoni
2017-01-18 23:38                             ` Thomas Petazzoni
2017-01-18 23:38                             ` Thomas Petazzoni
2017-01-19  2:51                             ` Rob Herring
2017-01-19  2:51                               ` Rob Herring
2017-01-19  2:51                               ` Rob Herring
2017-01-19  8:14                               ` Boris Brezillon
2017-01-19  8:14                                 ` Boris Brezillon
2017-01-19  8:14                                 ` Boris Brezillon
2017-01-19  8:14                                 ` Boris Brezillon
2017-01-19 14:18                                 ` Rob Herring
2017-01-19 14:18                                   ` Rob Herring
2017-01-19 14:18                                   ` Rob Herring
2017-01-22  2:36                                   ` Guochun Mao
2017-01-22  2:36                                     ` Guochun Mao
2017-01-22  2:36                                     ` Guochun Mao
2017-01-22  2:36                                     ` Guochun Mao
2017-01-24 10:31                                     ` Boris Brezillon
2017-01-24 10:31                                       ` Boris Brezillon
2017-01-24 10:31                                       ` Boris Brezillon
2017-01-24 10:38                                       ` John Crispin
2017-01-24 10:38                                         ` John Crispin
2017-01-24 10:38                                         ` John Crispin
2017-01-24 10:38                                         ` John Crispin
2017-01-19  7:53                           ` Boris Brezillon
2017-01-19  7:53                             ` Boris Brezillon
2017-01-17  3:32               ` Thomas Petazzoni
2017-01-17  3:32                 ` Thomas Petazzoni
2017-01-17  3:32                 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170113151326.11e9451a@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@atmel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=guochun.mao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.