From: Boris Brezillon <boris.brezillon@free-electrons.com> To: Marek Vasut <marek.vasut@gmail.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, Guochun Mao <guochun.mao@mediatek.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Richard Weinberger <richard@nod.at>, Cyrille Pitchen <cyrille.pitchen@atmel.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Date: Fri, 13 Jan 2017 17:28:25 +0100 [thread overview] Message-ID: <20170113172825.75d545a3@bbrezillon> (raw) In-Reply-To: <b850b751-1d8d-0053-cf1f-d5314542e5c3@gmail.com> On Fri, 13 Jan 2017 17:13:55 +0100 Marek Vasut <marek.vasut@gmail.com> wrote: > On 01/13/2017 04:12 PM, Matthias Brugger wrote: > > > > > > On 13/01/17 15:17, Boris Brezillon wrote: > >> On Fri, 13 Jan 2017 15:13:29 +0800 > >> Guochun Mao <guochun.mao@mediatek.com> wrote: > >> > >>> Add Mediatek nor flash node. > >>> > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com> > >>> --- > >>> arch/arm/boot/dts/mt2701-evb.dts | 25 +++++++++++++++++++++++++ > >>> arch/arm/boot/dts/mt2701.dtsi | 12 ++++++++++++ > >>> 2 files changed, 37 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/mt2701-evb.dts > >>> b/arch/arm/boot/dts/mt2701-evb.dts > >>> index 082ca88..85e5ae8 100644 > >>> --- a/arch/arm/boot/dts/mt2701-evb.dts > >>> +++ b/arch/arm/boot/dts/mt2701-evb.dts > >>> @@ -24,6 +24,31 @@ > >>> }; > >>> }; > >>> > >>> +&nor_flash { > >>> + pinctrl-names = "default"; > >>> + pinctrl-0 = <&nor_pins_default>; > >>> + status = "okay"; > >>> + flash@0 { > >>> + compatible = "jedec,spi-nor"; > >>> + reg = <0>; > >>> + }; > >>> +}; > >>> + > >>> +&pio { > >>> + nor_pins_default: nor { > >>> + pins1 { > >>> + pinmux = <MT2701_PIN_240_EXT_XCS__FUNC_EXT_XCS>, > >>> + <MT2701_PIN_241_EXT_SCK__FUNC_EXT_SCK>, > >>> + <MT2701_PIN_239_EXT_SDIO0__FUNC_EXT_SDIO0>, > >>> + <MT2701_PIN_238_EXT_SDIO1__FUNC_EXT_SDIO1>, > >>> + <MT2701_PIN_237_EXT_SDIO2__FUNC_EXT_SDIO2>, > >>> + <MT2701_PIN_236_EXT_SDIO3__FUNC_EXT_SDIO3>; > >>> + drive-strength = <MTK_DRIVE_4mA>; > >>> + bias-pull-up; > >>> + }; > >>> + }; > >>> +}; > >>> + > >>> &uart0 { > >>> status = "okay"; > >>> }; > >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi > >>> b/arch/arm/boot/dts/mt2701.dtsi > >>> index bdf8954..1eefce4 100644 > >>> --- a/arch/arm/boot/dts/mt2701.dtsi > >>> +++ b/arch/arm/boot/dts/mt2701.dtsi > >>> @@ -227,6 +227,18 @@ > >>> status = "disabled"; > >>> }; > >>> > >>> + nor_flash: spi@11014000 { > >>> + compatible = "mediatek,mt2701-nor", > >>> + "mediatek,mt8173-nor"; > >> > >> Why define both here? Is "mediatek,mt8173-nor" really providing a > >> subset of the features supported by "mediatek,mt2701-nor"? > >> > > > > I think even if the ip block is the same, we should provide both > > bindings, just in case in the future we find out that mt2701 has some > > hidden bug, feature or bug-feature. This way even if we update the > > driver, we stay compatible with older device tree blobs in the wild. > > > > We can drop the mt2701-nor in the bindings definition if you want. Oh, sorry, I misunderstood. What I meant is that if you want to list/support all possible compatibles, maybe you should just put one compatible in your DT and patch your driver (+ binding doc) to define all of them. > > This exactly. We should have a DT compat in the form: > compatible = "vendor,<soc>-block", "vendor,<oldest-compat-soc>-block"; > Then if we find a problem in the future, we can match on the > "vendor,<soc>-block" and still support the old DTs. Not sure it's only in term of whose IP appeared first. My understanding is that it's a way to provide inheritance. For example: "<soc-vendor>,<ip-version>", "<ip-vendor>,<ip-version>"; or "<soc-vendor>,<full-featured-ip-version>","<soc-vendor>,<basic-feature-ip-version>"; BTW, which one is the oldest between mt8173 and mt2701? :-)
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Date: Fri, 13 Jan 2017 17:28:25 +0100 [thread overview] Message-ID: <20170113172825.75d545a3@bbrezillon> (raw) In-Reply-To: <b850b751-1d8d-0053-cf1f-d5314542e5c3@gmail.com> On Fri, 13 Jan 2017 17:13:55 +0100 Marek Vasut <marek.vasut@gmail.com> wrote: > On 01/13/2017 04:12 PM, Matthias Brugger wrote: > > > > > > On 13/01/17 15:17, Boris Brezillon wrote: > >> On Fri, 13 Jan 2017 15:13:29 +0800 > >> Guochun Mao <guochun.mao@mediatek.com> wrote: > >> > >>> Add Mediatek nor flash node. > >>> > >>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com> > >>> --- > >>> arch/arm/boot/dts/mt2701-evb.dts | 25 +++++++++++++++++++++++++ > >>> arch/arm/boot/dts/mt2701.dtsi | 12 ++++++++++++ > >>> 2 files changed, 37 insertions(+) > >>> > >>> diff --git a/arch/arm/boot/dts/mt2701-evb.dts > >>> b/arch/arm/boot/dts/mt2701-evb.dts > >>> index 082ca88..85e5ae8 100644 > >>> --- a/arch/arm/boot/dts/mt2701-evb.dts > >>> +++ b/arch/arm/boot/dts/mt2701-evb.dts > >>> @@ -24,6 +24,31 @@ > >>> }; > >>> }; > >>> > >>> +&nor_flash { > >>> + pinctrl-names = "default"; > >>> + pinctrl-0 = <&nor_pins_default>; > >>> + status = "okay"; > >>> + flash at 0 { > >>> + compatible = "jedec,spi-nor"; > >>> + reg = <0>; > >>> + }; > >>> +}; > >>> + > >>> +&pio { > >>> + nor_pins_default: nor { > >>> + pins1 { > >>> + pinmux = <MT2701_PIN_240_EXT_XCS__FUNC_EXT_XCS>, > >>> + <MT2701_PIN_241_EXT_SCK__FUNC_EXT_SCK>, > >>> + <MT2701_PIN_239_EXT_SDIO0__FUNC_EXT_SDIO0>, > >>> + <MT2701_PIN_238_EXT_SDIO1__FUNC_EXT_SDIO1>, > >>> + <MT2701_PIN_237_EXT_SDIO2__FUNC_EXT_SDIO2>, > >>> + <MT2701_PIN_236_EXT_SDIO3__FUNC_EXT_SDIO3>; > >>> + drive-strength = <MTK_DRIVE_4mA>; > >>> + bias-pull-up; > >>> + }; > >>> + }; > >>> +}; > >>> + > >>> &uart0 { > >>> status = "okay"; > >>> }; > >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi > >>> b/arch/arm/boot/dts/mt2701.dtsi > >>> index bdf8954..1eefce4 100644 > >>> --- a/arch/arm/boot/dts/mt2701.dtsi > >>> +++ b/arch/arm/boot/dts/mt2701.dtsi > >>> @@ -227,6 +227,18 @@ > >>> status = "disabled"; > >>> }; > >>> > >>> + nor_flash: spi at 11014000 { > >>> + compatible = "mediatek,mt2701-nor", > >>> + "mediatek,mt8173-nor"; > >> > >> Why define both here? Is "mediatek,mt8173-nor" really providing a > >> subset of the features supported by "mediatek,mt2701-nor"? > >> > > > > I think even if the ip block is the same, we should provide both > > bindings, just in case in the future we find out that mt2701 has some > > hidden bug, feature or bug-feature. This way even if we update the > > driver, we stay compatible with older device tree blobs in the wild. > > > > We can drop the mt2701-nor in the bindings definition if you want. Oh, sorry, I misunderstood. What I meant is that if you want to list/support all possible compatibles, maybe you should just put one compatible in your DT and patch your driver (+ binding doc) to define all of them. > > This exactly. We should have a DT compat in the form: > compatible = "vendor,<soc>-block", "vendor,<oldest-compat-soc>-block"; > Then if we find a problem in the future, we can match on the > "vendor,<soc>-block" and still support the old DTs. Not sure it's only in term of whose IP appeared first. My understanding is that it's a way to provide inheritance. For example: "<soc-vendor>,<ip-version>", "<ip-vendor>,<ip-version>"; or "<soc-vendor>,<full-featured-ip-version>","<soc-vendor>,<basic-feature-ip-version>"; BTW, which one is the oldest between mt8173 and mt2701? :-)
next prev parent reply other threads:[~2017-01-13 16:28 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-13 7:13 [PATCH v1 0/2] add nor flash node for mt2701 Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 7:13 ` [PATCH v1 1/2] Documentation: mtk-quadspi: update DT bindings Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 14:13 ` Boris Brezillon 2017-01-13 14:13 ` Boris Brezillon 2017-01-13 14:13 ` Boris Brezillon 2017-01-18 22:08 ` Rob Herring 2017-01-18 22:08 ` Rob Herring 2017-01-18 22:08 ` Rob Herring 2017-01-13 7:13 ` [PATCH v1 2/2] arm: dts: mt2701: add nor flash node Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 7:13 ` Guochun Mao 2017-01-13 12:49 ` Marek Vasut 2017-01-13 12:49 ` Marek Vasut 2017-01-13 12:49 ` Marek Vasut 2017-01-13 14:17 ` Boris Brezillon 2017-01-13 14:17 ` Boris Brezillon 2017-01-13 14:17 ` Boris Brezillon 2017-01-13 15:12 ` Matthias Brugger 2017-01-13 15:12 ` Matthias Brugger 2017-01-13 15:12 ` Matthias Brugger 2017-01-13 15:21 ` Boris Brezillon 2017-01-13 15:21 ` Boris Brezillon 2017-01-13 16:13 ` Marek Vasut 2017-01-13 16:13 ` Marek Vasut 2017-01-13 16:13 ` Marek Vasut 2017-01-13 16:28 ` Boris Brezillon [this message] 2017-01-13 16:28 ` Boris Brezillon 2017-01-13 16:44 ` Marek Vasut 2017-01-13 16:44 ` Marek Vasut 2017-01-13 16:44 ` Marek Vasut 2017-01-13 16:56 ` Boris Brezillon 2017-01-13 16:56 ` Boris Brezillon 2017-01-13 16:56 ` Boris Brezillon 2017-01-13 17:33 ` Marek Vasut 2017-01-13 17:33 ` Marek Vasut 2017-01-13 17:33 ` Marek Vasut 2017-01-14 8:29 ` Boris Brezillon 2017-01-14 8:29 ` Boris Brezillon 2017-01-14 8:29 ` Boris Brezillon 2017-01-15 0:23 ` Marek Vasut 2017-01-15 0:23 ` Marek Vasut 2017-01-16 8:40 ` Boris Brezillon 2017-01-16 8:40 ` Boris Brezillon 2017-01-16 8:40 ` Boris Brezillon 2017-01-16 16:09 ` Marek Vasut 2017-01-16 16:09 ` Marek Vasut 2017-01-16 16:09 ` Marek Vasut 2017-01-17 3:36 ` Thomas Petazzoni 2017-01-17 3:36 ` Thomas Petazzoni 2017-01-18 22:20 ` Rob Herring 2017-01-18 22:20 ` Rob Herring 2017-01-18 22:20 ` Rob Herring 2017-01-18 23:38 ` Thomas Petazzoni 2017-01-18 23:38 ` Thomas Petazzoni 2017-01-18 23:38 ` Thomas Petazzoni 2017-01-19 2:51 ` Rob Herring 2017-01-19 2:51 ` Rob Herring 2017-01-19 2:51 ` Rob Herring 2017-01-19 8:14 ` Boris Brezillon 2017-01-19 8:14 ` Boris Brezillon 2017-01-19 8:14 ` Boris Brezillon 2017-01-19 8:14 ` Boris Brezillon 2017-01-19 14:18 ` Rob Herring 2017-01-19 14:18 ` Rob Herring 2017-01-19 14:18 ` Rob Herring 2017-01-22 2:36 ` Guochun Mao 2017-01-22 2:36 ` Guochun Mao 2017-01-22 2:36 ` Guochun Mao 2017-01-22 2:36 ` Guochun Mao 2017-01-24 10:31 ` Boris Brezillon 2017-01-24 10:31 ` Boris Brezillon 2017-01-24 10:31 ` Boris Brezillon 2017-01-24 10:38 ` John Crispin 2017-01-24 10:38 ` John Crispin 2017-01-24 10:38 ` John Crispin 2017-01-24 10:38 ` John Crispin 2017-01-19 7:53 ` Boris Brezillon 2017-01-19 7:53 ` Boris Brezillon 2017-01-17 3:32 ` Thomas Petazzoni 2017-01-17 3:32 ` Thomas Petazzoni 2017-01-17 3:32 ` Thomas Petazzoni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170113172825.75d545a3@bbrezillon \ --to=boris.brezillon@free-electrons.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@atmel.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=guochun.mao@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.