All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ?
@ 2016-10-05 10:50 dcb
  2016-10-12 14:54 ` [Qemu-devel] [Bug 1630527] " T. Huth
  2017-01-16 11:45 ` Thomas Huth
  0 siblings, 2 replies; 3+ messages in thread
From: dcb @ 2016-10-05 10:50 UTC (permalink / raw)
  To: qemu-devel

Public bug reported:

qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64 bits
is undefined behaviour

Source code is

    uint64_t mask = ((1 << length) - 1) << bitpos;

Maybe better code

    uint64_t mask = ((1ULL << length) - 1) << bitpos;

** Affects: qemu
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1630527

Title:
  qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

Status in QEMU:
  New

Bug description:
  qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64
  bits is undefined behaviour

  Source code is

      uint64_t mask = ((1 << length) - 1) << bitpos;

  Maybe better code

      uint64_t mask = ((1ULL << length) - 1) << bitpos;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1630527/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?
  2016-10-05 10:50 [Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ? dcb
@ 2016-10-12 14:54 ` T. Huth
  2017-01-16 11:45 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: T. Huth @ 2016-10-12 14:54 UTC (permalink / raw)
  To: qemu-devel

Thanks for reporting this bug! Looks like this has already been fixed by this commit here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=1d5b128cbeeab638f772e


** Changed in: qemu
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1630527

Title:
  qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

Status in QEMU:
  Fix Committed

Bug description:
  qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64
  bits is undefined behaviour

  Source code is

      uint64_t mask = ((1 << length) - 1) << bitpos;

  Maybe better code

      uint64_t mask = ((1ULL << length) - 1) << bitpos;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1630527/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Qemu-devel] [Bug 1630527] Re: qemu/hw/i386/amd_iommu.c:188: possible bad shift ?
  2016-10-05 10:50 [Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ? dcb
  2016-10-12 14:54 ` [Qemu-devel] [Bug 1630527] " T. Huth
@ 2017-01-16 11:45 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2017-01-16 11:45 UTC (permalink / raw)
  To: qemu-devel

Released with v2.8

** Changed in: qemu
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1630527

Title:
  qemu/hw/i386/amd_iommu.c:188: possible bad shift ?

Status in QEMU:
  Fix Released

Bug description:
  qemu/hw/i386/amd_iommu.c:188]: (error) Shifting 32-bit value by 64
  bits is undefined behaviour

  Source code is

      uint64_t mask = ((1 << length) - 1) << bitpos;

  Maybe better code

      uint64_t mask = ((1ULL << length) - 1) << bitpos;

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1630527/+subscriptions

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-16 11:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-05 10:50 [Qemu-devel] [Bug 1630527] [NEW] qemu/hw/i386/amd_iommu.c:188: possible bad shift ? dcb
2016-10-12 14:54 ` [Qemu-devel] [Bug 1630527] " T. Huth
2017-01-16 11:45 ` Thomas Huth

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.