From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: tpmdd-devel@lists.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
Christophe Ricard <christophe.ricard@gmail.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero
Date: Mon, 16 Jan 2017 15:55:39 +0200 [thread overview]
Message-ID: <20170116135539.4qtrylwt3m2yfapx@intel.com> (raw)
In-Reply-To: <20170116134612.uuzbb6xi7pw7czyo@intel.com>
On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote:
> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote:
> > On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote:
> > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM
> > > access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no
> > > longer works.
> > > The initialization proceeds fine until we get and start using chip-reported
> > > timeouts - and the chip reports C and D timeouts of zero.
> > >
> > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic
> > > means to override the chip returned timeouts") we had actually let default
> > > timeout values remain in this case, so let's bring back this behavior to
> > > make chips like Atmel 3203 work again.
> > >
> > > Use a common code that was introduced by that commit so a warning is
> > > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the
> > > timeouts aren't chip-original.
> > >
> > > Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> > >
> > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access")
> > > Cc: stable@vger.kernel.org
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> It's now applied to my master branch so if someone wants to
> test it, it should be fairly easy.
>
> /Jarkko
And I decided to squash the rename commit to it.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: "Maciej S. Szmigiero"
<mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org>
Cc: Christophe Ricard
<christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero
Date: Mon, 16 Jan 2017 15:55:39 +0200 [thread overview]
Message-ID: <20170116135539.4qtrylwt3m2yfapx@intel.com> (raw)
In-Reply-To: <20170116134612.uuzbb6xi7pw7czyo-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote:
> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote:
> > On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote:
> > > Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM
> > > access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no
> > > longer works.
> > > The initialization proceeds fine until we get and start using chip-reported
> > > timeouts - and the chip reports C and D timeouts of zero.
> > >
> > > It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic
> > > means to override the chip returned timeouts") we had actually let default
> > > timeout values remain in this case, so let's bring back this behavior to
> > > make chips like Atmel 3203 work again.
> > >
> > > Use a common code that was introduced by that commit so a warning is
> > > printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the
> > > timeouts aren't chip-original.
> > >
> > > Signed-off-by: Maciej S. Szmigiero <mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org>
> > >
> > > Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access")
> > > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >
> > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>
> It's now applied to my master branch so if someone wants to
> test it, it should be fairly easy.
>
> /Jarkko
And I decided to squash the rename commit to it.
/Jarkko
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
next prev parent reply other threads:[~2017-01-16 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 21:37 [PATCH] tpm_tis: use default timeout value if chip reports it as zero Maciej S. Szmigiero
2017-01-16 9:42 ` Jarkko Sakkinen
2017-01-16 13:46 ` Jarkko Sakkinen
2017-01-16 13:46 ` Jarkko Sakkinen
2017-01-16 13:55 ` Jarkko Sakkinen [this message]
2017-01-16 13:55 ` Jarkko Sakkinen
2017-01-16 14:58 ` Maciej S. Szmigiero
2017-01-16 16:39 ` Jarkko Sakkinen
2017-01-16 16:39 ` Jarkko Sakkinen
2017-01-23 17:23 ` Maciej S. Szmigiero
2017-01-24 12:01 ` Jarkko Sakkinen
2017-01-24 13:42 ` Maciej S. Szmigiero
2017-01-25 20:09 ` Jarkko Sakkinen
2017-01-25 21:26 ` Maciej S. Szmigiero
2017-01-25 21:26 ` Maciej S. Szmigiero
2017-01-25 22:58 ` Jarkko Sakkinen
2017-01-25 22:58 ` Jarkko Sakkinen
2017-01-25 23:28 ` Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116135539.4qtrylwt3m2yfapx@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christophe.ricard@gmail.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.