From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name> To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel <linux-kernel@vger.kernel.org>, Peter Huewe <peterhuewe@gmx.de>, Marcel Selhorst <tpmdd@selhorst.net>, Christophe Ricard <christophe.ricard@gmail.com>, Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Date: Wed, 25 Jan 2017 22:26:44 +0100 [thread overview] Message-ID: <8e7720cf-6388-dc24-2487-64d932aec874@maciej.szmigiero.name> (raw) In-Reply-To: <20170125200942.d3iumrnpfautlmh7@intel.com> On 25.01.2017 21:09, Jarkko Sakkinen wrote: > On Tue, Jan 24, 2017 at 02:42:29PM +0100, Maciej S. Szmigiero wrote: >> On 24.01.2017 13:01, Jarkko Sakkinen wrote: >>> On Mon, Jan 23, 2017 at 06:23:55PM +0100, Maciej S. Szmigiero wrote: >>>> On 16.01.2017 17:39, Jarkko Sakkinen wrote: >>>>> On Mon, Jan 16, 2017 at 03:58:26PM +0100, Maciej S. Szmigiero wrote: >>>>>> On 16.01.2017 14:55, Jarkko Sakkinen wrote: >>>>>>> On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote: >>>>>>>> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: >>>>>>>>> On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: >>>>>>>>>> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM >>>>>>>>>> access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no >>>>>>>>>> longer works. >>>>>>>>>> The initialization proceeds fine until we get and start using chip-reported >>>>>>>>>> timeouts - and the chip reports C and D timeouts of zero. >>>>>>>>>> >>>>>>>>>> It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic >>>>>>>>>> means to override the chip returned timeouts") we had actually let default >>>>>>>>>> timeout values remain in this case, so let's bring back this behavior to >>>>>>>>>> make chips like Atmel 3203 work again. >>>>>>>>>> >>>>>>>>>> Use a common code that was introduced by that commit so a warning is >>>>>>>>>> printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the >>>>>>>>>> timeouts aren't chip-original. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name> >>>>>>>>>> >>>>>>>>>> Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") >>>>>>>>>> Cc: stable@vger.kernel.org >>>>>>>>> >>>>>>>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> >>>>>>>> >>>>>>>> It's now applied to my master branch so if someone wants to >>>>>>>> test it, it should be fairly easy. >>>>>>> >>>>>>> And I decided to squash the rename commit to it. >>>>>> >>>>>> Wouldn't it be better to squash the rename commit into "fix iTPM probe via >>>>>> probe_itpm() function" patch (if it isn't too late), since they touch the >>>>>> same functionality? >>>>> >>>>> It can be renamed, modified and even dropped as long as it is in my >>>>> master branch and I haven't sent pull request to James Morris. >>>> >>>> I see that "fix iTPM probe via probe_itpm() function" patch isn't present >>>> in your pull request for 4.11. >>>> >>>> What I meant in previous message was that you squashed and "rename >>>> TPM_TIS_ITPM_POSSIBLE to TPM_TIS_ITPM_WORKAROUND" patch into "use default timeout >>>> value if chip reports it as zero" patch while it was logically connected with >>>> "fix iTPM probe via probe_itpm() function" patch instead (which now isn't present >>>> at all in the tree). >>>> Sorry if it wasn't 100% clear. >>> >>> I see. >>> >>> I'll probably send later on pull request with fixes for release content >>> I can include that commit into that pull request. Does that work for >>> you? >> >> Yes, it would be fine, thanks. > > It's now applied and pushed. Almost there: it looks like the last hunk of the patch is missing from the commit. > /Jarkko Maciej
WARNING: multiple messages have this Message-ID (diff)
From: "Maciej S. Szmigiero" <mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org> To: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Cc: Christophe Ricard <christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Subject: Re: [PATCH] tpm_tis: use default timeout value if chip reports it as zero Date: Wed, 25 Jan 2017 22:26:44 +0100 [thread overview] Message-ID: <8e7720cf-6388-dc24-2487-64d932aec874@maciej.szmigiero.name> (raw) In-Reply-To: <20170125200942.d3iumrnpfautlmh7-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> On 25.01.2017 21:09, Jarkko Sakkinen wrote: > On Tue, Jan 24, 2017 at 02:42:29PM +0100, Maciej S. Szmigiero wrote: >> On 24.01.2017 13:01, Jarkko Sakkinen wrote: >>> On Mon, Jan 23, 2017 at 06:23:55PM +0100, Maciej S. Szmigiero wrote: >>>> On 16.01.2017 17:39, Jarkko Sakkinen wrote: >>>>> On Mon, Jan 16, 2017 at 03:58:26PM +0100, Maciej S. Szmigiero wrote: >>>>>> On 16.01.2017 14:55, Jarkko Sakkinen wrote: >>>>>>> On Mon, Jan 16, 2017 at 03:46:12PM +0200, Jarkko Sakkinen wrote: >>>>>>>> On Mon, Jan 16, 2017 at 11:42:02AM +0200, Jarkko Sakkinen wrote: >>>>>>>>> On Fri, Jan 13, 2017 at 10:37:00PM +0100, Maciej S. Szmigiero wrote: >>>>>>>>>> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM >>>>>>>>>> access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no >>>>>>>>>> longer works. >>>>>>>>>> The initialization proceeds fine until we get and start using chip-reported >>>>>>>>>> timeouts - and the chip reports C and D timeouts of zero. >>>>>>>>>> >>>>>>>>>> It turns out that until commit 8e54caf407b98e ("tpm: Provide a generic >>>>>>>>>> means to override the chip returned timeouts") we had actually let default >>>>>>>>>> timeout values remain in this case, so let's bring back this behavior to >>>>>>>>>> make chips like Atmel 3203 work again. >>>>>>>>>> >>>>>>>>>> Use a common code that was introduced by that commit so a warning is >>>>>>>>>> printed in this case and /sys/class/tpm/tpm*/timeouts correctly says the >>>>>>>>>> timeouts aren't chip-original. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Maciej S. Szmigiero <mail-APzI5cXaD1zVlRWJc41N0YvC60bnQu0Y@public.gmane.org> >>>>>>>>>> >>>>>>>>>> Fixes: 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM access") >>>>>>>>>> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org >>>>>>>>> >>>>>>>>> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> >>>>>>>> >>>>>>>> It's now applied to my master branch so if someone wants to >>>>>>>> test it, it should be fairly easy. >>>>>>> >>>>>>> And I decided to squash the rename commit to it. >>>>>> >>>>>> Wouldn't it be better to squash the rename commit into "fix iTPM probe via >>>>>> probe_itpm() function" patch (if it isn't too late), since they touch the >>>>>> same functionality? >>>>> >>>>> It can be renamed, modified and even dropped as long as it is in my >>>>> master branch and I haven't sent pull request to James Morris. >>>> >>>> I see that "fix iTPM probe via probe_itpm() function" patch isn't present >>>> in your pull request for 4.11. >>>> >>>> What I meant in previous message was that you squashed and "rename >>>> TPM_TIS_ITPM_POSSIBLE to TPM_TIS_ITPM_WORKAROUND" patch into "use default timeout >>>> value if chip reports it as zero" patch while it was logically connected with >>>> "fix iTPM probe via probe_itpm() function" patch instead (which now isn't present >>>> at all in the tree). >>>> Sorry if it wasn't 100% clear. >>> >>> I see. >>> >>> I'll probably send later on pull request with fixes for release content >>> I can include that commit into that pull request. Does that work for >>> you? >> >> Yes, it would be fine, thanks. > > It's now applied and pushed. Almost there: it looks like the last hunk of the patch is missing from the commit. > /Jarkko Maciej ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2017-01-25 21:26 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-13 21:37 [PATCH] tpm_tis: use default timeout value if chip reports it as zero Maciej S. Szmigiero 2017-01-16 9:42 ` Jarkko Sakkinen 2017-01-16 13:46 ` Jarkko Sakkinen 2017-01-16 13:46 ` Jarkko Sakkinen 2017-01-16 13:55 ` Jarkko Sakkinen 2017-01-16 13:55 ` Jarkko Sakkinen 2017-01-16 14:58 ` Maciej S. Szmigiero 2017-01-16 16:39 ` Jarkko Sakkinen 2017-01-16 16:39 ` Jarkko Sakkinen 2017-01-23 17:23 ` Maciej S. Szmigiero 2017-01-24 12:01 ` Jarkko Sakkinen 2017-01-24 13:42 ` Maciej S. Szmigiero 2017-01-25 20:09 ` Jarkko Sakkinen 2017-01-25 21:26 ` Maciej S. Szmigiero [this message] 2017-01-25 21:26 ` Maciej S. Szmigiero 2017-01-25 22:58 ` Jarkko Sakkinen 2017-01-25 22:58 ` Jarkko Sakkinen 2017-01-25 23:28 ` Maciej S. Szmigiero
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8e7720cf-6388-dc24-2487-64d932aec874@maciej.szmigiero.name \ --to=mail@maciej.szmigiero.name \ --cc=christophe.ricard@gmail.com \ --cc=jarkko.sakkinen@linux.intel.com \ --cc=jgunthorpe@obsidianresearch.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peterhuewe@gmx.de \ --cc=tpmdd-devel@lists.sourceforge.net \ --cc=tpmdd@selhorst.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.