From: Mark Greer <mgreer@animalcreek.com>
To: Liam Breck <liam@networkimprov.net>
Cc: linux-pm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Liam Breck <kernel@networkimprov.net>,
Matt Ranostay <matt@ranostay.consulting>
Subject: Re: [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume()
Date: Mon, 16 Jan 2017 10:49:35 -0700 [thread overview]
Message-ID: <20170116174935.GC27262@animalcreek.com> (raw)
In-Reply-To: <CAKvHMgS_Es4CrTWCEiYZU1v9VC8pqVnqPfkNoj+g6b6t8wfvQQ@mail.gmail.com>
On Sun, Jan 15, 2017 at 10:07:34PM -0800, Liam Breck wrote:
>
> pm_resume() does a register_reset() which clears charger host mode.
>
> Fix by calling set_mode_host() after the reset.
>
> Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
> Cc: Mark A. Greer <mgreer@animalcreek.com>
> Cc: Matt Ranostay <matt@ranostay.consulting>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
> ---
> drivers/power/supply/bq24190_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index f5746b9..e9e6fe9 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1494,6 +1494,7 @@ static int bq24190_pm_resume(struct device *dev)
>
> pm_runtime_get_sync(bdi->dev);
> bq24190_register_reset(bdi);
> + bq24190_set_mode_host(bdi);
> pm_runtime_put_sync(bdi->dev);
>
> /* Things may have changed while suspended so alert upper layer */
Acked-by: Mark Greer <mgreer@animalcreek.com>
prev parent reply other threads:[~2017-01-16 17:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 6:07 [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume() Liam Breck
2017-01-16 17:49 ` Mark Greer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116174935.GC27262@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=kernel@networkimprov.net \
--cc=liam@networkimprov.net \
--cc=linux-pm@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.