* [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume()
@ 2017-01-16 6:07 Liam Breck
2017-01-16 17:49 ` Mark Greer
0 siblings, 1 reply; 2+ messages in thread
From: Liam Breck @ 2017-01-16 6:07 UTC (permalink / raw)
To: linux-pm
Cc: Sebastian Reichel, Tony Lindgren, Mark A . Greer, Liam Breck,
Matt Ranostay
[-- Attachment #1: Type: text/plain, Size: 1 bytes --]
[-- Attachment #2: patch-v2-2of6.txt --]
[-- Type: text/plain, Size: 973 bytes --]
pm_resume() does a register_reset() which clears charger host mode.
Fix by calling set_mode_host() after the reset.
Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
Cc: Mark A. Greer <mgreer@animalcreek.com>
Cc: Matt Ranostay <matt@ranostay.consulting>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Liam Breck <kernel@networkimprov.net>
---
drivers/power/supply/bq24190_charger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index f5746b9..e9e6fe9 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1494,6 +1494,7 @@ static int bq24190_pm_resume(struct device *dev)
pm_runtime_get_sync(bdi->dev);
bq24190_register_reset(bdi);
+ bq24190_set_mode_host(bdi);
pm_runtime_put_sync(bdi->dev);
/* Things may have changed while suspended so alert upper layer */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume()
2017-01-16 6:07 [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume() Liam Breck
@ 2017-01-16 17:49 ` Mark Greer
0 siblings, 0 replies; 2+ messages in thread
From: Mark Greer @ 2017-01-16 17:49 UTC (permalink / raw)
To: Liam Breck
Cc: linux-pm, Sebastian Reichel, Tony Lindgren, Liam Breck, Matt Ranostay
On Sun, Jan 15, 2017 at 10:07:34PM -0800, Liam Breck wrote:
>
> pm_resume() does a register_reset() which clears charger host mode.
>
> Fix by calling set_mode_host() after the reset.
>
> Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
> Cc: Mark A. Greer <mgreer@animalcreek.com>
> Cc: Matt Ranostay <matt@ranostay.consulting>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Liam Breck <kernel@networkimprov.net>
> ---
> drivers/power/supply/bq24190_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index f5746b9..e9e6fe9 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -1494,6 +1494,7 @@ static int bq24190_pm_resume(struct device *dev)
>
> pm_runtime_get_sync(bdi->dev);
> bq24190_register_reset(bdi);
> + bq24190_set_mode_host(bdi);
> pm_runtime_put_sync(bdi->dev);
>
> /* Things may have changed while suspended so alert upper layer */
Acked-by: Mark Greer <mgreer@animalcreek.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-16 17:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16 6:07 [PATCH v2 2/6] power: bq24190_charger: Call set_mode_host() on pm_resume() Liam Breck
2017-01-16 17:49 ` Mark Greer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.