All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
	alexandre.torgue@st.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
	jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, fabrice.gasnier@st.com,
	gerald.baeza@st.com, arnaud.pouliquen@st.com,
	linus.walleij@linaro.org, linaro-kernel@lists.linaro.org,
	Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v7 4/8] PWM: add PWM driver for STM32 plaftorm
Date: Wed, 18 Jan 2017 11:16:28 +0100	[thread overview]
Message-ID: <20170118101628.GG18989@ulmo.ba.sec> (raw)
In-Reply-To: <1483608344-9012-5-git-send-email-benjamin.gaignard@st.com>

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Thu, Jan 05, 2017 at 10:25:40AM +0100, Benjamin Gaignard wrote:
[...]
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index f92dd41..88035c0 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -397,6 +397,15 @@ config PWM_STI
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called pwm-sti.
>  
> +config PWM_STM32
> +	tristate "STMicroelectronics STM32 PWM"
> +	depends on (ARCH_STM32 && OF && MFD_STM32_TIMERS) || COMPILE_TEST

One other thing: is the dependency on ARCH_STM32 and OF necessary here?
ARCH_STM32 and OF are both pulled in by MFD_STM32_TIMERS. The dependency
is probably fine for MFD_STM32_TIMERS, though even there && OF seems too
much, since it's already pulled in via ARCH_STM32 -> ARM_SINGLE_ARMV7M
-> USE_OF.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 4/8] PWM: add PWM driver for STM32 plaftorm
Date: Wed, 18 Jan 2017 11:16:28 +0100	[thread overview]
Message-ID: <20170118101628.GG18989@ulmo.ba.sec> (raw)
In-Reply-To: <1483608344-9012-5-git-send-email-benjamin.gaignard@st.com>

On Thu, Jan 05, 2017 at 10:25:40AM +0100, Benjamin Gaignard wrote:
[...]
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index f92dd41..88035c0 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -397,6 +397,15 @@ config PWM_STI
>  	  To compile this driver as a module, choose M here: the module
>  	  will be called pwm-sti.
>  
> +config PWM_STM32
> +	tristate "STMicroelectronics STM32 PWM"
> +	depends on (ARCH_STM32 && OF && MFD_STM32_TIMERS) || COMPILE_TEST

One other thing: is the dependency on ARCH_STM32 and OF necessary here?
ARCH_STM32 and OF are both pulled in by MFD_STM32_TIMERS. The dependency
is probably fine for MFD_STM32_TIMERS, though even there && OF seems too
much, since it's already pulled in via ARCH_STM32 -> ARM_SINGLE_ARMV7M
-> USE_OF.

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170118/f45a1318/attachment.sig>

  parent reply	other threads:[~2017-01-18 10:16 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05  9:25 [PATCH v7 0/8] Add PWM and IIO timer drivers for STM32 Benjamin Gaignard
2017-01-05  9:25 ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 1/8] MFD: add bindings for STM32 Timers driver Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-09 17:59   ` Rob Herring
2017-01-09 17:59     ` Rob Herring
2017-01-09 17:59     ` Rob Herring
2017-01-05  9:25 ` [PATCH v7 2/8] MFD: add " Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-09 18:00   ` Rob Herring
2017-01-09 18:00     ` Rob Herring
2017-01-10  8:56     ` Benjamin Gaignard
2017-01-10  8:56       ` Benjamin Gaignard
2017-01-10  8:56       ` Benjamin Gaignard
2017-01-10  8:56       ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 3/8] PWM: add pwm-stm32 DT bindings Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-09 18:01   ` Rob Herring
2017-01-09 18:01     ` Rob Herring
2017-01-18  9:20   ` Thierry Reding
2017-01-18  9:20     ` Thierry Reding
2017-01-18  9:20     ` Thierry Reding
2017-01-18  9:42     ` Benjamin Gaignard
2017-01-18  9:42       ` Benjamin Gaignard
2017-01-18  9:42       ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 4/8] PWM: add PWM driver for STM32 plaftorm Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-18 10:08   ` Thierry Reding
2017-01-18 10:08     ` Thierry Reding
2017-01-18 10:08     ` Thierry Reding
2017-01-18 11:15     ` Benjamin Gaignard
2017-01-18 11:15       ` Benjamin Gaignard
2017-01-18 11:15       ` Benjamin Gaignard
2017-01-18 11:15       ` Benjamin Gaignard
2017-01-18 11:37       ` Thierry Reding
2017-01-18 11:37         ` Thierry Reding
2017-01-18 12:37         ` Benjamin Gaignard
2017-01-18 12:37           ` Benjamin Gaignard
2017-01-18 12:37           ` Benjamin Gaignard
2017-01-18 12:37           ` Benjamin Gaignard
2017-01-18 10:16   ` Thierry Reding [this message]
2017-01-18 10:16     ` Thierry Reding
2017-01-18 11:16     ` Benjamin Gaignard
2017-01-18 11:16       ` Benjamin Gaignard
2017-01-18 11:16       ` Benjamin Gaignard
2017-01-18 11:16       ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 5/8] IIO: add bindings for STM32 timer trigger driver Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-08 11:23   ` Jonathan Cameron
2017-01-08 11:23     ` Jonathan Cameron
2017-01-09 18:04   ` Rob Herring
2017-01-09 18:04     ` Rob Herring
2017-01-09 18:04     ` Rob Herring
2017-01-10  8:55     ` Benjamin Gaignard
2017-01-10  8:55       ` Benjamin Gaignard
2017-01-10  8:55       ` Benjamin Gaignard
2017-01-10  8:55       ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 6/8] IIO: add " Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-08 11:30   ` Jonathan Cameron
2017-01-08 11:30     ` Jonathan Cameron
2017-01-05  9:25 ` [PATCH v7 7/8] ARM: dts: stm32: add Timers driver for stm32f429 MCU Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05  9:25 ` [PATCH v7 8/8] ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco Benjamin Gaignard
2017-01-05  9:25   ` Benjamin Gaignard
2017-01-05 14:49 ` [PATCH v7 0/8] Add PWM and IIO timer drivers for STM32 Lee Jones
2017-01-05 14:49   ` Lee Jones
2017-01-06  7:58   ` Benjamin Gaignard
2017-01-06  7:58     ` Benjamin Gaignard
2017-01-06  7:58     ` Benjamin Gaignard
2017-01-13 12:30     ` Benjamin Gaignard
2017-01-13 12:30       ` Benjamin Gaignard
2017-01-13 12:30       ` Benjamin Gaignard
2017-01-13 12:30       ` Benjamin Gaignard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118101628.GG18989@ulmo.ba.sec \
    --to=thierry.reding@gmail.com \
    --cc=alexandre.torgue@st.com \
    --cc=arnaud.pouliquen@st.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=benjamin.gaignard@st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrice.gasnier@st.com \
    --cc=gerald.baeza@st.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.