From: Eduardo Valentin <edubezval@gmail.com> To: kernel@martin.sperl.org Cc: Zhang Rui <rui.zhang@intel.com>, Lee Jones <lee@kernel.org>, Eric Anholt <eric@anholt.net>, linux-pm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc Date: Thu, 19 Jan 2017 20:14:02 -0800 [thread overview] Message-ID: <20170120041400.GA24617@localhost.localdomain> (raw) In-Reply-To: <1483808145-6206-1-git-send-email-kernel@martin.sperl.org> Hello Martin, On Sat, Jan 07, 2017 at 04:55:45PM +0000, kernel@martin.sperl.org wrote: > From: Martin Sperl <kernel@martin.sperl.org> > > Add basic thermal driver for bcm2835 SOC. > > This driver currently relies on the firmware setting up the > tsense HW block and does not set it up itself. > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org> > Acked-by: Eric Anholt <eric@anholt.net> > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > <cut> > + > +static const struct of_device_id bcm2835_thermal_of_match_table[] = { > + { > + .compatible = "brcm,bcm2835-thermal", > + .data = &(struct bcm2835_thermal_info) { > + .offset = 407000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + { > + .compatible = "brcm,bcm2836-thermal", > + .data = &(struct bcm2835_thermal_info) { > + .offset = 407000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + { > + .compatible = "brcm,bcm2837-thermal", > + .data = &(struct bcm2835_thermal_info) { > + /* the bcm2837 needs adjustment of +5C */ > + .offset = 407000 + 5000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + {}, Just for the same of clarification, is there anything preventing this driver of using of-thermal API? the above data (slope, offset, and trip_temps) would be in DT the place where they are supposed to be, instead of code. > +}; > +MODULE_DEVICE_TABLE(of, bcm2835_thermal_of_match_table); > + > +static struct platform_driver bcm2835_thermal_driver = { > + .probe = bcm2835_thermal_probe, > + .remove = bcm2835_thermal_remove, > + .driver = { > + .name = "bcm2835_thermal", > + .of_match_table = bcm2835_thermal_of_match_table, > + }, > +}; > +module_platform_driver(bcm2835_thermal_driver); > + > +MODULE_AUTHOR("Martin Sperl"); > +MODULE_DESCRIPTION("Thermal driver for bcm2835 chip"); > +MODULE_LICENSE("GPL"); > -- > 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc Date: Thu, 19 Jan 2017 20:14:02 -0800 [thread overview] Message-ID: <20170120041400.GA24617@localhost.localdomain> (raw) In-Reply-To: <1483808145-6206-1-git-send-email-kernel@martin.sperl.org> Hello Martin, On Sat, Jan 07, 2017 at 04:55:45PM +0000, kernel at martin.sperl.org wrote: > From: Martin Sperl <kernel@martin.sperl.org> > > Add basic thermal driver for bcm2835 SOC. > > This driver currently relies on the firmware setting up the > tsense HW block and does not set it up itself. > > Signed-off-by: Martin Sperl <kernel@martin.sperl.org> > Acked-by: Eric Anholt <eric@anholt.net> > Acked-by: Stefan Wahren <stefan.wahren@i2se.com> > <cut> > + > +static const struct of_device_id bcm2835_thermal_of_match_table[] = { > + { > + .compatible = "brcm,bcm2835-thermal", > + .data = &(struct bcm2835_thermal_info) { > + .offset = 407000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + { > + .compatible = "brcm,bcm2836-thermal", > + .data = &(struct bcm2835_thermal_info) { > + .offset = 407000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + { > + .compatible = "brcm,bcm2837-thermal", > + .data = &(struct bcm2835_thermal_info) { > + /* the bcm2837 needs adjustment of +5C */ > + .offset = 407000 + 5000, > + .slope = -538, > + .trip_temp = 80000 > + } > + }, > + {}, Just for the same of clarification, is there anything preventing this driver of using of-thermal API? the above data (slope, offset, and trip_temps) would be in DT the place where they are supposed to be, instead of code. > +}; > +MODULE_DEVICE_TABLE(of, bcm2835_thermal_of_match_table); > + > +static struct platform_driver bcm2835_thermal_driver = { > + .probe = bcm2835_thermal_probe, > + .remove = bcm2835_thermal_remove, > + .driver = { > + .name = "bcm2835_thermal", > + .of_match_table = bcm2835_thermal_of_match_table, > + }, > +}; > +module_platform_driver(bcm2835_thermal_driver); > + > +MODULE_AUTHOR("Martin Sperl"); > +MODULE_DESCRIPTION("Thermal driver for bcm2835 chip"); > +MODULE_LICENSE("GPL"); > -- > 2.1.4
next prev parent reply other threads:[~2017-01-20 4:14 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-07 16:55 [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc kernel 2017-01-07 16:55 ` kernel at martin.sperl.org 2017-01-20 4:14 ` Eduardo Valentin [this message] 2017-01-20 4:14 ` Eduardo Valentin 2017-01-20 4:23 ` Eduardo Valentin 2017-01-20 4:23 ` Eduardo Valentin [not found] ` <20170120042323.GA6651-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-01-20 8:43 ` kernel-TqfNSX0MhmxHKSADF0wUEw 2017-01-20 8:43 ` kernel at martin.sperl.org 2017-01-24 9:26 ` Eduardo Valentin 2017-01-24 9:26 ` Eduardo Valentin 2017-01-24 9:37 ` kernel 2017-01-24 9:37 ` kernel at martin.sperl.org [not found] ` <20170120041400.GA24617-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-01-20 7:54 ` kernel-TqfNSX0MhmxHKSADF0wUEw 2017-01-20 7:54 ` kernel at martin.sperl.org [not found] ` <060918B6-A773-46A5-8D10-C9F6BBA6D3F1-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2017-01-24 9:31 ` Eduardo Valentin 2017-01-24 9:31 ` Eduardo Valentin 2017-01-24 9:52 ` kernel 2017-01-24 9:52 ` kernel at martin.sperl.org 2017-02-02 4:29 ` Eduardo Valentin 2017-02-02 4:29 ` Eduardo Valentin 2017-02-04 8:35 ` kernel 2017-02-04 8:35 ` kernel at martin.sperl.org 2017-02-04 14:16 ` [PATCH 1/2] dt-bindings: Add thermal zone to bcm2835-thermal example Stefan Wahren 2017-02-04 14:16 ` [PATCH 2/2] ARM: dts: bcm283x: Add critical thermal zone for GPU Stefan Wahren [not found] ` <1486217787-15703-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org> 2017-02-08 4:19 ` Eduardo Valentin [not found] ` <20170208041929.GA6809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-02-08 4:23 ` Eduardo Valentin [not found] ` <20170208042351.GB6809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-02-08 9:56 ` Stefan Wahren 2017-02-08 19:50 ` Eric Anholt 2017-02-09 17:48 ` Stefan Wahren [not found] ` <124007607.358509.1486662532562-7tX72C7vayboQLBSYMtkGA@public.gmane.org> 2017-02-09 23:34 ` Eric Anholt 2017-02-08 22:02 ` [PATCH 1/2] dt-bindings: Add thermal zone to bcm2835-thermal example Rob Herring [not found] ` <E0A4388D-788A-40B4-9193-36FD75284654-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> 2017-02-08 4:31 ` [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc Eduardo Valentin 2017-02-08 4:31 ` Eduardo Valentin [not found] ` <20170208043107.GA7097-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-02-08 8:19 ` kernel-TqfNSX0MhmxHKSADF0wUEw 2017-02-08 8:19 ` kernel at martin.sperl.org 2017-02-04 9:36 ` Stefan Wahren 2017-02-04 9:36 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170120041400.GA24617@localhost.localdomain \ --to=edubezval@gmail.com \ --cc=eric@anholt.net \ --cc=kernel@martin.sperl.org \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=rui.zhang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.