All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Valentin <edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-rpi-kernel
	<linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc
Date: Tue, 7 Feb 2017 20:31:09 -0800	[thread overview]
Message-ID: <20170208043107.GA7097@localhost.localdomain> (raw)
In-Reply-To: <E0A4388D-788A-40B4-9193-36FD75284654-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>

On Sat, Feb 04, 2017 at 09:35:47AM +0100, kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org wrote:
> 

> So how does this change/impact the driver code itself?
> 
> Defining a thermal zone in the dts is just an additional feature
> that only impacts the device tree.
> The DT as is works fine and at least allows to read the current temperature.

Well, your driver is still half finished. It is a DT only driver, which
does not follow the DT spec on thermal. The impact on your code is that
it wont need to carry your hardware data in the source code.

Also, having the data described in DT allows you porting your driver
without patching it, in  case you need, or any other system engineer,
to have different thermal data, trips values, number or trips, offset
and slope per sensor, on different boards, or even on different chip
version.

Not to say that having the data described in DT also allows system
engineers to deploy different thermal zones, based on your
driver/sensor, to extrapolate different hotspots.

> Martin
> 
BR,

Eduardo Valentin

WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc
Date: Tue, 7 Feb 2017 20:31:09 -0800	[thread overview]
Message-ID: <20170208043107.GA7097@localhost.localdomain> (raw)
In-Reply-To: <E0A4388D-788A-40B4-9193-36FD75284654@martin.sperl.org>

On Sat, Feb 04, 2017 at 09:35:47AM +0100, kernel at martin.sperl.org wrote:
> 

> So how does this change/impact the driver code itself?
> 
> Defining a thermal zone in the dts is just an additional feature
> that only impacts the device tree.
> The DT as is works fine and at least allows to read the current temperature.

Well, your driver is still half finished. It is a DT only driver, which
does not follow the DT spec on thermal. The impact on your code is that
it wont need to carry your hardware data in the source code.

Also, having the data described in DT allows you porting your driver
without patching it, in  case you need, or any other system engineer,
to have different thermal data, trips values, number or trips, offset
and slope per sensor, on different boards, or even on different chip
version.

Not to say that having the data described in DT also allows system
engineers to deploy different thermal zones, based on your
driver/sensor, to extrapolate different hotspots.

> Martin
> 
BR,

Eduardo Valentin

  parent reply	other threads:[~2017-02-08  4:31 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07 16:55 [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc kernel
2017-01-07 16:55 ` kernel at martin.sperl.org
2017-01-20  4:14 ` Eduardo Valentin
2017-01-20  4:14   ` Eduardo Valentin
2017-01-20  4:23   ` Eduardo Valentin
2017-01-20  4:23     ` Eduardo Valentin
     [not found]     ` <20170120042323.GA6651-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-01-20  8:43       ` kernel-TqfNSX0MhmxHKSADF0wUEw
2017-01-20  8:43         ` kernel at martin.sperl.org
2017-01-24  9:26         ` Eduardo Valentin
2017-01-24  9:26           ` Eduardo Valentin
2017-01-24  9:37           ` kernel
2017-01-24  9:37             ` kernel at martin.sperl.org
     [not found]   ` <20170120041400.GA24617-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-01-20  7:54     ` kernel-TqfNSX0MhmxHKSADF0wUEw
2017-01-20  7:54       ` kernel at martin.sperl.org
     [not found]       ` <060918B6-A773-46A5-8D10-C9F6BBA6D3F1-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-01-24  9:31         ` Eduardo Valentin
2017-01-24  9:31           ` Eduardo Valentin
2017-01-24  9:52           ` kernel
2017-01-24  9:52             ` kernel at martin.sperl.org
2017-02-02  4:29             ` Eduardo Valentin
2017-02-02  4:29               ` Eduardo Valentin
2017-02-04  8:35               ` kernel
2017-02-04  8:35                 ` kernel at martin.sperl.org
2017-02-04 14:16                 ` [PATCH 1/2] dt-bindings: Add thermal zone to bcm2835-thermal example Stefan Wahren
2017-02-04 14:16                   ` [PATCH 2/2] ARM: dts: bcm283x: Add critical thermal zone for GPU Stefan Wahren
     [not found]                     ` <1486217787-15703-2-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2017-02-08  4:19                       ` Eduardo Valentin
     [not found]                         ` <20170208041929.GA6809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-02-08  4:23                           ` Eduardo Valentin
     [not found]                             ` <20170208042351.GB6809-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-02-08  9:56                               ` Stefan Wahren
2017-02-08 19:50                                 ` Eric Anholt
2017-02-09 17:48                                   ` Stefan Wahren
     [not found]                                     ` <124007607.358509.1486662532562-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2017-02-09 23:34                                       ` Eric Anholt
2017-02-08 22:02                   ` [PATCH 1/2] dt-bindings: Add thermal zone to bcm2835-thermal example Rob Herring
     [not found]                 ` <E0A4388D-788A-40B4-9193-36FD75284654-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org>
2017-02-08  4:31                   ` Eduardo Valentin [this message]
2017-02-08  4:31                     ` [PATCH V9] thermal: bcm2835: add thermal driver for bcm2835 soc Eduardo Valentin
     [not found]                     ` <20170208043107.GA7097-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2017-02-08  8:19                       ` kernel-TqfNSX0MhmxHKSADF0wUEw
2017-02-08  8:19                         ` kernel at martin.sperl.org
2017-02-04  9:36               ` Stefan Wahren
2017-02-04  9:36                 ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208043107.GA7097@localhost.localdomain \
    --to=edubezval-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=kernel-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org \
    --cc=lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.