All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Cathy Avery <cavery@redhat.com>
Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com, haiyangz@microsoft.com,
	linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	devel@linuxdriverproject.org
Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.
Date: Sun, 22 Jan 2017 22:24:06 +0300	[thread overview]
Message-ID: <20170122192406.GJ4454@mwanda> (raw)
In-Reply-To: <5884FF21.3050801@redhat.com>

On Sun, Jan 22, 2017 at 01:51:13PM -0500, Cathy Avery wrote:
> I'm sorry.  In my zeal to push out this patch I have done a poor job
> of communication on a number of levels.
> 
> The first patch which deals with the fc transport changes will not
> set the scsi_transport_template.eh_timed_out function directly
> during lightweight fc_attach_transport(). It instead relies on
> whatever was indicated as the scsi_host_template timeout handler
> during inscsi_times_out() scsi_error.c.
> 
> So yes in a sense it is related but now I believe I understand your
> point. Perhaps this would fall more under the heading of post
> fc_transport implementation storvsc cleanup necessitating its own
> patch.
> 
> I will break it out in the next go round.

Ah...  Actually it probably belongs in this patch, it just wasn't
obvious to me how they were related (I'm a total newbie with this code
so that's probably part of the confusion).  Since you're resend the code
anyway, could you just add this information to the commit message?

regards,
dan carpenter

  reply	other threads:[~2017-01-22 19:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 20:28 [PATCH 0/2] scsi: Create a lightweight FC Transport option for Virtual FC Hosts Cathy Avery
2017-01-18 20:28 ` [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight " Cathy Avery
2017-01-19 15:11   ` Christoph Hellwig
2017-01-19 15:11     ` Christoph Hellwig
2017-01-19 17:59     ` Cathy Avery
2017-01-19 17:59       ` Cathy Avery
2017-01-27 15:45     ` KY Srinivasan
2017-01-27 15:45       ` KY Srinivasan
2017-01-18 20:28 ` [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host Cathy Avery
2017-01-18 23:15   ` Dan Carpenter
2017-01-18 23:15     ` Dan Carpenter
2017-01-19 17:55     ` Cathy Avery
2017-01-19 17:55       ` Cathy Avery
2017-01-20  9:31       ` Dan Carpenter
2017-01-20  9:31         ` Dan Carpenter
2017-01-22 18:51         ` Cathy Avery
2017-01-22 18:51           ` Cathy Avery
2017-01-22 19:24           ` Dan Carpenter [this message]
2017-01-23  3:13   ` Fam Zheng
2017-01-23  3:13     ` Fam Zheng
2017-01-23 20:55     ` Cathy Avery
2017-01-23 20:55       ` Cathy Avery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170122192406.GJ4454@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=cavery@redhat.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=hch@infradead.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.