From: Cathy Avery <cavery@redhat.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: kys@microsoft.com, haiyangz@microsoft.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Date: Thu, 19 Jan 2017 12:55:27 -0500 [thread overview] Message-ID: <5880FD8F.8020608@redhat.com> (raw) In-Reply-To: <20170118231555.GC4454@mwanda> On 01/18/2017 06:15 PM, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: >> Enable FC lightweight host option so that the luns exposed by >> the driver may be manually scanned. >> >> Signed-off-by: Cathy Avery <cavery@redhat.com> >> --- >> drivers/scsi/storvsc_drv.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c >> index 888e16e..fc1d6ba 100644 >> --- a/drivers/scsi/storvsc_drv.c >> +++ b/drivers/scsi/storvsc_drv.c >> @@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { >> static struct fc_function_template fc_transport_functions = { >> .show_host_node_name = 1, >> .show_host_port_name = 1, >> + .lightweight_transport = 1, >> }; >> #endif >> >> @@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) >> fc_transport_template = fc_attach_transport(&fc_transport_functions); >> if (!fc_transport_template) >> return -ENODEV; >> - >> - /* >> - * Install Hyper-V specific timeout handler. >> - */ >> - fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > I don't undestand how removing this is related. Its not related but it is also not necessary so I took it out. The default scsi timeout handler will be used. I can certainly put it back. Cathy > > regards, > dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Cathy Avery <cavery@redhat.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org Subject: Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host. Date: Thu, 19 Jan 2017 12:55:27 -0500 [thread overview] Message-ID: <5880FD8F.8020608@redhat.com> (raw) In-Reply-To: <20170118231555.GC4454@mwanda> On 01/18/2017 06:15 PM, Dan Carpenter wrote: > On Wed, Jan 18, 2017 at 03:28:58PM -0500, Cathy Avery wrote: >> Enable FC lightweight host option so that the luns exposed by >> the driver may be manually scanned. >> >> Signed-off-by: Cathy Avery <cavery@redhat.com> >> --- >> drivers/scsi/storvsc_drv.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c >> index 888e16e..fc1d6ba 100644 >> --- a/drivers/scsi/storvsc_drv.c >> +++ b/drivers/scsi/storvsc_drv.c >> @@ -1882,6 +1882,7 @@ static struct hv_driver storvsc_drv = { >> static struct fc_function_template fc_transport_functions = { >> .show_host_node_name = 1, >> .show_host_port_name = 1, >> + .lightweight_transport = 1, >> }; >> #endif >> >> @@ -1906,11 +1907,6 @@ static int __init storvsc_drv_init(void) >> fc_transport_template = fc_attach_transport(&fc_transport_functions); >> if (!fc_transport_template) >> return -ENODEV; >> - >> - /* >> - * Install Hyper-V specific timeout handler. >> - */ >> - fc_transport_template->eh_timed_out = storvsc_eh_timed_out; > I don't undestand how removing this is related. Its not related but it is also not necessary so I took it out. The default scsi timeout handler will be used. I can certainly put it back. Cathy > > regards, > dan carpenter
next prev parent reply other threads:[~2017-01-19 18:21 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-18 20:28 [PATCH 0/2] scsi: Create a lightweight FC Transport option for Virtual FC Hosts Cathy Avery 2017-01-18 20:28 ` [PATCH 1/2] scsi: scsi_transport_fc: Provide a lightweight " Cathy Avery 2017-01-19 15:11 ` Christoph Hellwig 2017-01-19 15:11 ` Christoph Hellwig 2017-01-19 17:59 ` Cathy Avery 2017-01-19 17:59 ` Cathy Avery 2017-01-27 15:45 ` KY Srinivasan 2017-01-27 15:45 ` KY Srinivasan 2017-01-18 20:28 ` [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host Cathy Avery 2017-01-18 23:15 ` Dan Carpenter 2017-01-18 23:15 ` Dan Carpenter 2017-01-19 17:55 ` Cathy Avery [this message] 2017-01-19 17:55 ` Cathy Avery 2017-01-20 9:31 ` Dan Carpenter 2017-01-20 9:31 ` Dan Carpenter 2017-01-22 18:51 ` Cathy Avery 2017-01-22 18:51 ` Cathy Avery 2017-01-22 19:24 ` Dan Carpenter 2017-01-23 3:13 ` Fam Zheng 2017-01-23 3:13 ` Fam Zheng 2017-01-23 20:55 ` Cathy Avery 2017-01-23 20:55 ` Cathy Avery
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5880FD8F.8020608@redhat.com \ --to=cavery@redhat.com \ --cc=dan.carpenter@oracle.com \ --cc=devel@linuxdriverproject.org \ --cc=haiyangz@microsoft.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=kys@microsoft.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.