From: kbuild test robot <lkp@intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: kbuild-all@01.org, kvm@vger.kernel.org,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/9] KVM: Adjust seven checks for null pointers
Date: Mon, 23 Jan 2017 04:32:10 +0800 [thread overview]
Message-ID: <201701230452.7byWGayX%fengguang.wu@intel.com> (raw)
In-Reply-To: <d6a66841-b6f4-f888-51e8-f1ad124874ab@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
Hi Markus,
[auto build test WARNING on kvm/linux-next]
[also build test WARNING on v4.10-rc4 next-20170120]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/KVM-Fine-tuning-for-several-function-implementations/20170123-022323
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_make_all_cpus_request':
>> arch/x86/kvm/../../../virt/kvm/kvm_main.c:187:7: warning: the address of 'cpus' will always evaluate as 'true' [-Waddress]
if (cpus && cpu != -1 && cpu != me &&
^~~~
vim +187 arch/x86/kvm/../../../virt/kvm/kvm_main.c
171 {
172 int i, cpu, me;
173 cpumask_var_t cpus;
174 bool called = true;
175 struct kvm_vcpu *vcpu;
176
177 zalloc_cpumask_var(&cpus, GFP_ATOMIC);
178
179 me = get_cpu();
180 kvm_for_each_vcpu(i, vcpu, kvm) {
181 kvm_make_request(req, vcpu);
182 cpu = vcpu->cpu;
183
184 /* Set ->requests bit before we read ->mode. */
185 smp_mb__after_atomic();
186
> 187 if (cpus && cpu != -1 && cpu != me &&
188 kvm_vcpu_exiting_guest_mode(vcpu) != OUTSIDE_GUEST_MODE)
189 cpumask_set_cpu(cpu, cpus);
190 }
191 if (unlikely(cpus == NULL))
192 smp_call_function_many(cpu_online_mask, ack_flush, NULL, 1);
193 else if (!cpumask_empty(cpus))
194 smp_call_function_many(cpus, ack_flush, NULL, 1);
195 else
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38049 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 8/9] KVM: Adjust seven checks for null pointers
Date: Sun, 22 Jan 2017 20:32:10 +0000 [thread overview]
Message-ID: <201701230452.7byWGayX%fengguang.wu@intel.com> (raw)
In-Reply-To: <d6a66841-b6f4-f888-51e8-f1ad124874ab@users.sourceforge.net>
[-- Attachment #1: Type: text/plain, Size: 1934 bytes --]
Hi Markus,
[auto build test WARNING on kvm/linux-next]
[also build test WARNING on v4.10-rc4 next-20170120]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/KVM-Fine-tuning-for-several-function-implementations/20170123-022323
base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
arch/x86/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_make_all_cpus_request':
>> arch/x86/kvm/../../../virt/kvm/kvm_main.c:187:7: warning: the address of 'cpus' will always evaluate as 'true' [-Waddress]
if (cpus && cpu != -1 && cpu != me &&
^~~~
vim +187 arch/x86/kvm/../../../virt/kvm/kvm_main.c
171 {
172 int i, cpu, me;
173 cpumask_var_t cpus;
174 bool called = true;
175 struct kvm_vcpu *vcpu;
176
177 zalloc_cpumask_var(&cpus, GFP_ATOMIC);
178
179 me = get_cpu();
180 kvm_for_each_vcpu(i, vcpu, kvm) {
181 kvm_make_request(req, vcpu);
182 cpu = vcpu->cpu;
183
184 /* Set ->requests bit before we read ->mode. */
185 smp_mb__after_atomic();
186
> 187 if (cpus && cpu != -1 && cpu != me &&
188 kvm_vcpu_exiting_guest_mode(vcpu) != OUTSIDE_GUEST_MODE)
189 cpumask_set_cpu(cpu, cpus);
190 }
191 if (unlikely(cpus == NULL))
192 smp_call_function_many(cpu_online_mask, ack_flush, NULL, 1);
193 else if (!cpumask_empty(cpus))
194 smp_call_function_many(cpus, ack_flush, NULL, 1);
195 else
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38049 bytes --]
next prev parent reply other threads:[~2017-01-22 20:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 18:09 [PATCH 0/9] KVM: Fine-tuning for several function implementations SF Markus Elfring
2017-01-22 18:09 ` SF Markus Elfring
2017-01-22 18:11 ` [PATCH 1/9] KVM: Return directly after a failed copy_from_user() in kvm_vm_compat_ioctl() SF Markus Elfring
2017-01-22 18:11 ` SF Markus Elfring
2017-01-22 18:12 ` [PATCH 2/9] KVM: Move error code settings in kvm_vm_ioctl() SF Markus Elfring
2017-01-22 18:12 ` SF Markus Elfring
2017-01-22 18:13 ` [PATCH 3/9] KVM: Move error code settings in kvm_vcpu_compat_ioctl() SF Markus Elfring
2017-01-22 18:13 ` SF Markus Elfring
2017-01-22 18:14 ` [PATCH 4/9] KVM: Move error code settings in kvm_vcpu_ioctl() SF Markus Elfring
2017-01-22 18:14 ` SF Markus Elfring
2017-01-22 18:15 ` [PATCH 5/9] KVM: Improve size determinations " SF Markus Elfring
2017-01-22 18:15 ` SF Markus Elfring
2017-01-22 18:16 ` [PATCH 6/9] KVM: Return an error code only as a constant in kvm_get_dirty_log_protect() SF Markus Elfring
2017-01-22 18:16 ` SF Markus Elfring
2017-01-22 18:17 ` [PATCH 7/9] KVM: Return an error code only as a constant in kvm_get_dirty_log() SF Markus Elfring
2017-01-22 18:17 ` SF Markus Elfring
2017-01-22 18:18 ` [PATCH 8/9] KVM: Adjust seven checks for null pointers SF Markus Elfring
2017-01-22 18:18 ` SF Markus Elfring
2017-01-22 20:32 ` kbuild test robot [this message]
2017-01-22 20:32 ` kbuild test robot
2017-01-22 21:35 ` kbuild test robot
2017-01-22 21:35 ` kbuild test robot
2017-01-23 9:30 ` Dan Carpenter
2017-01-23 9:30 ` Dan Carpenter
2017-01-22 18:19 ` [PATCH 9/9] KVM: Improve another size determination in kvm_create_vm() SF Markus Elfring
2017-01-22 18:19 ` SF Markus Elfring
2017-01-23 9:22 ` [PATCH 0/9] KVM: Fine-tuning for several function implementations Paolo Bonzini
2017-01-23 9:22 ` Paolo Bonzini
2017-01-23 9:48 ` SF Markus Elfring
2017-01-23 9:48 ` SF Markus Elfring
2017-01-23 14:06 ` Paolo Bonzini
2017-01-23 14:06 ` Paolo Bonzini
2017-01-24 2:15 ` Bernd Petrovitsch
2017-01-24 2:15 ` Bernd Petrovitsch
2017-01-24 11:36 ` SF Markus Elfring
2017-01-24 11:36 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201701230452.7byWGayX%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=elfring@users.sourceforge.net \
--cc=kbuild-all@01.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.