All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
	kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/9] KVM: Fine-tuning for several function implementations
Date: Mon, 23 Jan 2017 10:22:18 +0100	[thread overview]
Message-ID: <5e40aa05-ccdf-0995-e1c4-a331d1da998a@redhat.com> (raw)
In-Reply-To: <a2fb541a-7a7d-1f78-b587-1191b9832088@users.sourceforge.net>



On 22/01/2017 19:09, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Jan 2017 19:06:54 +0100
> 
> Several update suggestions were taken into account
> from static source code analysis.

Patches 1, 6 and 7 are acceptable.  The others are useless churn or they
make the result uselessly different from the rest of KVM code.

Paolo

> Markus Elfring (9):
>   Return directly after a failed copy_from_user() in kvm_vm_compat_ioctl()
>   Move error code settings in kvm_vm_ioctl()
>   Move error code settings in kvm_vcpu_compat_ioctl()
>   Move error code settings in kvm_vcpu_ioctl()
>   Improve size determinations in kvm_vcpu_ioctl()
>   Return an error code only as a constant in kvm_get_dirty_log_protect()
>   Return an error code only as a constant in kvm_get_dirty_log()
>   Adjust seven checks for null pointers
>   Improve another size determination in kvm_create_vm()
> 
>  virt/kvm/kvm_main.c | 278 +++++++++++++++++++++++-----------------------------
>  1 file changed, 120 insertions(+), 158 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
	kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/9] KVM: Fine-tuning for several function implementations
Date: Mon, 23 Jan 2017 09:22:18 +0000	[thread overview]
Message-ID: <5e40aa05-ccdf-0995-e1c4-a331d1da998a@redhat.com> (raw)
In-Reply-To: <a2fb541a-7a7d-1f78-b587-1191b9832088@users.sourceforge.net>



On 22/01/2017 19:09, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 22 Jan 2017 19:06:54 +0100
> 
> Several update suggestions were taken into account
> from static source code analysis.

Patches 1, 6 and 7 are acceptable.  The others are useless churn or they
make the result uselessly different from the rest of KVM code.

Paolo

> Markus Elfring (9):
>   Return directly after a failed copy_from_user() in kvm_vm_compat_ioctl()
>   Move error code settings in kvm_vm_ioctl()
>   Move error code settings in kvm_vcpu_compat_ioctl()
>   Move error code settings in kvm_vcpu_ioctl()
>   Improve size determinations in kvm_vcpu_ioctl()
>   Return an error code only as a constant in kvm_get_dirty_log_protect()
>   Return an error code only as a constant in kvm_get_dirty_log()
>   Adjust seven checks for null pointers
>   Improve another size determination in kvm_create_vm()
> 
>  virt/kvm/kvm_main.c | 278 +++++++++++++++++++++++-----------------------------
>  1 file changed, 120 insertions(+), 158 deletions(-)
> 

  parent reply	other threads:[~2017-01-23  9:22 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22 18:09 [PATCH 0/9] KVM: Fine-tuning for several function implementations SF Markus Elfring
2017-01-22 18:09 ` SF Markus Elfring
2017-01-22 18:11 ` [PATCH 1/9] KVM: Return directly after a failed copy_from_user() in kvm_vm_compat_ioctl() SF Markus Elfring
2017-01-22 18:11   ` SF Markus Elfring
2017-01-22 18:12 ` [PATCH 2/9] KVM: Move error code settings in kvm_vm_ioctl() SF Markus Elfring
2017-01-22 18:12   ` SF Markus Elfring
2017-01-22 18:13 ` [PATCH 3/9] KVM: Move error code settings in kvm_vcpu_compat_ioctl() SF Markus Elfring
2017-01-22 18:13   ` SF Markus Elfring
2017-01-22 18:14 ` [PATCH 4/9] KVM: Move error code settings in kvm_vcpu_ioctl() SF Markus Elfring
2017-01-22 18:14   ` SF Markus Elfring
2017-01-22 18:15 ` [PATCH 5/9] KVM: Improve size determinations " SF Markus Elfring
2017-01-22 18:15   ` SF Markus Elfring
2017-01-22 18:16 ` [PATCH 6/9] KVM: Return an error code only as a constant in kvm_get_dirty_log_protect() SF Markus Elfring
2017-01-22 18:16   ` SF Markus Elfring
2017-01-22 18:17 ` [PATCH 7/9] KVM: Return an error code only as a constant in kvm_get_dirty_log() SF Markus Elfring
2017-01-22 18:17   ` SF Markus Elfring
2017-01-22 18:18 ` [PATCH 8/9] KVM: Adjust seven checks for null pointers SF Markus Elfring
2017-01-22 18:18   ` SF Markus Elfring
2017-01-22 20:32   ` kbuild test robot
2017-01-22 20:32     ` kbuild test robot
2017-01-22 21:35   ` kbuild test robot
2017-01-22 21:35     ` kbuild test robot
2017-01-23  9:30   ` Dan Carpenter
2017-01-23  9:30     ` Dan Carpenter
2017-01-22 18:19 ` [PATCH 9/9] KVM: Improve another size determination in kvm_create_vm() SF Markus Elfring
2017-01-22 18:19   ` SF Markus Elfring
2017-01-23  9:22 ` Paolo Bonzini [this message]
2017-01-23  9:22   ` [PATCH 0/9] KVM: Fine-tuning for several function implementations Paolo Bonzini
2017-01-23  9:48   ` SF Markus Elfring
2017-01-23  9:48     ` SF Markus Elfring
2017-01-23 14:06     ` Paolo Bonzini
2017-01-23 14:06       ` Paolo Bonzini
2017-01-24  2:15     ` Bernd Petrovitsch
2017-01-24  2:15       ` Bernd Petrovitsch
2017-01-24 11:36       ` SF Markus Elfring
2017-01-24 11:36         ` SF Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e40aa05-ccdf-0995-e1c4-a331d1da998a@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.