All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Andrew Murray <amurray@embedded-bits.co.uk>
Cc: Tero Kristo <t-kristo@ti.com>, Paul Walmsley <paul@pwsan.com>,
	linux-omap@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH] ARM: OMAP1/2: clock: Remove unused mpurate cmdline option
Date: Mon, 23 Jan 2017 12:34:04 -0800	[thread overview]
Message-ID: <20170123203403.GW7403@atomide.com> (raw)
In-Reply-To: <CAPcvp5FQ90KroisJE1Hp4yx8Hz07ev_YyNgxEGtgAEUYDd1nsw@mail.gmail.com>

* Andrew Murray <amurray@embedded-bits.co.uk> [170123 11:52]:
> On 23 January 2017 at 15:10, Tony Lindgren <tony@atomide.com> wrote:
> > * Andrew Murray <amurray@embedded-bits.co.uk> [170121 09:38]:
> >> The 'mpurate' option, historically used for specifying an initial
> >> MPU rate at boot, no longer has any effect due to the supporting
> >> code being removed as it was 'wrong and dangerous' [1].
> >>
> >> This patch removes the remaining dead code associated with the
> >> __setup macros to avoid confusion and reduce bloat.
> >>
> >> [1] https://patchwork.kernel.org/patch/5954631/
> >
> > Yeah AFAIK this is unused for mach-omap2. Adding Aaro to
> > Cc for mach-omap1 in case there might be issues with this
> > patch.
> 
> I've also noticed that omap2_clk_print_new_rates in
> arch/arm/mach-omap2/clock.c is also unused - this was previously used
> to print the new clock rates upon change after use of mpurate.
> 
> I'll update the patch to include the removal of this function as well
> - unless you have any objections.

Sure.

Thanks,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP1/2: clock: Remove unused mpurate cmdline option
Date: Mon, 23 Jan 2017 12:34:04 -0800	[thread overview]
Message-ID: <20170123203403.GW7403@atomide.com> (raw)
In-Reply-To: <CAPcvp5FQ90KroisJE1Hp4yx8Hz07ev_YyNgxEGtgAEUYDd1nsw@mail.gmail.com>

* Andrew Murray <amurray@embedded-bits.co.uk> [170123 11:52]:
> On 23 January 2017 at 15:10, Tony Lindgren <tony@atomide.com> wrote:
> > * Andrew Murray <amurray@embedded-bits.co.uk> [170121 09:38]:
> >> The 'mpurate' option, historically used for specifying an initial
> >> MPU rate at boot, no longer has any effect due to the supporting
> >> code being removed as it was 'wrong and dangerous' [1].
> >>
> >> This patch removes the remaining dead code associated with the
> >> __setup macros to avoid confusion and reduce bloat.
> >>
> >> [1] https://patchwork.kernel.org/patch/5954631/
> >
> > Yeah AFAIK this is unused for mach-omap2. Adding Aaro to
> > Cc for mach-omap1 in case there might be issues with this
> > patch.
> 
> I've also noticed that omap2_clk_print_new_rates in
> arch/arm/mach-omap2/clock.c is also unused - this was previously used
> to print the new clock rates upon change after use of mpurate.
> 
> I'll update the patch to include the removal of this function as well
> - unless you have any objections.

Sure.

Thanks,

Tony

  reply	other threads:[~2017-01-23 20:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 17:36 [PATCH] ARM: OMAP1/2: clock: Remove unused mpurate cmdline option Andrew Murray
2017-01-21 17:36 ` Andrew Murray
2017-01-23 15:10 ` Tony Lindgren
2017-01-23 15:10   ` Tony Lindgren
2017-01-23 19:51   ` Andrew Murray
2017-01-23 19:51     ` Andrew Murray
2017-01-23 20:34     ` Tony Lindgren [this message]
2017-01-23 20:34       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123203403.GW7403@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=amurray@embedded-bits.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=paul@pwsan.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.