* [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()
@ 2017-01-26 9:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-01-26 9:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, Serge Semin; +Cc: linux-kernel, kernel-janitors
"pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
kfree() is a double free. In fact, we don't need to free it at all.
Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 25d47d09e1cb..f5f2c5a8d9b0 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
pdev->ee_file->size = pdev->eesize;
ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
if (ret != 0) {
- kfree(pdev->ee_file);
dev_err(dev, "Failed to create EEPROM sysfs-node");
return ret;
}
@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
/* Remove EEPROM sysfs file */
sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
- /* Free memory allocated for bin_attribute structure */
- kfree(pdev->ee_file);
}
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread* [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()
@ 2017-01-26 9:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-01-26 9:01 UTC (permalink / raw)
To: Greg Kroah-Hartman, Serge Semin; +Cc: linux-kernel, kernel-janitors
"pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
kfree() is a double free. In fact, we don't need to free it at all.
Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 25d47d09e1cb..f5f2c5a8d9b0 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
pdev->ee_file->size = pdev->eesize;
ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
if (ret != 0) {
- kfree(pdev->ee_file);
dev_err(dev, "Failed to create EEPROM sysfs-node");
return ret;
}
@@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
/* Remove EEPROM sysfs file */
sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
-
- /* Free memory allocated for bin_attribute structure */
- kfree(pdev->ee_file);
}
/*
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()
2017-01-26 9:01 ` Dan Carpenter
@ 2017-01-26 12:44 ` Serge Semin
-1 siblings, 0 replies; 4+ messages in thread
From: Serge Semin @ 2017-01-26 12:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg Kroah-Hartman, linux-kernel, kernel-janitors
On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
> kfree() is a double free. In fact, we don't need to free it at all.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d09e1cb..f5f2c5a8d9b0 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
> pdev->ee_file->size = pdev->eesize;
> ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
> if (ret != 0) {
> - kfree(pdev->ee_file);
> dev_err(dev, "Failed to create EEPROM sysfs-node");
> return ret;
> }
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>
> /* Remove EEPROM sysfs file */
> sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> - /* Free memory allocated for bin_attribute structure */
> - kfree(pdev->ee_file);
> }
>
> /*
Just got the same patch a day earlier, but still thanks for the pointing the issue out.
Regards,
-Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree()
@ 2017-01-26 12:44 ` Serge Semin
0 siblings, 0 replies; 4+ messages in thread
From: Serge Semin @ 2017-01-26 12:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Greg Kroah-Hartman, linux-kernel, kernel-janitors
On Thu, Jan 26, 2017 at 12:01:46PM +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> "pdev->ee_file" was allocated with devm_kmalloc() so freeing it with
> kfree() is a double free. In fact, we don't need to free it at all.
>
> Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
> index 25d47d09e1cb..f5f2c5a8d9b0 100644
> --- a/drivers/misc/eeprom/idt_89hpesx.c
> +++ b/drivers/misc/eeprom/idt_89hpesx.c
> @@ -1359,7 +1359,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev)
> pdev->ee_file->size = pdev->eesize;
> ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);
> if (ret != 0) {
> - kfree(pdev->ee_file);
> dev_err(dev, "Failed to create EEPROM sysfs-node");
> return ret;
> }
> @@ -1381,9 +1380,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev)
>
> /* Remove EEPROM sysfs file */
> sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);
> -
> - /* Free memory allocated for bin_attribute structure */
> - kfree(pdev->ee_file);
> }
>
> /*
Just got the same patch a day earlier, but still thanks for the pointing the issue out.
Regards,
-Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-26 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-26 9:01 [patch] eeprom/idt_89hpesx: freeing devm_ pointer with kfree() Dan Carpenter
2017-01-26 9:01 ` Dan Carpenter
2017-01-26 12:44 ` Serge Semin
2017-01-26 12:44 ` Serge Semin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.