* [PATCH] wlcore: disable multicast filter in AP mode
@ 2017-01-31 10:48 Iain Hunter
2017-01-31 12:44 ` [PATCH v3] " Iain Hunter
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Iain Hunter @ 2017-01-31 10:48 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
Enable AP support for allmulticast for MDNS It can be enabled by bringing
up the interface with ip command with argument allmulticast on
Signed-off-by: Iain Hunter <i-hunter1@ti.com>
---
PATCH v2: resumbitting to handle error return value
drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..4fabbb486e7 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3] wlcore: disable multicast filter in AP mode
2017-01-31 10:48 [PATCH] wlcore: disable multicast filter in AP mode Iain Hunter
@ 2017-01-31 12:44 ` Iain Hunter
2017-02-02 6:23 ` Kalle Valo
2017-02-08 14:09 ` [PATCH v4] " Iain Hunter
2017-02-09 14:37 ` [PATCH v5] " Iain Hunter
2 siblings, 1 reply; 10+ messages in thread
From: Iain Hunter @ 2017-01-31 12:44 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
Enable AP support for allmulticast for MDNS. It can be enabled by bringing
up the interface with ip command with argument allmulticast on
Signed-off-by:Iain Hunter <i-hunter1@ti.com>
---
PATCH v3: fixes tabbing
drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..7d3f15d5d5c 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v3] wlcore: disable multicast filter in AP mode
2017-01-31 12:44 ` [PATCH v3] " Iain Hunter
@ 2017-02-02 6:23 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2017-02-02 6:23 UTC (permalink / raw)
To: Iain Hunter; +Cc: linux-wireless, Iain Hunter
Iain Hunter <drhunter95@gmail.com> writes:
> Enable AP support for allmulticast for MDNS. It can be enabled by bringing
> up the interface with ip command with argument allmulticast on
>
> Signed-off-by:Iain Hunter <i-hunter1@ti.com>
There should be a space after ':' and before your name.
> --- a/drivers/net/wireless/ti/wlcore/main.c
> +++ b/drivers/net/wireless/ti/wlcore/main.c
> @@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
> if (ret < 0)
> goto out_sleep;
> }
> +
> + /*
> + * If interface in AP mode and created with allmulticast then disable
> + * the firmware filters so that all multicast packets are passed
> + * This is mandatory for MDNS based discovery protocols
> + */
> + if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
The comment looks wrongly indented.
> + if (*total & FIF_ALLMULTI) {
> + ret = wl1271_acx_group_address_tbl(wl, wlvif,
> + false,
> + NULL, 0);
> + if (ret < 0)
> + goto out_sleep;
> + }
Also the closing bracket here is not indented correctly.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4] wlcore: disable multicast filter in AP mode
2017-01-31 10:48 [PATCH] wlcore: disable multicast filter in AP mode Iain Hunter
2017-01-31 12:44 ` [PATCH v3] " Iain Hunter
@ 2017-02-08 14:09 ` Iain Hunter
2017-02-09 14:37 ` [PATCH v5] " Iain Hunter
2 siblings, 0 replies; 10+ messages in thread
From: Iain Hunter @ 2017-02-08 14:09 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
Enable AP support for allmulticast for MDNS. It can be enabled by bringing
up the interface with ip command with argument allmulticast on
---
PATCH v4: fixes space in signed-off, tabbing for comment and indentation of closing bracket
drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..242111cd016 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v5] wlcore: disable multicast filter in AP mode
2017-01-31 10:48 [PATCH] wlcore: disable multicast filter in AP mode Iain Hunter
2017-01-31 12:44 ` [PATCH v3] " Iain Hunter
2017-02-08 14:09 ` [PATCH v4] " Iain Hunter
@ 2017-02-09 14:37 ` Iain Hunter
2017-02-15 9:12 ` [v5] " Kalle Valo
2 siblings, 1 reply; 10+ messages in thread
From: Iain Hunter @ 2017-02-09 14:37 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
Enable AP support for allmulticast for MDNS. It can be enabled by bringing
up the interface with ip command with argument allmulticast on
Signed-off-by: Iain Hunter <i-hunter1@ti.com>
---
PATCH v5: fixes indentation of other closing bracket and missing Signed Off
drivers/net/wireless/ti/wlcore/main.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..242111cd016 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [v5] wlcore: disable multicast filter in AP mode
2017-02-09 14:37 ` [PATCH v5] " Iain Hunter
@ 2017-02-15 9:12 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2017-02-15 9:12 UTC (permalink / raw)
To: Iain Hunter; +Cc: linux-wireless, kvalo, Iain Hunter
Iain Hunter <drhunter95@gmail.com> wrote:
> Enable AP support for allmulticast for MDNS. It can be enabled by bringing
> up the interface with ip command with argument allmulticast on
>
> Signed-off-by: Iain Hunter <i-hunter1@ti.com>
Patch applied to wireless-drivers-next.git, thanks.
1f8665320fa1 wlcore: disable multicast filter in AP mode
--
https://patchwork.kernel.org/patch/9564711/
Documentation about submitting wireless patches and checking status
from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] wlcore: disable multicast filter in AP mode
@ 2017-01-31 11:31 Iain Hunter
0 siblings, 0 replies; 10+ messages in thread
From: Iain Hunter @ 2017-01-31 11:31 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..7d3f15d5d5c 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] wlcore: disable multicast filter in AP mode
@ 2017-01-31 11:26 Iain Hunter
0 siblings, 0 replies; 10+ messages in thread
From: Iain Hunter @ 2017-01-31 11:26 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..7d3f15d5d5c 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,21 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI) {
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+ if (ret < 0)
+ goto out_sleep;
+ }
+ }
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] wlcore: disable multicast filter in AP mode
2017-01-30 14:49 Iain Hunter
@ 2017-01-31 7:22 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2017-01-31 7:22 UTC (permalink / raw)
To: Iain Hunter; +Cc: linux-wireless, Iain Hunter
Iain Hunter <drhunter95@gmail.com> writes:
> Enable AP support allmulticast for MDNS. It can be enabled by bringing up
>
> the interface with ip command with the argument allmulticast on
>
> Signed-off-by: Iain Hunter <i-hunter1@ti.com>
The commit log looks now ok, except there's an unnecessare empty line.
But I can fix that.
> @@ -3281,6 +3281,20 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
> if (ret < 0)
> goto out_sleep;
> }
> +
> + /*
> + * If interface in AP mode and created with allmulticast then disable
> + * the firmware filters so that all multicast packets are passed
> + * This is mandatory for MDNS based discovery protocols
> + */
> + if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
> + if (*total & FIF_ALLMULTI)
> + ret = wl1271_acx_group_address_tbl(wl, wlvif,
> + false,
> + NULL, 0);
> +
> + }
> +
> }
Sorry, I missed this earlier but here you don't check ret value at all.
I think you should bail out from the look if an error happens, like
other commands in the same loop does.
--
Kalle Valo
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] wlcore: disable multicast filter in AP mode
@ 2017-01-30 14:49 Iain Hunter
2017-01-31 7:22 ` Kalle Valo
0 siblings, 1 reply; 10+ messages in thread
From: Iain Hunter @ 2017-01-30 14:49 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo, Iain Hunter
Enable AP support allmulticast for MDNS. It can be enabled by bringing up
the interface with ip command with the argument allmulticast on
Signed-off-by: Iain Hunter <i-hunter1@ti.com>
---
drivers/net/wireless/ti/wlcore/main.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 3241e9eba73..1ab0561ab13 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -3281,6 +3281,20 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
if (ret < 0)
goto out_sleep;
}
+
+ /*
+ * If interface in AP mode and created with allmulticast then disable
+ * the firmware filters so that all multicast packets are passed
+ * This is mandatory for MDNS based discovery protocols
+ */
+ if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
+ if (*total & FIF_ALLMULTI)
+ ret = wl1271_acx_group_address_tbl(wl, wlvif,
+ false,
+ NULL, 0);
+
+ }
+
}
/*
--
2.11.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-02-15 9:12 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 10:48 [PATCH] wlcore: disable multicast filter in AP mode Iain Hunter
2017-01-31 12:44 ` [PATCH v3] " Iain Hunter
2017-02-02 6:23 ` Kalle Valo
2017-02-08 14:09 ` [PATCH v4] " Iain Hunter
2017-02-09 14:37 ` [PATCH v5] " Iain Hunter
2017-02-15 9:12 ` [v5] " Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-01-31 11:31 [PATCH] " Iain Hunter
2017-01-31 11:26 Iain Hunter
2017-01-30 14:49 Iain Hunter
2017-01-31 7:22 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.