All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org, andrew@lunn.ch,
	anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com,
	felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
	jlayton@poochiereds.net, jirislaby@gmail.com,
	kvalo@codeaurora.org, mcgrof@do-not-panic.com,
	madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com,
	nab@linux-iscsi.org, mickflemm@gmail.com,
	nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com,
	ralf@linux-mips.org, satananda.burla@caviumnetworks.com,
	thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
	trond.myklebust@primarydata.com,
	vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Wed, 08 Feb 2017 11:06:26 -0500 (EST)	[thread overview]
Message-ID: <20170208.110626.346978547122180233.davem@davemloft.net> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

RnJvbTogRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+DQpEYXRlOiBUdWUs
ICA3IEZlYiAyMDE3IDE1OjAyOjUzIC0wODAwDQoNCj4gSSdtIGhvcGluZyB0aGlzIGRvZXNuJ3Qg
Y29uZmxpY3Qgd2l0aCB3aGF0J3MgYWxyZWFkeSBpbiBuZXQtbmV4dC4uLg0KPiANCj4gRGF2aWQs
IHRoaXMgc2hvdWxkIHByb2JhYmx5IGdvIHZpYSB5b3VyIHRyZWUgY29uc2lkZXJpbmcgdGhlIGRp
ZmZzdGF0Lg0KDQpJIHRoaW5rIHlvdSBuZWVkIG9uZSBtb3JlIHJlc3Bpbi4gIEFyZSB5b3UgZG9p
bmcgYW4gYWxsbW9kY29uZmlnIGJ1aWxkPw0KSWYgbm90LCBmb3Igc29tZXRoaW5nIGxpa2UgdGhp
cyBpdCdzIGEgbXVzdDoNCg0KZHJpdmVycy9uZXQvd2lyZWxlc3MvYXRoL3dpbDYyMTAvY2ZnODAy
MTEuYzoyNDozMDogZXJyb3I6IGV4cGVjdGVkIKEpoiBiZWZvcmUgoWJvb2yiDQogbW9kdWxlX3Bh
cmFtKGRpc2FibGVfYXBfc21lLCBib29sLCAwNDQ0KTsNCiAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIF4NCmRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC93aWw2MjEwL2NmZzgwMjExLmM6MjU6
MzQ6IGVycm9yOiBleHBlY3RlZCChKaIgYmVmb3JlIHN0cmluZyBjb25zdGFudA0KIE1PRFVMRV9Q
QVJNX0RFU0MoZGlzYWJsZV9hcF9zbWUsICIgbGV0IHVzZXIgc3BhY2UgaGFuZGxlIEFQIG1vZGUg
U01FIik7DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXg0KTGlrZSBsaWtlIHRo
YXQgZmlsZSBuZWVkcyBsaW51eC9tb2R1bGUuaCBpbmNsdWRlZC4NCg0KVGhhbmtzLg0K

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org, andrew@lunn.ch,
	anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com,
	felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
	jlayton@poochiereds.net, jirislaby@gmail.com,
	kvalo@codeaurora.org, mcgrof@do-not-panic.com,
	madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com,
	nab@linux-iscsi.org, mickflemm@gmail.com,
	nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com,
	ralf@linux-mips.org, satananda.burla@caviumnetworks.com,
	thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
	trond.myklebust@primarydata.com,
	vivien.didelot@savoirfairelinux.com, woojung.huh@microch
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Wed, 08 Feb 2017 11:06:26 -0500 (EST)	[thread overview]
Message-ID: <20170208.110626.346978547122180233.davem@davemloft.net> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue,  7 Feb 2017 15:02:53 -0800

> I'm hoping this doesn't conflict with what's already in net-next...
> 
> David, this should probably go via your tree considering the diffstat.

I think you need one more respin.  Are you doing an allmodconfig build?
If not, for something like this it's a must:

drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
 module_param(disable_ap_sme, bool, 0444);
                              ^
drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
 MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
                                  ^
Like like that file needs linux/module.h included.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-mips@linux-mips.org,
	linux-nfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
	target-devel@vger.kernel.org, andrew@lunn.ch,
	anna.schumaker@netapp.com, derek.chickles@caviumnetworks.com,
	felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
	jlayton@poochiereds.net, jirislaby@gmail.com,
	kvalo@codeaurora.org, mcgrof@do-not-panic.com,
	madalin.bucur@nxp.com, UNGLinuxDriver@microchip.com,
	nab@linux-iscsi.org, mickflemm@gmail.com,
	nicolas.ferre@atmel.com, raghu.vatsavayi@caviumnetworks.com,
	ralf@linux-mips.org, satananda.burla@caviumnetworks.com,
	thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
	trond.myklebust@primarydata.com,
	vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Wed, 08 Feb 2017 11:06:26 -0500 (EST)	[thread overview]
Message-ID: <20170208.110626.346978547122180233.davem@davemloft.net> (raw)
In-Reply-To: <20170207230305.18222-1-f.fainelli@gmail.com>

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue,  7 Feb 2017 15:02:53 -0800

> I'm hoping this doesn't conflict with what's already in net-next...
> 
> David, this should probably go via your tree considering the diffstat.

I think you need one more respin.  Are you doing an allmodconfig build?
If not, for something like this it's a must:

drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
 module_param(disable_ap_sme, bool, 0444);
                              ^
drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
 MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
                                  ^
Like like that file needs linux/module.h included.

Thanks.

  parent reply	other threads:[~2017-02-08 16:16 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-07 23:02 [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 02/12] net: cgroups: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 03/12] net: macb: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 04/12] net: lan78xx: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 05/12] net: bgmac: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 06/12] net: fman: " Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:02   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 07/12] net: mvneta: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 08/12] iscsi: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-08  4:53   ` Nicholas A. Bellinger
2017-02-08  4:53     ` Nicholas A. Bellinger
2017-02-07 23:03 ` [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*() Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 11/12] net: ath5k: " Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-07 23:03   ` Florian Fainelli
2017-02-08 16:06 ` David Miller [this message]
2017-02-08 16:06   ` [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include David Miller
2017-02-08 16:06   ` David Miller
2017-02-08 16:11   ` Kalle Valo
2017-02-08 16:11     ` Kalle Valo
2017-02-08 16:11     ` Kalle Valo
2017-02-08 19:45     ` Florian Fainelli
2017-02-09 14:10       ` Kalle Valo
2017-02-09 14:10         ` Kalle Valo
2017-02-09 14:10         ` Kalle Valo
2017-02-10 18:51         ` David Miller
2017-02-10 18:51           ` David Miller
2017-02-10 18:51           ` David Miller
2017-02-10 19:44           ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208.110626.346978547122180233.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=derek.chickles@caviumnetworks.com \
    --cc=f.fainelli@gmail.com \
    --cc=felix.manlunas@caviumnetworks.com \
    --cc=jirislaby@gmail.com \
    --cc=jlayton@poochiereds.net \
    --cc=kvalo@codeaurora.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=madalin.bucur@nxp.com \
    --cc=mcgrof@do-not-panic.com \
    --cc=mickflemm@gmail.com \
    --cc=nab@linux-iscsi.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=raghu.vatsavayi@caviumnetworks.com \
    --cc=ralf@linux-mips.org \
    --cc=satananda.burla@caviumnetworks.com \
    --cc=target-devel@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=timur@codeaurora.org \
    --cc=trond.myklebust@primarydata.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.