From: David Miller <davem@davemloft.net>
To: kvalo@codeaurora.org
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-mips@linux-mips.org, linux-nfs@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, target-devel@vger.kernel.org,
andrew@lunn.ch, anna.schumaker@netapp.com,
derek.chickles@caviumnetworks.com,
felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
jlayton@poochiereds.net, jirislaby@gmail.com,
mcgrof@do-not-panic.com, madalin.bucur@nxp.com,
UNGLinuxDriver@microchip.com, nab@linux-iscsi.org,
mickflemm@gmail.com, nicolas.ferre@atmel.com,
raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org,
satananda.burla@caviumnetworks.com,
thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
trond.myklebust@primarydata.com,
vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Fri, 10 Feb 2017 13:51:38 -0500 (EST) [thread overview]
Message-ID: <20170210.135138.2084086346069765205.davem@davemloft.net> (raw)
In-Reply-To: <877f4zjw01.fsf@kamboji.qca.qualcomm.com>
RnJvbTogS2FsbGUgVmFsbyA8a3ZhbG9AY29kZWF1cm9yYS5vcmc+DQpEYXRlOiBUaHUsIDA5IEZl
YiAyMDE3IDE2OjEwOjA2ICswMjAwDQoNCj4gRmxvcmlhbiBGYWluZWxsaSA8Zi5mYWluZWxsaUBn
bWFpbC5jb20+IHdyaXRlczoNCj4gDQo+Pj4+IElmIG5vdCwgZm9yIHNvbWV0aGluZyBsaWtlIHRo
aXMgaXQncyBhIG11c3Q6DQo+Pj4+DQo+Pj4+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2F0aC93aWw2
MjEwL2NmZzgwMjExLmM6MjQ6MzA6IGVycm9yOiBleHBlY3RlZCChKaIgYmVmb3JlIKFib29sog0K
Pj4+PiAgbW9kdWxlX3BhcmFtKGRpc2FibGVfYXBfc21lLCBib29sLCAwNDQ0KTsNCj4+Pj4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgXg0KPj4+PiBkcml2ZXJzL25ldC93aXJlbGVzcy9h
dGgvd2lsNjIxMC9jZmc4MDIxMS5jOjI1OjM0OiBlcnJvcjogZXhwZWN0ZWQgoSmiIGJlZm9yZSBz
dHJpbmcgY29uc3RhbnQNCj4+Pj4gIE1PRFVMRV9QQVJNX0RFU0MoZGlzYWJsZV9hcF9zbWUsICIg
bGV0IHVzZXIgc3BhY2UgaGFuZGxlIEFQIG1vZGUgU01FIik7DQo+Pj4+ICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICBeDQo+Pj4+IExpa2UgbGlrZSB0aGF0IGZpbGUgbmVlZHMgbGlu
dXgvbW9kdWxlLmggaW5jbHVkZWQuDQo+Pj4gDQo+Pj4gSm9oYW5uZXMgYWxyZWFkeSBmaXhlZCBh
IHNpbWlsYXIgKG9yIHNhbWUpIHByb2JsZW0gaW4gbXkgdHJlZToNCj4+PiANCj4+PiB3aWw2MjEw
OiBpbmNsdWRlIG1vZHVsZXBhcmFtLmgNCj4+PiANCj4+PiBodHRwczovL2dpdC5rZXJuZWwub3Jn
L2NnaXQvbGludXgva2VybmVsL2dpdC9rdmFsby93aXJlbGVzcy1kcml2ZXJzLW5leHQuZ2l0L2Nv
bW1pdC8/aWQ9OTQ5YzJkMDA5Njc1M2Q1MThlZjZlMGJkODQxOGM4MDg2NzQ3MTk2Yg0KPj4+IA0K
Pj4+IEknbSBwbGFubmluZyB0byBzZW5kIHlvdSBhIHB1bGwgcmVxdWVzdCB0b21vcnJvdyB3aGlj
aCBjb250YWlucyB0aGF0DQo+Pj4gb25lLg0KPj4NCj4+IFRoYW5rcyBLYWxsZSENCj4+DQo+PiBE
YXZpZCwgY2FuIHlvdSBob2xkIG9uIHRoaXMgc2VyaWVzIHVudGlsIEthbGxlJ3MgcHVsbCByZXF1
ZXN0IGdldHMNCj4+IHN1Ym1pdHRlZD8gUGFzdCB0aGlzIGVycm9yLCBhbGxtb2Rjb25maWcgYnVp
bGRzIGZpbmUgd2l0aCB0aGlzIHBhdGNoDQo+PiBzZXJpZXMgKGp1c3QgdGVzdGVkKS4gVGhhbmtz
IQ0KPiANCj4gSnVzdCBzdWJtaXR0ZWQgdGhlIHB1bGwgcmVxdWVzdDoNCj4gDQo+IGh0dHBzOi8v
cGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNzI2MTMzLw0KDQpJJ3ZlIHJldHJpZWQgdGhpcyBw
YXRjaCBzZXJpZXMsIGFuZCB3aWxsIHB1c2ggaXQgb3V0IGFzc3VtaW5nIHRoZSBidWlsZA0KY29t
cGxldGVzIHByb3Blcmx5Lg0K
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: kvalo@codeaurora.org
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-mips@linux-mips.org, linux-nfs@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, target-devel@vger.kernel.org,
andrew@lunn.ch, anna.schumaker@netapp.com,
derek.chickles@caviumnetworks.com,
felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
jlayton@poochiereds.net, jirislaby@gmail.com,
mcgrof@do-not-panic.com, madalin.bucur@nxp.com,
UNGLinuxDriver@microchip.com, nab@linux-iscsi.org,
mickflemm@gmail.com, nicolas.ferre@atmel.com,
raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org,
satananda.burla@caviumnetworks.com,
thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
trond.myklebust@primarydata.com,
vivien.didelot@savoirfairelinux.com, woojung.huh
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Fri, 10 Feb 2017 13:51:38 -0500 (EST) [thread overview]
Message-ID: <20170210.135138.2084086346069765205.davem@davemloft.net> (raw)
In-Reply-To: <877f4zjw01.fsf@kamboji.qca.qualcomm.com>
From: Kalle Valo <kvalo@codeaurora.org>
Date: Thu, 09 Feb 2017 16:10:06 +0200
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
>>>> If not, for something like this it's a must:
>>>>
>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
>>>> module_param(disable_ap_sme, bool, 0444);
>>>> ^
>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
>>>> MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
>>>> ^
>>>> Like like that file needs linux/module.h included.
>>>
>>> Johannes already fixed a similar (or same) problem in my tree:
>>>
>>> wil6210: include moduleparam.h
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b
>>>
>>> I'm planning to send you a pull request tomorrow which contains that
>>> one.
>>
>> Thanks Kalle!
>>
>> David, can you hold on this series until Kalle's pull request gets
>> submitted? Past this error, allmodconfig builds fine with this patch
>> series (just tested). Thanks!
>
> Just submitted the pull request:
>
> https://patchwork.ozlabs.org/patch/726133/
I've retried this patch series, and will push it out assuming the build
completes properly.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: kvalo@codeaurora.org
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-mips@linux-mips.org, linux-nfs@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, target-devel@vger.kernel.org,
andrew@lunn.ch, anna.schumaker@netapp.com,
derek.chickles@caviumnetworks.com,
felix.manlunas@caviumnetworks.com, bfields@fieldses.org,
jlayton@poochiereds.net, jirislaby@gmail.com,
mcgrof@do-not-panic.com, madalin.bucur@nxp.com,
UNGLinuxDriver@microchip.com, nab@linux-iscsi.org,
mickflemm@gmail.com, nicolas.ferre@atmel.com,
raghu.vatsavayi@caviumnetworks.com, ralf@linux-mips.org,
satananda.burla@caviumnetworks.com,
thomas.petazzoni@free-electrons.com, timur@codeaurora.org,
trond.myklebust@primarydata.com,
vivien.didelot@savoirfairelinux.com, woojung.huh@microchip.com
Subject: Re: [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include
Date: Fri, 10 Feb 2017 13:51:38 -0500 (EST) [thread overview]
Message-ID: <20170210.135138.2084086346069765205.davem@davemloft.net> (raw)
In-Reply-To: <877f4zjw01.fsf@kamboji.qca.qualcomm.com>
From: Kalle Valo <kvalo@codeaurora.org>
Date: Thu, 09 Feb 2017 16:10:06 +0200
> Florian Fainelli <f.fainelli@gmail.com> writes:
>
>>>> If not, for something like this it's a must:
>>>>
>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:24:30: error: expected ‘)’ before ‘bool’
>>>> module_param(disable_ap_sme, bool, 0444);
>>>> ^
>>>> drivers/net/wireless/ath/wil6210/cfg80211.c:25:34: error: expected ‘)’ before string constant
>>>> MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
>>>> ^
>>>> Like like that file needs linux/module.h included.
>>>
>>> Johannes already fixed a similar (or same) problem in my tree:
>>>
>>> wil6210: include moduleparam.h
>>>
>>> https://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=949c2d0096753d518ef6e0bd8418c8086747196b
>>>
>>> I'm planning to send you a pull request tomorrow which contains that
>>> one.
>>
>> Thanks Kalle!
>>
>> David, can you hold on this series until Kalle's pull request gets
>> submitted? Past this error, allmodconfig builds fine with this patch
>> series (just tested). Thanks!
>
> Just submitted the pull request:
>
> https://patchwork.ozlabs.org/patch/726133/
I've retried this patch series, and will push it out assuming the build
completes properly.
next prev parent reply other threads:[~2017-02-10 19:00 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 23:02 [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 02/12] net: cgroups: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 03/12] net: macb: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 04/12] net: lan78xx: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 05/12] net: bgmac: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` [PATCH net-next v2 06/12] net: fman: " Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:02 ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 07/12] net: mvneta: " Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 08/12] iscsi: " Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-08 4:53 ` Nicholas A. Bellinger
2017-02-08 4:53 ` Nicholas A. Bellinger
2017-02-07 23:03 ` [PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*() Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 11/12] net: ath5k: " Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` [PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-07 23:03 ` Florian Fainelli
2017-02-08 16:06 ` [PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include David Miller
2017-02-08 16:06 ` David Miller
2017-02-08 16:06 ` David Miller
2017-02-08 16:11 ` Kalle Valo
2017-02-08 16:11 ` Kalle Valo
2017-02-08 16:11 ` Kalle Valo
2017-02-08 19:45 ` Florian Fainelli
2017-02-09 14:10 ` Kalle Valo
2017-02-09 14:10 ` Kalle Valo
2017-02-09 14:10 ` Kalle Valo
2017-02-10 18:51 ` David Miller [this message]
2017-02-10 18:51 ` David Miller
2017-02-10 18:51 ` David Miller
2017-02-10 19:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210.135138.2084086346069765205.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=anna.schumaker@netapp.com \
--cc=bfields@fieldses.org \
--cc=derek.chickles@caviumnetworks.com \
--cc=f.fainelli@gmail.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=jirislaby@gmail.com \
--cc=jlayton@poochiereds.net \
--cc=kvalo@codeaurora.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madalin.bucur@nxp.com \
--cc=mcgrof@do-not-panic.com \
--cc=mickflemm@gmail.com \
--cc=nab@linux-iscsi.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=raghu.vatsavayi@caviumnetworks.com \
--cc=ralf@linux-mips.org \
--cc=satananda.burla@caviumnetworks.com \
--cc=target-devel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=timur@codeaurora.org \
--cc=trond.myklebust@primarydata.com \
--cc=vivien.didelot@savoirfairelinux.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.