All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: James Smart <jsmart2021@gmail.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
	linux-nvme@lists.infradead.org, sagi@grimberg.me,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E
Date: Wed, 8 Feb 2017 04:47:54 -0800	[thread overview]
Message-ID: <20170208124754.GA23225@infradead.org> (raw)
In-Reply-To: <52f4f81e-2353-4da2-7ce9-a7cd7796e1f7@gmail.com>

On Tue, Feb 07, 2017 at 06:32:30PM -0800, James Smart wrote:
> I realize I cut these in a silly way.  In the v1 patches, I had a big patch
> that I then cut into 6 parts, by file.  In the v2 patches, I tried to keep
> the patches as is, and address the comments in the respective patch the
> comment came from. Which resulted in 3/8 with an old reference, but patch
> 8/8 being the one that reverted this reverence. Sorry..  I'll recut and
> repost.

This whole split doesn't make sense - either the patches are logically
split, in which case they can be posted separately, or they belong
together in which case they should be sent together.  But the size
of them suggest to me they probably need to be broken down to logically
separate patches.

And can you please switch to using git-send-email to send the patches
straight from a git branch?  There are lot of patch formatting issues
with the lpfc patches, and that should fix most of them instantly.

WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E
Date: Wed, 8 Feb 2017 04:47:54 -0800	[thread overview]
Message-ID: <20170208124754.GA23225@infradead.org> (raw)
In-Reply-To: <52f4f81e-2353-4da2-7ce9-a7cd7796e1f7@gmail.com>

On Tue, Feb 07, 2017@06:32:30PM -0800, James Smart wrote:
> I realize I cut these in a silly way.  In the v1 patches, I had a big patch
> that I then cut into 6 parts, by file.  In the v2 patches, I tried to keep
> the patches as is, and address the comments in the respective patch the
> comment came from. Which resulted in 3/8 with an old reference, but patch
> 8/8 being the one that reverted this reverence. Sorry..  I'll recut and
> repost.

This whole split doesn't make sense - either the patches are logically
split, in which case they can be posted separately, or they belong
together in which case they should be sent together.  But the size
of them suggest to me they probably need to be broken down to logically
separate patches.

And can you please switch to using git-send-email to send the patches
straight from a git branch?  There are lot of patch formatting issues
with the lpfc patches, and that should fix most of them instantly.

  reply	other threads:[~2017-02-08 13:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 23:08 [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E James Smart
2017-02-06 23:08 ` James Smart
2017-02-07  9:03 ` Johannes Thumshirn
2017-02-07  9:03   ` Johannes Thumshirn
2017-02-08  2:32   ` James Smart
2017-02-08  2:32     ` James Smart
2017-02-08 12:47     ` Christoph Hellwig [this message]
2017-02-08 12:47       ` Christoph Hellwig
2017-02-08 19:13       ` James Smart
2017-02-08 19:13         ` James Smart
2017-02-09  6:45         ` Hannes Reinecke
2017-02-09  6:45           ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208124754.GA23225@infradead.org \
    --to=hch@infradead.org \
    --cc=jsmart2021@gmail.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.