All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Thumshirn <jthumshirn@suse.de>
To: James Smart <jsmart2021@gmail.com>,
	linux-nvme@lists.infradead.org, sagi@grimberg.me,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E
Date: Tue, 7 Feb 2017 10:03:12 +0100	[thread overview]
Message-ID: <5881e84b-c932-f812-7f41-a16152d12106@suse.de> (raw)
In-Reply-To: <58990208.nZVFaqC7RkseErlq%jsmart2021@gmail.com>

On 02/07/2017 12:08 AM, James Smart wrote:
> 
> NVME Initiator: Base modifications
> 
> This is part E of parts A..F.
> 
> Part E is limited to lpfc_sli.c. This is the location of most of changes
> for the following:
> - sli3 ring vs sli4 wq splits
> - io abort interfaces
> - actual queuing routines and use of dma and sgl pools
> - service routines to create/delete queues
> 
> This patch by itself will not result in a compilable driver. All parts
> A..F must be applied to create a compilable driver.
> 
> *********
> 
> Refer to Part A for a description of base modifications
> 
> Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
> Signed-off-by: James Smart <james.smart@broadcom.com>
> 
> ---
> Modifications in V2:
> Note: this was patch 6 in the V1 patches
>  Address review items:
>   Reverted lpfc_sli_hbq_count() spurious change. Thus more files than
>      just lpfc_sli.c

Yes but patch  03/18 'lpfc: NVME Initiator: Base modifications Part A'
still has calls to lpfc_sli_hbq_count(phba) (and in fact introduces this
change).

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

WARNING: multiple messages have this Message-ID (diff)
From: jthumshirn@suse.de (Johannes Thumshirn)
Subject: [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E
Date: Tue, 7 Feb 2017 10:03:12 +0100	[thread overview]
Message-ID: <5881e84b-c932-f812-7f41-a16152d12106@suse.de> (raw)
In-Reply-To: <58990208.nZVFaqC7RkseErlq%jsmart2021@gmail.com>

On 02/07/2017 12:08 AM, James Smart wrote:
> 
> NVME Initiator: Base modifications
> 
> This is part E of parts A..F.
> 
> Part E is limited to lpfc_sli.c. This is the location of most of changes
> for the following:
> - sli3 ring vs sli4 wq splits
> - io abort interfaces
> - actual queuing routines and use of dma and sgl pools
> - service routines to create/delete queues
> 
> This patch by itself will not result in a compilable driver. All parts
> A..F must be applied to create a compilable driver.
> 
> *********
> 
> Refer to Part A for a description of base modifications
> 
> Signed-off-by: Dick Kennedy <dick.kennedy at broadcom.com>
> Signed-off-by: James Smart <james.smart at broadcom.com>
> 
> ---
> Modifications in V2:
> Note: this was patch 6 in the V1 patches
>  Address review items:
>   Reverted lpfc_sli_hbq_count() spurious change. Thus more files than
>      just lpfc_sli.c

Yes but patch  03/18 'lpfc: NVME Initiator: Base modifications Part A'
still has calls to lpfc_sli_hbq_count(phba) (and in fact introduces this
change).

-- 
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

  reply	other threads:[~2017-02-07  9:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06 23:08 [PATCH v2 07/18] lpfc: NVME Initiator: Base modifications Part E James Smart
2017-02-06 23:08 ` James Smart
2017-02-07  9:03 ` Johannes Thumshirn [this message]
2017-02-07  9:03   ` Johannes Thumshirn
2017-02-08  2:32   ` James Smart
2017-02-08  2:32     ` James Smart
2017-02-08 12:47     ` Christoph Hellwig
2017-02-08 12:47       ` Christoph Hellwig
2017-02-08 19:13       ` James Smart
2017-02-08 19:13         ` James Smart
2017-02-09  6:45         ` Hannes Reinecke
2017-02-09  6:45           ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5881e84b-c932-f812-7f41-a16152d12106@suse.de \
    --to=jthumshirn@suse.de \
    --cc=jsmart2021@gmail.com \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.