All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, corbet@lwn.net,
	tim@cyberelk.net, bp@alien8.de, jejb@linux.vnet.ibm.com,
	martin.petersen@oracle.com, linux-doc@vger.kernel.org,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] cdrom: Make device operations read-only
Date: Mon, 13 Feb 2017 21:58:11 -0500 (EST)	[thread overview]
Message-ID: <20170213.215811.902501442022534048.davem@davemloft.net> (raw)
In-Reply-To: <20170214002526.GA124769@beast>

From: Kees Cook <keescook@chromium.org>
Date: Mon, 13 Feb 2017 16:25:26 -0800

> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 9cbd217bc0c9..ab9232e1e16f 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf)
>  	 CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_GENERIC_PACKET | \
>  	 CDC_MO_DRIVE | CDC_MRW | CDC_MRW_W | CDC_RAM)
>  
> -static struct cdrom_device_ops ide_cdrom_dops = {
> +static const struct cdrom_device_ops ide_cdrom_dops = {
>  	.open			= ide_cdrom_open_real,
>  	.release		= ide_cdrom_release_real,
>  	.drive_status		= ide_cdrom_drive_status,

Acked-by: David S. Miller <davem@davemloft.net>

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: keescook@chromium.org
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, corbet@lwn.net,
	tim@cyberelk.net, bp@alien8.de, jejb@linux.vnet.ibm.com,
	martin.petersen@oracle.com, linux-doc@vger.kernel.org,
	linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,
	kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH] cdrom: Make device operations read-only
Date: Mon, 13 Feb 2017 21:58:11 -0500 (EST)	[thread overview]
Message-ID: <20170213.215811.902501442022534048.davem@davemloft.net> (raw)
In-Reply-To: <20170214002526.GA124769@beast>

From: Kees Cook <keescook@chromium.org>
Date: Mon, 13 Feb 2017 16:25:26 -0800

> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 9cbd217bc0c9..ab9232e1e16f 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf)
>  	 CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_GENERIC_PACKET | \
>  	 CDC_MO_DRIVE | CDC_MRW | CDC_MRW_W | CDC_RAM)
>  
> -static struct cdrom_device_ops ide_cdrom_dops = {
> +static const struct cdrom_device_ops ide_cdrom_dops = {
>  	.open			= ide_cdrom_open_real,
>  	.release		= ide_cdrom_release_real,
>  	.drive_status		= ide_cdrom_drive_status,

Acked-by: David S. Miller <davem@davemloft.net>

  reply	other threads:[~2017-02-14  2:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14  0:25 [PATCH] cdrom: Make device operations read-only Kees Cook
2017-02-14  0:25 ` [kernel-hardening] " Kees Cook
2017-02-14  2:58 ` David Miller [this message]
2017-02-14  2:58   ` [kernel-hardening] " David Miller
2017-02-14 15:30 ` Jens Axboe
2017-02-14 15:30   ` [kernel-hardening] " Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170213.215811.902501442022534048.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=axboe@kernel.dk \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=tim@cyberelk.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.