From: Jens Axboe <axboe@kernel.dk>
To: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>, Tim Waugh <tim@cyberelk.net>,
Borislav Petkov <bp@alien8.de>,
"David S. Miller" <davem@davemloft.net>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-doc@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, kernel-hardening@lists.openwall.com
Subject: Re: [PATCH] cdrom: Make device operations read-only
Date: Tue, 14 Feb 2017 08:30:25 -0700 [thread overview]
Message-ID: <d82598ae-122b-4a80-4aec-e0f47e274e5b@kernel.dk> (raw)
In-Reply-To: <20170214002526.GA124769@beast>
On 02/13/2017 05:25 PM, Kees Cook wrote:
> Since function tables are a common target for attackers, it's best to keep
> them in read-only memory. As such, this makes the CDROM device ops tables
> const. This drops additionally n_minors, since it isn't used meaningfully,
> and sets the only user of cdrom_dummy_generic_packet explicitly so the
> variables can all be const.
Agree, it's a good change. Applied for 4.11.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>, Tim Waugh <tim@cyberelk.net>,
Borislav Petkov <bp@alien8.de>,
"David S. Miller" <davem@davemloft.net>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-doc@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi@vger.kernel.org, kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCH] cdrom: Make device operations read-only
Date: Tue, 14 Feb 2017 08:30:25 -0700 [thread overview]
Message-ID: <d82598ae-122b-4a80-4aec-e0f47e274e5b@kernel.dk> (raw)
In-Reply-To: <20170214002526.GA124769@beast>
On 02/13/2017 05:25 PM, Kees Cook wrote:
> Since function tables are a common target for attackers, it's best to keep
> them in read-only memory. As such, this makes the CDROM device ops tables
> const. This drops additionally n_minors, since it isn't used meaningfully,
> and sets the only user of cdrom_dummy_generic_packet explicitly so the
> variables can all be const.
Agree, it's a good change. Applied for 4.11.
--
Jens Axboe
next prev parent reply other threads:[~2017-02-14 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 0:25 [PATCH] cdrom: Make device operations read-only Kees Cook
2017-02-14 0:25 ` [kernel-hardening] " Kees Cook
2017-02-14 2:58 ` David Miller
2017-02-14 2:58 ` [kernel-hardening] " David Miller
2017-02-14 15:30 ` Jens Axboe [this message]
2017-02-14 15:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d82598ae-122b-4a80-4aec-e0f47e274e5b@kernel.dk \
--to=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=jejb@linux.vnet.ibm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tim@cyberelk.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.