From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> To: Russell King - ARM Linux <linux@armlinux.org.uk> Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Kumar Gala <galak@codeaurora.org>, Andrew Lunn <andrew@lunn.ch>, Yehuda Yitschak <yehuday@marvell.com>, Jason Cooper <jason@lakedaemon.net>, Hanna Hawa <hannah@marvell.com>, Nadav Haklai <nadavh@marvell.com>, Gregory Clement <gregory.clement@free-electrons.com>, Stefan Chulski <stefanc@marvell.com>, Marcin Wojtas <mw@semihalf.com>, linux-arm-kernel@lists.infradead.org, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Subject: Re: [PATCHv2 net-next 11/16] net: mvpp2: handle misc PPv2.1/PPv2.2 differences Date: Tue, 14 Feb 2017 15:53:13 +0100 [thread overview] Message-ID: <20170214155313.1e9a497b@free-electrons.com> (raw) In-Reply-To: <20170107093834.GJ14217@n2100.armlinux.org.uk> Hello, On Sat, 7 Jan 2017 09:38:34 +0000, Russell King - ARM Linux wrote: > This has the side effect that nothing clears the port reset bit in the > GMAC, which means there's no hope of the interface working - with the > reset bit set, the port is well and truely held in "link down" state. Things were working fine here on Armada 7K/8K even without calling mvpp21_port_power_up(port). But I've looked into more details, and in fact the whole function makes sense on PPv2.2, except the mvpp2_port_fc_adv_enable(port) part of it. So I've replaced this with: mvpp2_port_mii_set(port); mvpp2_port_periodic_xon_disable(port); if (priv->hw_version == MVPP21) mvpp2_port_fc_adv_enable(port); mvpp2_port_reset(port); This will be in my v3. > In any case, the GMAC part is much the same as mvneta, and I think > that code should be shared rather than writing new versions of it. Possibly, but it's really a separate thing: this is completely independent from introducing PPv2.2 support, it's something that already exists. The patch series is already 16 patches long in its v2, and is going to even a bit longer in its v3, so I would really like to stick to just PPv2.2 support. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv2 net-next 11/16] net: mvpp2: handle misc PPv2.1/PPv2.2 differences Date: Tue, 14 Feb 2017 15:53:13 +0100 [thread overview] Message-ID: <20170214155313.1e9a497b@free-electrons.com> (raw) In-Reply-To: <20170107093834.GJ14217@n2100.armlinux.org.uk> Hello, On Sat, 7 Jan 2017 09:38:34 +0000, Russell King - ARM Linux wrote: > This has the side effect that nothing clears the port reset bit in the > GMAC, which means there's no hope of the interface working - with the > reset bit set, the port is well and truely held in "link down" state. Things were working fine here on Armada 7K/8K even without calling mvpp21_port_power_up(port). But I've looked into more details, and in fact the whole function makes sense on PPv2.2, except the mvpp2_port_fc_adv_enable(port) part of it. So I've replaced this with: mvpp2_port_mii_set(port); mvpp2_port_periodic_xon_disable(port); if (priv->hw_version == MVPP21) mvpp2_port_fc_adv_enable(port); mvpp2_port_reset(port); This will be in my v3. > In any case, the GMAC part is much the same as mvneta, and I think > that code should be shared rather than writing new versions of it. Possibly, but it's really a separate thing: this is completely independent from introducing PPv2.2 support, it's something that already exists. The patch series is already 16 patches long in its v2, and is going to even a bit longer in its v3, so I would really like to stick to just PPv2.2 support. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
next prev parent reply other threads:[~2017-02-14 14:53 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-12-28 16:46 [PATCHv2 net-next 00/16] net: mvpp2: add basic support for PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni [not found] ` <1482943592-12556-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-12-28 16:46 ` [PATCHv2 net-next 01/16] dt-bindings: net: update Marvell PPv2 binding for PPv2.2 support Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni [not found] ` <1482943592-12556-2-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-01-03 20:18 ` Rob Herring 2017-01-03 20:18 ` Rob Herring 2017-02-02 16:56 ` Thomas Petazzoni 2017-02-02 16:56 ` Thomas Petazzoni 2017-02-03 16:48 ` Russell King - ARM Linux 2017-02-03 16:48 ` Russell King - ARM Linux 2017-02-14 14:25 ` Thomas Petazzoni 2017-02-14 14:25 ` Thomas Petazzoni [not found] ` <20170214152503.602878cb-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-02-21 10:12 ` Thomas Petazzoni 2017-02-21 10:12 ` Thomas Petazzoni 2017-01-07 9:32 ` Russell King - ARM Linux 2017-01-07 9:32 ` Russell King - ARM Linux 2017-02-02 16:44 ` Thomas Petazzoni 2017-02-02 16:44 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 02/16] net: mvpp2: add and use accessors for TX/RX descriptors Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 03/16] net: mvpp2: add hw_version field in "struct mvpp2" Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 07/16] net: mvpp2: adapt the mvpp2_rxq_*_pool_set functions to PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 14/16] net: mvpp2: adapt rxq distribution " Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 16/16] net: mvpp2: finally add the PPv2.2 compatible string Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 17:06 ` [PATCHv2 net-next 00/16] net: mvpp2: add basic support for PPv2.2 David Miller 2016-12-28 17:06 ` David Miller [not found] ` <20161228.120644.1166014191192724301.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> 2016-12-28 21:08 ` Thomas Petazzoni 2016-12-28 21:08 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 04/16] net: mvpp2: introduce an intermediate union for the TX/RX descriptors Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 05/16] net: mvpp2: introduce PPv2.2 HW descriptors and adapt accessors Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2017-01-06 14:29 ` Russell King - ARM Linux 2017-01-06 14:29 ` Russell King - ARM Linux 2017-01-06 14:44 ` Robin Murphy 2017-01-06 14:44 ` Robin Murphy [not found] ` <113811b6-79a4-9c66-d302-add9fb0c5b1a-5wv7dgnIgG8@public.gmane.org> 2017-02-03 13:24 ` Thomas Petazzoni 2017-02-03 13:24 ` Thomas Petazzoni 2017-02-03 14:05 ` Robin Murphy 2017-02-03 14:05 ` Robin Murphy [not found] ` <231514f4-2e35-8bde-4469-aada833635aa-5wv7dgnIgG8@public.gmane.org> 2017-02-03 15:02 ` Thomas Petazzoni 2017-02-03 15:02 ` Thomas Petazzoni [not found] ` <20170203160227.08b40c58-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-02-03 16:31 ` Robin Murphy 2017-02-03 16:31 ` Robin Murphy 2017-02-03 15:54 ` Russell King - ARM Linux 2017-02-03 15:54 ` Russell King - ARM Linux 2017-02-04 13:59 ` Thomas Petazzoni 2017-02-04 13:59 ` Thomas Petazzoni 2017-02-06 12:43 ` David Laight 2017-02-06 12:43 ` David Laight 2017-02-06 12:43 ` David Laight 2016-12-28 16:46 ` [PATCHv2 net-next 06/16] net: mvpp2: adjust the allocation/free of BM pools for PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2017-01-06 14:32 ` Russell King - ARM Linux 2017-01-06 14:32 ` Russell King - ARM Linux 2016-12-28 16:46 ` [PATCHv2 net-next 08/16] net: mvpp2: adapt mvpp2_defaults_set() to PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 09/16] net: mvpp2: adjust mvpp2_{rxq,txq}_init for PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 09/16] net: mvpp2: adjust mvpp2_{rxq, txq}_init " Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 10/16] net: mvpp2: handle register mapping and access " Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2017-01-06 14:46 ` Russell King - ARM Linux 2017-01-06 14:46 ` Russell King - ARM Linux [not found] ` <20170106144648.GE14217-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> 2017-03-02 8:45 ` Thomas Petazzoni 2017-03-02 8:45 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 11/16] net: mvpp2: handle misc PPv2.1/PPv2.2 differences Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2017-01-07 9:38 ` Russell King - ARM Linux 2017-01-07 9:38 ` Russell King - ARM Linux [not found] ` <20170107093834.GJ14217-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> 2017-01-07 20:10 ` Russell King - ARM Linux 2017-01-07 20:10 ` Russell King - ARM Linux 2017-02-14 14:53 ` Thomas Petazzoni [this message] 2017-02-14 14:53 ` Thomas Petazzoni 2017-01-07 11:03 ` Russell King - ARM Linux 2017-01-07 11:03 ` Russell King - ARM Linux 2017-01-07 12:12 ` Marcin Wojtas 2017-01-07 12:12 ` Marcin Wojtas [not found] ` <CAPv3WKeQ=fj2cKPyJ2NqCaAv55cOyWodujKwj3-v5iCrDYNcmA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-01-07 13:50 ` Russell King - ARM Linux 2017-01-07 13:50 ` Russell King - ARM Linux 2017-01-07 13:50 ` Russell King - ARM Linux 2016-12-28 16:46 ` [PATCHv2 net-next 12/16] net: mvpp2: add AXI bridge initialization for PPv2.2 Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 13/16] net: mvpp2: rework RXQ interrupt group " Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni 2016-12-28 16:46 ` [PATCHv2 net-next 15/16] net: mvpp2: add support for an additional clock needed " Thomas Petazzoni 2016-12-28 16:46 ` Thomas Petazzoni [not found] ` <1482943592-12556-16-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2017-01-07 9:29 ` Russell King - ARM Linux 2017-01-07 9:29 ` Russell King - ARM Linux
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170214155313.1e9a497b@free-electrons.com \ --to=thomas.petazzoni@free-electrons.com \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=gregory.clement@free-electrons.com \ --cc=hannah@marvell.com \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux@armlinux.org.uk \ --cc=mark.rutland@arm.com \ --cc=mw@semihalf.com \ --cc=nadavh@marvell.com \ --cc=netdev@vger.kernel.org \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=stefanc@marvell.com \ --cc=yehuday@marvell.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.