From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> To: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Tanmay Inamdar <tinamdar@apm.com> Subject: [PATCH 17/20] PCI: xgene: update PCI config space remap function Date: Mon, 27 Feb 2017 15:14:28 +0000 [thread overview] Message-ID: <20170227151436.18698-18-lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <20170227151436.18698-1-lorenzo.pieralisi@arm.com> PCI configuration space should be mapped with a memory region type that generates on the CPU host bus non-posted write transations. Update the driver to use the devm_pci_remap_cfg* interface to make sure the correct memory mappings for PCI configuration space are used. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Tanmay Inamdar <tinamdar@apm.com> --- drivers/pci/host/pci-xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c index 1a61087..de19898 100644 --- a/drivers/pci/host/pci-xgene.c +++ b/drivers/pci/host/pci-xgene.c @@ -248,7 +248,7 @@ static int xgene_pcie_ecam_init(struct pci_config_window *cfg, u32 ipversion) dev_err(dev, "can't get CSR resource\n"); return ret; } - port->csr_base = devm_ioremap_resource(dev, &csr); + port->csr_base = devm_pci_remap_cfg_resource(dev, &csr); if (IS_ERR(port->csr_base)) return PTR_ERR(port->csr_base); @@ -359,7 +359,7 @@ static int xgene_pcie_map_reg(struct xgene_pcie_port *port, struct resource *res; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); - port->csr_base = devm_ioremap_resource(dev, res); + port->csr_base = devm_pci_remap_cfg_resource(dev, res); if (IS_ERR(port->csr_base)) return PTR_ERR(port->csr_base); -- 2.10.0
WARNING: multiple messages have this Message-ID (diff)
From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 17/20] PCI: xgene: update PCI config space remap function Date: Mon, 27 Feb 2017 15:14:28 +0000 [thread overview] Message-ID: <20170227151436.18698-18-lorenzo.pieralisi@arm.com> (raw) In-Reply-To: <20170227151436.18698-1-lorenzo.pieralisi@arm.com> PCI configuration space should be mapped with a memory region type that generates on the CPU host bus non-posted write transations. Update the driver to use the devm_pci_remap_cfg* interface to make sure the correct memory mappings for PCI configuration space are used. Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Tanmay Inamdar <tinamdar@apm.com> --- drivers/pci/host/pci-xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c index 1a61087..de19898 100644 --- a/drivers/pci/host/pci-xgene.c +++ b/drivers/pci/host/pci-xgene.c @@ -248,7 +248,7 @@ static int xgene_pcie_ecam_init(struct pci_config_window *cfg, u32 ipversion) dev_err(dev, "can't get CSR resource\n"); return ret; } - port->csr_base = devm_ioremap_resource(dev, &csr); + port->csr_base = devm_pci_remap_cfg_resource(dev, &csr); if (IS_ERR(port->csr_base)) return PTR_ERR(port->csr_base); @@ -359,7 +359,7 @@ static int xgene_pcie_map_reg(struct xgene_pcie_port *port, struct resource *res; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csr"); - port->csr_base = devm_ioremap_resource(dev, res); + port->csr_base = devm_pci_remap_cfg_resource(dev, res); if (IS_ERR(port->csr_base)) return PTR_ERR(port->csr_base); -- 2.10.0
next prev parent reply other threads:[~2017-02-27 15:15 UTC|newest] Thread overview: 183+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-27 15:14 [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-01 16:15 ` Arnd Bergmann 2017-03-01 16:15 ` Arnd Bergmann 2017-03-01 16:15 ` Arnd Bergmann 2017-03-01 16:15 ` Arnd Bergmann 2017-02-27 15:14 ` [PATCH 02/20] PCI: fix pci_remap_iospace() remap attribute Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-16 21:48 ` Bjorn Helgaas 2017-03-16 21:48 ` Bjorn Helgaas 2017-03-16 21:48 ` Bjorn Helgaas 2017-03-16 21:48 ` Bjorn Helgaas 2017-03-17 0:33 ` Luis R. Rodriguez 2017-03-17 0:33 ` Luis R. Rodriguez 2017-03-17 0:33 ` Luis R. Rodriguez 2017-03-17 10:43 ` Liviu Dudau 2017-03-17 10:43 ` Liviu Dudau 2017-03-17 10:43 ` Liviu Dudau 2017-03-17 10:43 ` Liviu Dudau 2017-03-17 16:26 ` Luis R. Rodriguez 2017-03-17 16:26 ` Luis R. Rodriguez 2017-03-17 16:26 ` Luis R. Rodriguez 2017-03-20 16:19 ` Lorenzo Pieralisi 2017-03-20 16:19 ` Lorenzo Pieralisi 2017-03-20 16:19 ` Lorenzo Pieralisi 2017-03-20 16:06 ` Bjorn Helgaas 2017-03-20 16:06 ` Bjorn Helgaas 2017-03-20 16:06 ` Bjorn Helgaas 2017-03-20 16:06 ` Bjorn Helgaas 2017-03-20 16:26 ` Lorenzo Pieralisi 2017-03-20 16:26 ` Lorenzo Pieralisi 2017-03-20 16:26 ` Lorenzo Pieralisi 2017-03-20 16:38 ` Bjorn Helgaas 2017-03-20 16:38 ` Bjorn Helgaas 2017-03-20 16:38 ` Bjorn Helgaas 2017-03-20 16:38 ` Bjorn Helgaas 2017-02-27 15:14 ` [PATCH 03/20] asm-generic/io.h: add PCI config space remap interface Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-16 21:12 ` Bjorn Helgaas 2017-03-16 21:12 ` Bjorn Helgaas 2017-03-16 21:12 ` Bjorn Helgaas 2017-03-17 0:08 ` Luis R. Rodriguez 2017-03-17 0:08 ` Luis R. Rodriguez 2017-03-17 0:08 ` Luis R. Rodriguez 2017-03-20 10:22 ` John Garry 2017-03-20 10:22 ` John Garry 2017-03-20 10:22 ` John Garry 2017-03-20 10:22 ` John Garry 2017-03-20 16:27 ` Bjorn Helgaas 2017-03-20 16:27 ` Bjorn Helgaas 2017-03-20 16:27 ` Bjorn Helgaas 2017-03-20 16:27 ` Bjorn Helgaas 2017-03-20 18:45 ` Lorenzo Pieralisi 2017-03-20 18:45 ` Lorenzo Pieralisi 2017-03-20 18:45 ` Lorenzo Pieralisi 2017-03-22 15:04 ` Lorenzo Pieralisi 2017-03-22 15:04 ` Lorenzo Pieralisi 2017-03-22 15:04 ` Lorenzo Pieralisi 2017-03-22 15:15 ` Arnd Bergmann 2017-03-22 15:15 ` Arnd Bergmann 2017-03-22 15:15 ` Arnd Bergmann 2017-03-22 16:29 ` Bjorn Helgaas 2017-03-22 16:29 ` Bjorn Helgaas 2017-03-22 16:29 ` Bjorn Helgaas 2017-03-22 16:29 ` Bjorn Helgaas 2017-02-27 15:14 ` [PATCH 04/20] ARM64: implement pci_remap_cfgspace() interface Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 05/20] ARM: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-20 16:43 ` Russell King - ARM Linux 2017-03-20 16:43 ` Russell King - ARM Linux 2017-03-20 16:43 ` Russell King - ARM Linux 2017-03-20 16:43 ` Russell King - ARM Linux 2017-03-21 15:26 ` Lorenzo Pieralisi 2017-03-21 15:26 ` Lorenzo Pieralisi 2017-03-21 15:26 ` Lorenzo Pieralisi 2017-03-21 15:26 ` Lorenzo Pieralisi 2017-03-21 16:53 ` Russell King - ARM Linux 2017-03-21 16:53 ` Russell King - ARM Linux 2017-03-21 16:53 ` Russell King - ARM Linux 2017-03-21 16:53 ` Russell King - ARM Linux 2017-02-27 15:14 ` [PATCH 06/20] PCI: ECAM: use pci_remap_cfgspace() to map config region Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 07/20] PCI: implement Devres interface to map PCI config space Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-28 10:43 ` Lorenzo Pieralisi 2017-02-28 10:43 ` Lorenzo Pieralisi 2017-02-28 10:43 ` Lorenzo Pieralisi 2017-02-28 10:43 ` Lorenzo Pieralisi 2017-03-01 23:54 ` Andy Shevchenko 2017-03-01 23:54 ` Andy Shevchenko 2017-03-01 23:54 ` Andy Shevchenko 2017-03-01 23:54 ` Andy Shevchenko 2017-03-02 12:05 ` Lorenzo Pieralisi 2017-03-02 12:05 ` Lorenzo Pieralisi 2017-03-02 12:05 ` Lorenzo Pieralisi 2017-03-02 12:05 ` Lorenzo Pieralisi 2017-03-02 12:50 ` Andy Shevchenko 2017-03-02 12:50 ` Andy Shevchenko 2017-03-02 12:50 ` Andy Shevchenko 2017-03-02 12:50 ` Andy Shevchenko 2017-03-02 19:24 ` Tejun Heo 2017-03-02 19:24 ` Tejun Heo 2017-03-02 19:24 ` Tejun Heo 2017-03-02 19:24 ` Tejun Heo 2017-03-02 20:08 ` Thierry Reding 2017-03-02 20:08 ` Thierry Reding 2017-03-02 20:08 ` Thierry Reding 2017-03-02 20:08 ` Thierry Reding 2017-02-27 15:14 ` [PATCH 08/20] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 09/20] PCI: xilinx-nwl: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 10/20] PCI: spear13xx: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 11/20] PCI: rockchip: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 12/20] PCI: qcom: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 13/20] PCI: iproc-platform: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 21:21 ` Ray Jui 2017-02-27 21:21 ` Ray Jui 2017-02-27 21:21 ` Ray Jui 2017-02-27 21:21 ` Ray Jui 2017-02-28 10:54 ` Lorenzo Pieralisi 2017-02-28 10:54 ` Lorenzo Pieralisi 2017-02-28 10:54 ` Lorenzo Pieralisi 2017-02-28 10:54 ` Lorenzo Pieralisi 2017-02-28 17:42 ` Ray Jui 2017-02-28 17:42 ` Ray Jui 2017-02-28 17:42 ` Ray Jui 2017-02-28 17:42 ` Ray Jui 2017-02-27 15:14 ` [PATCH 14/20] PCI: hisi: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-02 10:56 ` Gabriele Paoloni 2017-03-02 10:56 ` Gabriele Paoloni 2017-03-02 10:56 ` Gabriele Paoloni 2017-03-02 10:56 ` Gabriele Paoloni 2017-03-02 10:56 ` Gabriele Paoloni 2017-03-02 11:49 ` Lorenzo Pieralisi 2017-03-02 11:49 ` Lorenzo Pieralisi 2017-03-02 11:49 ` Lorenzo Pieralisi 2017-03-02 11:49 ` Lorenzo Pieralisi 2017-03-02 11:49 ` Lorenzo Pieralisi 2017-03-02 11:53 ` Gabriele Paoloni 2017-03-02 11:53 ` Gabriele Paoloni 2017-03-02 11:53 ` Gabriele Paoloni 2017-02-27 15:14 ` [PATCH 15/20] PCI: designware: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 16/20] PCI: armada8k: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi [this message] 2017-02-27 15:14 ` [PATCH 17/20] PCI: xgene: " Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 18/20] PCI: tegra: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 19/20] PCI: layerscape: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-02-27 15:14 ` [PATCH 20/20] PCI: keystone-dw: " Lorenzo Pieralisi 2017-02-27 15:14 ` Lorenzo Pieralisi 2017-03-01 16:18 ` [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Arnd Bergmann 2017-03-01 16:18 ` Arnd Bergmann 2017-03-01 16:18 ` Arnd Bergmann 2017-03-01 16:18 ` Arnd Bergmann 2017-03-02 18:00 ` Lorenzo Pieralisi 2017-03-02 18:00 ` Lorenzo Pieralisi 2017-03-02 18:00 ` Lorenzo Pieralisi 2017-03-02 18:00 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170227151436.18698-18-lorenzo.pieralisi@arm.com \ --to=lorenzo.pieralisi@arm.com \ --cc=bhelgaas@google.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=tinamdar@apm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.