From: Arnd Bergmann <arnd@arndb.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Russell King <linux@armlinux.org.uk>,
Pratyush Anand <pratyush.anand@gmail.com>,
Jingoo Han <jingoohan1@gmail.com>,
Mingkai Hu <mingkai.hu@freescale.com>,
John Garry <john.garry@huawei.com>,
Tanmay Inamdar <tinamdar@apm.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
Ray Jui <rjui@broadcom.com>, Wenrui Li <wenrui.li@rock-chips.com>,
Shawn Lin <shawn.lin@rock-chips.com>,
Minghuan Lian <minghuan.Lian@freescale.com>,
Jon Mason <jonmason@broadcom.com>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Thierry Reding <thierry.reding@gmail.com>,
Michal Simek <michal.simek@xilinx.com>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Roy Zang <tie-fei.zang@freescale.com>
Subject: Re: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace()
Date: Wed, 1 Mar 2017 17:15:14 +0100 [thread overview]
Message-ID: <CAK8P3a36fX2gdgdYcVT1Zg=5dsN1o-Z=Xy4471zxRWwnr1aZvw@mail.gmail.com> (raw)
In-Reply-To: <20170227151436.18698-2-lorenzo.pieralisi@arm.com>
On Mon, Feb 27, 2017 at 4:14 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> pci_remap_iospace() is marked as a weak symbol even though
> no architecture is currently overriding it; given that its
> implementation internals have already code paths that are
> arch specific (ie PCI_IOBASE and ioremap_page_range() attributes)
> there is no need to leave the weak symbol in the kernel since the
> same functionality can be achieved by customizing per-arch the
> corresponding functionality.
>
> Remove the __weak symbol from pci_remap_iospace().
Good idea,
Acked-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Wenrui Li <wenrui.li@rock-chips.com>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
linux-pci <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Will Deacon <will.deacon@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
Thierry Reding <thierry.reding@gmail.com>,
Tanmay Inamdar <tinamdar@apm.com>,
linux-arch <linux-arch@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jon Mason <jonmason@broadcom.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
Ray Jui <rjui@broadcom.com>, John Garry <john.garry@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mingkai Hu <mingkai.hu@freescale.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Jingoo Han <jingoohan1@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stanimir Varbanov <svarbanov@mm-sol.com>,
Minghuan Lian <minghuan.Lian@freescale.com>,
Zhou Wang <wangzhou1@hisilicon.com>,
Roy Zang <tie-fei.zang@freescale.com>
Subject: Re: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace()
Date: Wed, 1 Mar 2017 17:15:14 +0100 [thread overview]
Message-ID: <CAK8P3a36fX2gdgdYcVT1Zg=5dsN1o-Z=Xy4471zxRWwnr1aZvw@mail.gmail.com> (raw)
In-Reply-To: <20170227151436.18698-2-lorenzo.pieralisi@arm.com>
On Mon, Feb 27, 2017 at 4:14 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> pci_remap_iospace() is marked as a weak symbol even though
> no architecture is currently overriding it; given that its
> implementation internals have already code paths that are
> arch specific (ie PCI_IOBASE and ioremap_page_range() attributes)
> there is no need to leave the weak symbol in the kernel since the
> same functionality can be achieved by customizing per-arch the
> corresponding functionality.
>
> Remove the __weak symbol from pci_remap_iospace().
Good idea,
Acked-by: Arnd Bergmann <arnd@arndb.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Wenrui Li <wenrui.li@rock-chips.com>,
Gabriele Paoloni <gabriele.paoloni@huawei.com>,
linux-pci <linux-pci@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
Will Deacon <will.deacon@arm.com>,
Michal Simek <michal.simek@xilinx.com>,
Thierry Reding <thierry.reding@gmail.com>,
Tanmay Inamdar <tinamdar@apm.com>,
linux-arch <linux-arch@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Pratyush Anand <pratyush.anand@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Jon Mason <jonmason@broadcom.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com>,
Ray Jui <rjui@broadcom.com>, John Garry <john.garry@huawei.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Mingkai Hu <mingkai.hu@freescale.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@free-ele>
Subject: Re: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace()
Date: Wed, 1 Mar 2017 17:15:14 +0100 [thread overview]
Message-ID: <CAK8P3a36fX2gdgdYcVT1Zg=5dsN1o-Z=Xy4471zxRWwnr1aZvw@mail.gmail.com> (raw)
In-Reply-To: <20170227151436.18698-2-lorenzo.pieralisi@arm.com>
On Mon, Feb 27, 2017 at 4:14 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> pci_remap_iospace() is marked as a weak symbol even though
> no architecture is currently overriding it; given that its
> implementation internals have already code paths that are
> arch specific (ie PCI_IOBASE and ioremap_page_range() attributes)
> there is no need to leave the weak symbol in the kernel since the
> same functionality can be achieved by customizing per-arch the
> corresponding functionality.
>
> Remove the __weak symbol from pci_remap_iospace().
Good idea,
Acked-by: Arnd Bergmann <arnd@arndb.de>
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace()
Date: Wed, 1 Mar 2017 17:15:14 +0100 [thread overview]
Message-ID: <CAK8P3a36fX2gdgdYcVT1Zg=5dsN1o-Z=Xy4471zxRWwnr1aZvw@mail.gmail.com> (raw)
In-Reply-To: <20170227151436.18698-2-lorenzo.pieralisi@arm.com>
On Mon, Feb 27, 2017 at 4:14 PM, Lorenzo Pieralisi
<lorenzo.pieralisi@arm.com> wrote:
> pci_remap_iospace() is marked as a weak symbol even though
> no architecture is currently overriding it; given that its
> implementation internals have already code paths that are
> arch specific (ie PCI_IOBASE and ioremap_page_range() attributes)
> there is no need to leave the weak symbol in the kernel since the
> same functionality can be achieved by customizing per-arch the
> corresponding functionality.
>
> Remove the __weak symbol from pci_remap_iospace().
Good idea,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2017-03-01 16:17 UTC|newest]
Thread overview: 183+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 15:14 [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 01/20] PCI: remove __weak tag from pci_remap_iospace() Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-01 16:15 ` Arnd Bergmann [this message]
2017-03-01 16:15 ` Arnd Bergmann
2017-03-01 16:15 ` Arnd Bergmann
2017-03-01 16:15 ` Arnd Bergmann
2017-02-27 15:14 ` [PATCH 02/20] PCI: fix pci_remap_iospace() remap attribute Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-16 21:48 ` Bjorn Helgaas
2017-03-17 0:33 ` Luis R. Rodriguez
2017-03-17 0:33 ` Luis R. Rodriguez
2017-03-17 0:33 ` Luis R. Rodriguez
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 10:43 ` Liviu Dudau
2017-03-17 16:26 ` Luis R. Rodriguez
2017-03-17 16:26 ` Luis R. Rodriguez
2017-03-17 16:26 ` Luis R. Rodriguez
2017-03-20 16:19 ` Lorenzo Pieralisi
2017-03-20 16:19 ` Lorenzo Pieralisi
2017-03-20 16:19 ` Lorenzo Pieralisi
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:06 ` Bjorn Helgaas
2017-03-20 16:26 ` Lorenzo Pieralisi
2017-03-20 16:26 ` Lorenzo Pieralisi
2017-03-20 16:26 ` Lorenzo Pieralisi
2017-03-20 16:38 ` Bjorn Helgaas
2017-03-20 16:38 ` Bjorn Helgaas
2017-03-20 16:38 ` Bjorn Helgaas
2017-03-20 16:38 ` Bjorn Helgaas
2017-02-27 15:14 ` [PATCH 03/20] asm-generic/io.h: add PCI config space remap interface Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-16 21:12 ` Bjorn Helgaas
2017-03-16 21:12 ` Bjorn Helgaas
2017-03-16 21:12 ` Bjorn Helgaas
2017-03-17 0:08 ` Luis R. Rodriguez
2017-03-17 0:08 ` Luis R. Rodriguez
2017-03-17 0:08 ` Luis R. Rodriguez
2017-03-20 10:22 ` John Garry
2017-03-20 10:22 ` John Garry
2017-03-20 10:22 ` John Garry
2017-03-20 10:22 ` John Garry
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 16:27 ` Bjorn Helgaas
2017-03-20 18:45 ` Lorenzo Pieralisi
2017-03-20 18:45 ` Lorenzo Pieralisi
2017-03-20 18:45 ` Lorenzo Pieralisi
2017-03-22 15:04 ` Lorenzo Pieralisi
2017-03-22 15:04 ` Lorenzo Pieralisi
2017-03-22 15:04 ` Lorenzo Pieralisi
2017-03-22 15:15 ` Arnd Bergmann
2017-03-22 15:15 ` Arnd Bergmann
2017-03-22 15:15 ` Arnd Bergmann
2017-03-22 16:29 ` Bjorn Helgaas
2017-03-22 16:29 ` Bjorn Helgaas
2017-03-22 16:29 ` Bjorn Helgaas
2017-03-22 16:29 ` Bjorn Helgaas
2017-02-27 15:14 ` [PATCH 04/20] ARM64: implement pci_remap_cfgspace() interface Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 05/20] ARM: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-20 16:43 ` Russell King - ARM Linux
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 15:26 ` Lorenzo Pieralisi
2017-03-21 16:53 ` Russell King - ARM Linux
2017-03-21 16:53 ` Russell King - ARM Linux
2017-03-21 16:53 ` Russell King - ARM Linux
2017-03-21 16:53 ` Russell King - ARM Linux
2017-02-27 15:14 ` [PATCH 06/20] PCI: ECAM: use pci_remap_cfgspace() to map config region Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 07/20] PCI: implement Devres interface to map PCI config space Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-02-28 10:43 ` Lorenzo Pieralisi
2017-03-01 23:54 ` Andy Shevchenko
2017-03-01 23:54 ` Andy Shevchenko
2017-03-01 23:54 ` Andy Shevchenko
2017-03-01 23:54 ` Andy Shevchenko
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:05 ` Lorenzo Pieralisi
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 12:50 ` Andy Shevchenko
2017-03-02 19:24 ` Tejun Heo
2017-03-02 19:24 ` Tejun Heo
2017-03-02 19:24 ` Tejun Heo
2017-03-02 19:24 ` Tejun Heo
2017-03-02 20:08 ` Thierry Reding
2017-03-02 20:08 ` Thierry Reding
2017-03-02 20:08 ` Thierry Reding
2017-03-02 20:08 ` Thierry Reding
2017-02-27 15:14 ` [PATCH 08/20] PCI: xilinx: update PCI config space remap function Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 09/20] PCI: xilinx-nwl: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 10/20] PCI: spear13xx: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 11/20] PCI: rockchip: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 12/20] PCI: qcom: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 13/20] PCI: iproc-platform: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 21:21 ` Ray Jui
2017-02-27 21:21 ` Ray Jui
2017-02-27 21:21 ` Ray Jui
2017-02-27 21:21 ` Ray Jui
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 10:54 ` Lorenzo Pieralisi
2017-02-28 17:42 ` Ray Jui
2017-02-28 17:42 ` Ray Jui
2017-02-28 17:42 ` Ray Jui
2017-02-28 17:42 ` Ray Jui
2017-02-27 15:14 ` [PATCH 14/20] PCI: hisi: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 10:56 ` Gabriele Paoloni
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:49 ` Lorenzo Pieralisi
2017-03-02 11:53 ` Gabriele Paoloni
2017-03-02 11:53 ` Gabriele Paoloni
2017-03-02 11:53 ` Gabriele Paoloni
2017-02-27 15:14 ` [PATCH 15/20] PCI: designware: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 16/20] PCI: armada8k: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 17/20] PCI: xgene: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 18/20] PCI: tegra: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 19/20] PCI: layerscape: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-02-27 15:14 ` [PATCH 20/20] PCI: keystone-dw: " Lorenzo Pieralisi
2017-02-27 15:14 ` Lorenzo Pieralisi
2017-03-01 16:18 ` [PATCH 00/20] PCI: fix config and I/O Address space memory mappings Arnd Bergmann
2017-03-01 16:18 ` Arnd Bergmann
2017-03-01 16:18 ` Arnd Bergmann
2017-03-01 16:18 ` Arnd Bergmann
2017-03-02 18:00 ` Lorenzo Pieralisi
2017-03-02 18:00 ` Lorenzo Pieralisi
2017-03-02 18:00 ` Lorenzo Pieralisi
2017-03-02 18:00 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a36fX2gdgdYcVT1Zg=5dsN1o-Z=Xy4471zxRWwnr1aZvw@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=Joao.Pinto@synopsys.com \
--cc=bharat.kumar.gogada@xilinx.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=gabriele.paoloni@huawei.com \
--cc=jingoohan1@gmail.com \
--cc=john.garry@huawei.com \
--cc=jonmason@broadcom.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=m-karicheri2@ti.com \
--cc=michal.simek@xilinx.com \
--cc=minghuan.Lian@freescale.com \
--cc=mingkai.hu@freescale.com \
--cc=pratyush.anand@gmail.com \
--cc=rjui@broadcom.com \
--cc=shawn.lin@rock-chips.com \
--cc=svarbanov@mm-sol.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tie-fei.zang@freescale.com \
--cc=tinamdar@apm.com \
--cc=wangzhou1@hisilicon.com \
--cc=wenrui.li@rock-chips.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.