* [PATCH] vhost: change log levels in client mode
[not found] <CGME20170302093942eucas1p1f0cf693364fdfb09c87ec8f72415d775@eucas1p1.samsung.com>
@ 2017-03-02 9:39 ` Ilya Maximets
2017-03-02 13:33 ` Maxime Coquelin
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Maximets @ 2017-03-02 9:39 UTC (permalink / raw)
To: dev, Yuanhan Liu, Maxime Coquelin; +Cc: Heetae Ahn, Ilya Maximets, stable
Inability to connect to socket is a normal situation
in client mode because, in common case, server isn't
started yet. RTE_LOG_WARNING should be suitable for
the case of some unusual errors.
Message about reconnection is not an error at all.
CC: stable@dpdk.org
Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
---
lib/librte_vhost/socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index aaa9c27..6a30a31 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
return 0;
}
- RTE_LOG(ERR, VHOST_CONFIG,
+ RTE_LOG(WARNING, VHOST_CONFIG,
"failed to connect to %s: %s\n",
path, strerror(errno));
@@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
return -1;
}
- RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
+ RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
reconn = malloc(sizeof(*reconn));
if (reconn == NULL) {
RTE_LOG(ERR, VHOST_CONFIG,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: change log levels in client mode
2017-03-02 9:39 ` [PATCH] vhost: change log levels in client mode Ilya Maximets
@ 2017-03-02 13:33 ` Maxime Coquelin
2017-03-03 2:07 ` Yuanhan Liu
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2017-03-02 13:33 UTC (permalink / raw)
To: Ilya Maximets, dev, Yuanhan Liu; +Cc: Heetae Ahn, stable
On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> Inability to connect to socket is a normal situation
> in client mode because, in common case, server isn't
> started yet. RTE_LOG_WARNING should be suitable for
> the case of some unusual errors.
> Message about reconnection is not an error at all.
>
> CC: stable@dpdk.org
> Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
>
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> lib/librte_vhost/socket.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
> index aaa9c27..6a30a31 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -448,7 +448,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return 0;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG,
> + RTE_LOG(WARNING, VHOST_CONFIG,
> "failed to connect to %s: %s\n",
> path, strerror(errno));
>
> @@ -457,7 +457,7 @@ vhost_user_create_client(struct vhost_user_socket *vsocket)
> return -1;
> }
>
> - RTE_LOG(ERR, VHOST_CONFIG, "%s: reconnecting...\n", path);
> + RTE_LOG(INFO, VHOST_CONFIG, "%s: reconnecting...\n", path);
> reconn = malloc(sizeof(*reconn));
> if (reconn == NULL) {
> RTE_LOG(ERR, VHOST_CONFIG,
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vhost: change log levels in client mode
2017-03-02 13:33 ` Maxime Coquelin
@ 2017-03-03 2:07 ` Yuanhan Liu
0 siblings, 0 replies; 3+ messages in thread
From: Yuanhan Liu @ 2017-03-03 2:07 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: Ilya Maximets, dev, Heetae Ahn, stable
On Thu, Mar 02, 2017 at 02:33:27PM +0100, Maxime Coquelin wrote:
>
>
> On 03/02/2017 10:39 AM, Ilya Maximets wrote:
> >Inability to connect to socket is a normal situation
> >in client mode because, in common case, server isn't
> >started yet. RTE_LOG_WARNING should be suitable for
> >the case of some unusual errors.
> >Message about reconnection is not an error at all.
> >
> >CC: stable@dpdk.org
> >Fixes: e623e0c6d8a5 ("vhost: add reconnect ability")
> >
> >Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
...
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied to dpdk-next-virtio.
Thanks.
--yliu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-03 2:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20170302093942eucas1p1f0cf693364fdfb09c87ec8f72415d775@eucas1p1.samsung.com>
2017-03-02 9:39 ` [PATCH] vhost: change log levels in client mode Ilya Maximets
2017-03-02 13:33 ` Maxime Coquelin
2017-03-03 2:07 ` Yuanhan Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.