From: Peter De Schrijver <pdeschrijver@nvidia.com> To: Jon Hunter <jonathanh@nvidia.com> Cc: Prashant Gaikwad <pgaikwad@nvidia.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Stephen Warren <swarren@wwwdotorg.org>, Thierry Reding <thierry.reding@gmail.com>, Alexandre Courbot <gnurou@gmail.com>, linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on Date: Mon, 6 Mar 2017 16:28:50 +0200 [thread overview] Message-ID: <20170306142850.GJ26640@tbergstrom-lnx.Nvidia.com> (raw) In-Reply-To: <6d4dd315-cab6-189d-f383-fb7523fc31bd@nvidia.com> On Mon, Mar 06, 2017 at 09:58:29AM +0000, Jon Hunter wrote: > > On 06/03/17 08:38, Peter De Schrijver wrote: > > On Thu, Mar 02, 2017 at 05:56:49PM +0000, Jon Hunter wrote: > >> > >> On 28/02/17 15:19, Peter De Schrijver wrote: > >>> This is needed to make the JTAG debugging interface work. > >>> > >>> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > >>> --- > >>> drivers/clk/tegra/clk-tegra210.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > >>> index 9a2512a..708f5f1 100644 > >>> --- a/drivers/clk/tegra/clk-tegra210.c > >>> +++ b/drivers/clk/tegra/clk-tegra210.c > >>> @@ -2680,6 +2680,7 @@ static void tegra210_cpu_clock_resume(void) > >>> { TEGRA210_CLK_EMC, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_MSELECT, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_CSITE, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> + { TEGRA210_CLK_DBGAPB, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_TSENSOR, TEGRA210_CLK_CLK_M, 400000, 0 }, > >>> { TEGRA210_CLK_I2C1, TEGRA210_CLK_PLL_P, 0, 0 }, > >>> { TEGRA210_CLK_I2C2, TEGRA210_CLK_PLL_P, 0, 0 }, > >> > >> Should there be some dependency on say CONFIG_DEBUG_KERNEL? I am not > >> sure we always want this on for all cases. > > > > Why would you not want it to be always on? > > Purely for power reasons. I do not know how much power keeping this I don't expect it to be significant but I don't have any numbers. > clock running consumes, but I don't like the idea of clocks running all > the time when they are not needed. > Problem is that in this case there is no easy way to determine if the clock needs to be on. Peter.
WARNING: multiple messages have this Message-ID (diff)
From: Peter De Schrijver <pdeschrijver@nvidia.com> To: Jon Hunter <jonathanh@nvidia.com> Cc: Prashant Gaikwad <pgaikwad@nvidia.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, "Stephen Warren" <swarren@wwwdotorg.org>, Thierry Reding <thierry.reding@gmail.com>, Alexandre Courbot <gnurou@gmail.com>, <linux-clk@vger.kernel.org>, <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on Date: Mon, 6 Mar 2017 16:28:50 +0200 [thread overview] Message-ID: <20170306142850.GJ26640@tbergstrom-lnx.Nvidia.com> (raw) In-Reply-To: <6d4dd315-cab6-189d-f383-fb7523fc31bd@nvidia.com> On Mon, Mar 06, 2017 at 09:58:29AM +0000, Jon Hunter wrote: > > On 06/03/17 08:38, Peter De Schrijver wrote: > > On Thu, Mar 02, 2017 at 05:56:49PM +0000, Jon Hunter wrote: > >> > >> On 28/02/17 15:19, Peter De Schrijver wrote: > >>> This is needed to make the JTAG debugging interface work. > >>> > >>> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com> > >>> --- > >>> drivers/clk/tegra/clk-tegra210.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/clk/tegra/clk-tegra210.c b/drivers/clk/tegra/clk-tegra210.c > >>> index 9a2512a..708f5f1 100644 > >>> --- a/drivers/clk/tegra/clk-tegra210.c > >>> +++ b/drivers/clk/tegra/clk-tegra210.c > >>> @@ -2680,6 +2680,7 @@ static void tegra210_cpu_clock_resume(void) > >>> { TEGRA210_CLK_EMC, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_MSELECT, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_CSITE, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> + { TEGRA210_CLK_DBGAPB, TEGRA210_CLK_CLK_MAX, 0, 1 }, > >>> { TEGRA210_CLK_TSENSOR, TEGRA210_CLK_CLK_M, 400000, 0 }, > >>> { TEGRA210_CLK_I2C1, TEGRA210_CLK_PLL_P, 0, 0 }, > >>> { TEGRA210_CLK_I2C2, TEGRA210_CLK_PLL_P, 0, 0 }, > >> > >> Should there be some dependency on say CONFIG_DEBUG_KERNEL? I am not > >> sure we always want this on for all cases. > > > > Why would you not want it to be always on? > > Purely for power reasons. I do not know how much power keeping this I don't expect it to be significant but I don't have any numbers. > clock running consumes, but I don't like the idea of clocks running all > the time when they are not needed. > Problem is that in this case there is no easy way to determine if the clock needs to be on. Peter.
next prev parent reply other threads:[~2017-03-06 14:28 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-28 15:19 [PATCH] clk: tegra: mark TEGRA210_CLK_DBGAPB as always on Peter De Schrijver 2017-02-28 15:19 ` Peter De Schrijver 2017-03-02 17:56 ` Jon Hunter 2017-03-02 17:56 ` Jon Hunter [not found] ` <4cf40c25-2ce9-737c-9ccb-06bc2cdb61d7-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-03-06 8:38 ` Peter De Schrijver 2017-03-06 8:38 ` Peter De Schrijver 2017-03-06 9:58 ` Jon Hunter 2017-03-06 9:58 ` Jon Hunter 2017-03-06 14:28 ` Peter De Schrijver [this message] 2017-03-06 14:28 ` Peter De Schrijver [not found] ` <20170306142850.GJ26640-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2017-03-06 15:46 ` Jon Hunter 2017-03-06 15:46 ` Jon Hunter 2017-03-06 15:53 ` Geert Uytterhoeven 2017-03-06 15:53 ` Geert Uytterhoeven 2017-03-07 20:27 ` Jon Hunter 2017-03-07 20:27 ` Jon Hunter [not found] ` <598a2a7d-6e01-8884-e839-c758b731605a-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-03-08 8:23 ` Geert Uytterhoeven 2017-03-08 8:23 ` Geert Uytterhoeven 2017-03-08 10:13 ` Jon Hunter 2017-03-08 10:13 ` Jon Hunter 2017-03-08 11:38 ` Geert Uytterhoeven 2017-03-08 11:48 ` Jon Hunter 2017-03-08 11:48 ` Jon Hunter 2017-03-13 10:45 ` Peter De Schrijver 2017-03-13 10:45 ` Peter De Schrijver [not found] ` <20170313104532.GT26640-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org> 2017-03-13 11:03 ` Jon Hunter 2017-03-13 11:03 ` Jon Hunter [not found] ` <9e81c653-b6bb-a47c-8891-d7c7d42a7650-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> 2017-03-13 14:18 ` Peter De Schrijver 2017-03-13 14:18 ` Peter De Schrijver 2017-03-13 10:47 ` Peter De Schrijver 2017-03-13 10:47 ` Peter De Schrijver 2017-03-20 14:18 ` Thierry Reding
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170306142850.GJ26640@tbergstrom-lnx.Nvidia.com \ --to=pdeschrijver@nvidia.com \ --cc=gnurou@gmail.com \ --cc=jonathanh@nvidia.com \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=pgaikwad@nvidia.com \ --cc=sboyd@codeaurora.org \ --cc=swarren@wwwdotorg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.