From: Mark Brown <broonie@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free}
Date: Thu, 9 Mar 2017 12:09:18 +0100 [thread overview]
Message-ID: <20170309110918.getjla6iawgjpfrq@sirena.org.uk> (raw)
In-Reply-To: <20170308231854.50167-1-briannorris@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Wed, Mar 08, 2017 at 03:18:54PM -0800, Brian Norris wrote:
> Not all platform drivers have pcm_{new,free} callbacks. Seen with a
> "snd-soc-dummy" codec from sound/soc/rockchip/rk3399_gru_sound.c.
>
> Resolves an OOPS seen on v4.11-rc1 with Google Kevin (Samsung Chromebook
> Plus):
>
> [ 2.863304] rk3399-gru-sound sound: HiFi <-> ff880000.i2s mapping ok
> [ 2.886930] rk3399-gru-sound sound: rt5514-aif1 <-> ff880000.i2s mapping ok
Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative then it's
usually better to pull out the relevant sections.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free}
Date: Thu, 9 Mar 2017 12:09:18 +0100 [thread overview]
Message-ID: <20170309110918.getjla6iawgjpfrq@sirena.org.uk> (raw)
In-Reply-To: <20170308231854.50167-1-briannorris@chromium.org>
[-- Attachment #1.1: Type: text/plain, Size: 786 bytes --]
On Wed, Mar 08, 2017 at 03:18:54PM -0800, Brian Norris wrote:
> Not all platform drivers have pcm_{new,free} callbacks. Seen with a
> "snd-soc-dummy" codec from sound/soc/rockchip/rk3399_gru_sound.c.
>
> Resolves an OOPS seen on v4.11-rc1 with Google Kevin (Samsung Chromebook
> Plus):
>
> [ 2.863304] rk3399-gru-sound sound: HiFi <-> ff880000.i2s mapping ok
> [ 2.886930] rk3399-gru-sound sound: rt5514-aif1 <-> ff880000.i2s mapping ok
Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative then it's
usually better to pull out the relevant sections.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-03-09 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 23:18 [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-08 23:18 ` Brian Norris
2017-03-09 0:17 ` Kuninori Morimoto
2017-03-09 0:17 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-09 0:21 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-09 0:53 ` Kuninori Morimoto
2017-03-09 0:53 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-11 0:39 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-13 3:46 ` Kuninori Morimoto
2017-03-13 3:46 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-13 21:41 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-14 1:07 ` Kuninori Morimoto
2017-03-14 1:07 ` Kuninori Morimoto
2017-03-09 11:09 ` Mark Brown [this message]
2017-03-09 11:09 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
2017-03-11 0:24 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-13 12:50 ` Mark Brown
2017-03-13 12:50 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
2017-03-13 21:52 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-14 13:36 ` Mark Brown
2017-03-14 13:36 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309110918.getjla6iawgjpfrq@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.