From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Brian Norris <briannorris@chromium.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-kernel@vger.kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>
Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free}
Date: Thu, 9 Mar 2017 00:53:50 +0000 [thread overview]
Message-ID: <87varjz31k.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20170309002129.GA99773@google.com>
Hi Brian
> > It is a littlle bit strange for me.
>
> Yes, and honestly I'm a little confused by the inheritance in this
> framework.
Yes, I agree :)
This is 1st prepare for future ALSA SoC framework cleanup
It is Lars-Peter's idea
> I have a feeling you're checking the wrong thing below for this case.
If so, we should fix this "wrong thing" ?
> All I know is that I'm definitely hitting a NULL
> platform->driver->pcm_new callback, and that either reverting your patch
> or applying the patch I just sent fixes it.
I want to know why this happen.
Can you show me which driver is calling snd_soc_add_platform() in your case ?
WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Brian Norris <briannorris@chromium.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free}
Date: Thu, 9 Mar 2017 00:53:50 +0000 [thread overview]
Message-ID: <87varjz31k.wl%kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <20170309002129.GA99773@google.com>
Hi Brian
> > It is a littlle bit strange for me.
>
> Yes, and honestly I'm a little confused by the inheritance in this
> framework.
Yes, I agree :)
This is 1st prepare for future ALSA SoC framework cleanup
It is Lars-Peter's idea
> I have a feeling you're checking the wrong thing below for this case.
If so, we should fix this "wrong thing" ?
> All I know is that I'm definitely hitting a NULL
> platform->driver->pcm_new callback, and that either reverting your patch
> or applying the patch I just sent fixes it.
I want to know why this happen.
Can you show me which driver is calling snd_soc_add_platform() in your case ?
next prev parent reply other threads:[~2017-03-09 1:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 23:18 [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-08 23:18 ` Brian Norris
2017-03-09 0:17 ` Kuninori Morimoto
2017-03-09 0:17 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-09 0:21 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-09 0:53 ` Kuninori Morimoto [this message]
2017-03-09 0:53 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-11 0:39 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-13 3:46 ` Kuninori Morimoto
2017-03-13 3:46 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Kuninori Morimoto
2017-03-13 21:41 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-14 1:07 ` Kuninori Morimoto
2017-03-14 1:07 ` Kuninori Morimoto
2017-03-09 11:09 ` Mark Brown
2017-03-09 11:09 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
2017-03-11 0:24 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-13 12:50 ` Mark Brown
2017-03-13 12:50 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
2017-03-13 21:52 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new,free} Brian Norris
2017-03-14 13:36 ` Mark Brown
2017-03-14 13:36 ` [PATCH for-4.11] ASoC: don't dereference NULL pcm_{new, free} Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87varjz31k.wl%kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.