From: Andrew Lunn <andrew@lunn.ch> To: sean.wang@mediatek.com Cc: f.fainelli@gmail.com, vivien.didelot@savoirfairelinux.com, matthias.bgg@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, davem@davemloft.net, Landen.Chao@mediatek.com, keyhaede@gmail.com, objelf@gmail.com Subject: Re: [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch Date: Mon, 13 Mar 2017 17:41:18 +0100 [thread overview] Message-ID: <20170313164118.GE3953@lunn.ch> (raw) In-Reply-To: <1489421488-300-5-git-send-email-sean.wang@mediatek.com> Hi Sean Just looking at the GPIO handling at the moment. > + /* Reset whole chip through gpio pin or > + * memory-mapped registers for different > + * type of hardware > + */ > + if (priv->mcm) { > + regmap_update_bits(priv->ethsys, SYSC_REG_RSTCTRL, > + RESET_MCM, RESET_MCM); > + usleep_range(1000, 1100); > + regmap_update_bits(priv->ethsys, SYSC_REG_RSTCTRL, > + RESET_MCM, ~RESET_MCM); > + } else { > + gpio_direction_output(priv->reset, 0); > + usleep_range(1000, 1100); > + gpio_set_value(priv->reset, 1); > + } .... > + /* Not MCM that indicates switch works as the remote standalone > + * integrated circuit so the GPIO pin would be used to complete > + * the reset, otherwise memory-mapped register accessing used > + * through syscon provides in the case of MCM. > + */ > + if (!priv->mcm) { > + priv->reset = of_get_named_gpio(dn, "mediatek,reset-pin", 0); > + if (!gpio_is_valid(priv->reset)) > + return priv->reset; > + > + ret = devm_gpio_request_one(&mdiodev->dev, > + priv->reset, GPIOF_OUT_INIT_LOW, > + "mediatek,reset-pin"); > + if (ret < 0) { > + dev_err(&mdiodev->dev, > + "fail to devm_gpio_request reset\n"); > + return ret; > + } > + } You are not handling the flags part of the GPIO binding. It is better to use devm_gpiod_ API calls, which will handle the active low flags for you. Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> To: sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Landen.Chao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, keyhaede-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, vivien.didelot-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, objelf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org Subject: Re: [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch Date: Mon, 13 Mar 2017 17:41:18 +0100 [thread overview] Message-ID: <20170313164118.GE3953@lunn.ch> (raw) In-Reply-To: <1489421488-300-5-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Hi Sean Just looking at the GPIO handling at the moment. > + /* Reset whole chip through gpio pin or > + * memory-mapped registers for different > + * type of hardware > + */ > + if (priv->mcm) { > + regmap_update_bits(priv->ethsys, SYSC_REG_RSTCTRL, > + RESET_MCM, RESET_MCM); > + usleep_range(1000, 1100); > + regmap_update_bits(priv->ethsys, SYSC_REG_RSTCTRL, > + RESET_MCM, ~RESET_MCM); > + } else { > + gpio_direction_output(priv->reset, 0); > + usleep_range(1000, 1100); > + gpio_set_value(priv->reset, 1); > + } .... > + /* Not MCM that indicates switch works as the remote standalone > + * integrated circuit so the GPIO pin would be used to complete > + * the reset, otherwise memory-mapped register accessing used > + * through syscon provides in the case of MCM. > + */ > + if (!priv->mcm) { > + priv->reset = of_get_named_gpio(dn, "mediatek,reset-pin", 0); > + if (!gpio_is_valid(priv->reset)) > + return priv->reset; > + > + ret = devm_gpio_request_one(&mdiodev->dev, > + priv->reset, GPIOF_OUT_INIT_LOW, > + "mediatek,reset-pin"); > + if (ret < 0) { > + dev_err(&mdiodev->dev, > + "fail to devm_gpio_request reset\n"); > + return ret; > + } > + } You are not handling the flags part of the GPIO binding. It is better to use devm_gpiod_ API calls, which will handle the active low flags for you. Andrew
next prev parent reply other threads:[~2017-03-13 16:41 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-13 16:11 [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support sean.wang 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:11 ` [PATCH net-next 1/4] dt-bindings: net: dsa: add Mediatek MT7530 binding sean.wang 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:36 ` Andrew Lunn 2017-03-13 16:36 ` Andrew Lunn 2017-03-14 6:06 ` Sean Wang 2017-03-14 6:06 ` Sean Wang 2017-03-14 6:06 ` Sean Wang 2017-03-13 16:47 ` Florian Fainelli 2017-03-13 16:47 ` Florian Fainelli 2017-03-14 6:52 ` Sean Wang 2017-03-14 6:52 ` Sean Wang 2017-03-14 11:58 ` Andrew Lunn 2017-03-14 11:58 ` Andrew Lunn 2017-03-13 16:11 ` [PATCH net-next 2/4] net-next: dsa: add Mediatek tag RX/TX handler sean.wang 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:27 ` Andrew Lunn 2017-03-13 16:27 ` Andrew Lunn 2017-03-13 16:35 ` Florian Fainelli 2017-03-13 16:35 ` Florian Fainelli 2017-03-14 6:16 ` Sean Wang 2017-03-14 6:16 ` Sean Wang 2017-03-13 16:59 ` Vivien Didelot 2017-03-13 16:59 ` Vivien Didelot 2017-03-14 6:22 ` Sean Wang 2017-03-14 6:22 ` Sean Wang 2017-03-14 13:38 ` Vivien Didelot 2017-03-14 13:38 ` Vivien Didelot 2017-03-13 16:11 ` [PATCH net-next 3/4] net-next: ethernet: mediatek: add CDM able to recognize the tag for DSA sean.wang 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:11 ` sean.wang-NuS5LvNUpcJWk0Htik3J/w 2017-03-13 16:30 ` Andrew Lunn 2017-03-13 16:39 ` Florian Fainelli 2017-03-13 16:11 ` [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch sean.wang 2017-03-13 16:11 ` sean.wang 2017-03-13 16:41 ` Andrew Lunn [this message] 2017-03-13 16:41 ` Andrew Lunn 2017-03-13 23:11 ` Andrew Lunn 2017-03-13 23:11 ` Andrew Lunn 2017-03-14 7:03 ` Sean Wang 2017-03-14 7:03 ` Sean Wang 2017-03-14 7:03 ` Sean Wang 2017-03-15 2:20 ` kbuild test robot 2017-03-15 2:20 ` kbuild test robot 2017-03-15 2:20 ` kbuild test robot 2017-03-15 2:30 ` kbuild test robot 2017-03-15 2:30 ` kbuild test robot 2017-03-13 16:25 ` [PATCH net-next 0/4] net-next: dsa: add Mediatek MT7530 support John Crispin 2017-03-13 16:25 ` John Crispin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170313164118.GE3953@lunn.ch \ --to=andrew@lunn.ch \ --cc=Landen.Chao@mediatek.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=keyhaede@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=objelf@gmail.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=vivien.didelot@savoirfairelinux.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.