* [PATCH v2] r5cache: allow adding journal to array without journal
@ 2017-03-14 0:11 Song Liu
2017-03-14 16:56 ` Shaohua Li
0 siblings, 1 reply; 2+ messages in thread
From: Song Liu @ 2017-03-14 0:11 UTC (permalink / raw)
To: linux-raid
Cc: shli, neilb, kernel-team, dan.j.williams, hch, jsorensen, Song Liu
This seems just work.
Signed-off-by: Song Liu <songliubraving@fb.com>
---
Manage.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/Manage.c b/Manage.c
index 5c3d2b9..5ff5de3 100644
--- a/Manage.c
+++ b/Manage.c
@@ -946,7 +946,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
/* only add journal to array that supports journaling */
if (dv->disposition == 'j') {
- struct mdinfo mdi;
struct mdinfo *mdp;
mdp = sysfs_read(fd, NULL, GET_ARRAY_STATE);
@@ -963,11 +962,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
sysfs_free(mdp);
- tst->ss->getinfo_super(tst, &mdi, NULL);
- if (mdi.journal_device_required == 0) {
- pr_err("%s does not support journal device.\n", devname);
- return -1;
- }
disc.raid_disk = 0;
}
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] r5cache: allow adding journal to array without journal
2017-03-14 0:11 [PATCH v2] r5cache: allow adding journal to array without journal Song Liu
@ 2017-03-14 16:56 ` Shaohua Li
0 siblings, 0 replies; 2+ messages in thread
From: Shaohua Li @ 2017-03-14 16:56 UTC (permalink / raw)
To: Song Liu
Cc: linux-raid, shli, neilb, kernel-team, dan.j.williams, hch, jsorensen
On Mon, Mar 13, 2017 at 05:11:38PM -0700, Song Liu wrote:
> This seems just work.
this is by no means a changelog :)
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> Manage.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/Manage.c b/Manage.c
> index 5c3d2b9..5ff5de3 100644
> --- a/Manage.c
> +++ b/Manage.c
> @@ -946,7 +946,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
>
> /* only add journal to array that supports journaling */
> if (dv->disposition == 'j') {
> - struct mdinfo mdi;
> struct mdinfo *mdp;
>
> mdp = sysfs_read(fd, NULL, GET_ARRAY_STATE);
> @@ -963,11 +962,6 @@ int Manage_add(int fd, int tfd, struct mddev_dev *dv,
>
> sysfs_free(mdp);
>
> - tst->ss->getinfo_super(tst, &mdi, NULL);
> - if (mdi.journal_device_required == 0) {
> - pr_err("%s does not support journal device.\n", devname);
> - return -1;
> - }
> disc.raid_disk = 0;
> }
>
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-14 16:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 0:11 [PATCH v2] r5cache: allow adding journal to array without journal Song Liu
2017-03-14 16:56 ` Shaohua Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.