* [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED
@ 2017-03-14 0:52 Tony Lindgren
2017-03-14 8:38 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Tony Lindgren @ 2017-03-14 0:52 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel
Shared interrupts can be registered with handle_nested_irq(), but
currently only one of the registered handlers gets called.
The use of shared interrupts with handle_nested_irq() is probably rare,
but at least a case of a shared VBUS interrupt between USB PHY and
battery charger drivers for a PMIC makes sense.
Typically for_each_action_of_desc() gets called via handle_irq_event()
at _handle_irq_event_percpu(), but handle_nested_irq() is different
because of it's dummy irq_nested_primary_handler().
Let's fix the issue by calling the handler for all the entries in
the action list.
Fixes: 399b5da29b9f ("genirq: Support nested threaded irq handling")
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
kernel/irq/chip.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -348,9 +348,11 @@ void handle_nested_irq(unsigned int irq)
irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
raw_spin_unlock_irq(&desc->lock);
- action_ret = action->thread_fn(action->irq, action->dev_id);
- if (!noirqdebug)
- note_interrupt(desc, action_ret);
+ for_each_action_of_desc(desc, action) {
+ action_ret = action->thread_fn(action->irq, action->dev_id);
+ if (!noirqdebug)
+ note_interrupt(desc, action_ret);
+ }
raw_spin_lock_irq(&desc->lock);
irqd_clear(&desc->irq_data, IRQD_IRQ_INPROGRESS);
--
2.11.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED
2017-03-14 0:52 [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED Tony Lindgren
@ 2017-03-14 8:38 ` Thomas Gleixner
2017-03-14 14:48 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2017-03-14 8:38 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-kernel
On Mon, 13 Mar 2017, Tony Lindgren wrote:
> Shared interrupts can be registered with handle_nested_irq(), but
> currently only one of the registered handlers gets called.
>
> The use of shared interrupts with handle_nested_irq() is probably rare,
> but at least a case of a shared VBUS interrupt between USB PHY and
> battery charger drivers for a PMIC makes sense.
>
> Typically for_each_action_of_desc() gets called via handle_irq_event()
> at _handle_irq_event_percpu(), but handle_nested_irq() is different
> because of it's dummy irq_nested_primary_handler().
>
> Let's fix the issue by calling the handler for all the entries in
> the action list.
>
> Fixes: 399b5da29b9f ("genirq: Support nested threaded irq handling")
It's not a fix, it's an extension. The nested facility was not meant to
handle shared interrupts in the first place. I really hope that hardware
folks finally understand that irq sharing is crap and broken...
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> kernel/irq/chip.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> --- a/kernel/irq/chip.c
> +++ b/kernel/irq/chip.c
> @@ -348,9 +348,11 @@ void handle_nested_irq(unsigned int irq)
> irqd_set(&desc->irq_data, IRQD_IRQ_INPROGRESS);
> raw_spin_unlock_irq(&desc->lock);
>
> - action_ret = action->thread_fn(action->irq, action->dev_id);
> - if (!noirqdebug)
> - note_interrupt(desc, action_ret);
> + for_each_action_of_desc(desc, action) {
> + action_ret = action->thread_fn(action->irq, action->dev_id);
> + if (!noirqdebug)
> + note_interrupt(desc, action_ret);
This is wrong. See how __handle_irq_event_percpu() does this. But no need
to resend. See:
http://lkml.kernel.org/r/1488904098-5350-1-git-send-email-ckeepax@opensource.wolfsonmicro.com
Thanks,
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED
2017-03-14 8:38 ` Thomas Gleixner
@ 2017-03-14 14:48 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2017-03-14 14:48 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: linux-kernel
* Thomas Gleixner <tglx@linutronix.de> [170314 01:40]:
> On Mon, 13 Mar 2017, Tony Lindgren wrote:
>
> > Shared interrupts can be registered with handle_nested_irq(), but
> > currently only one of the registered handlers gets called.
> >
> > The use of shared interrupts with handle_nested_irq() is probably rare,
> > but at least a case of a shared VBUS interrupt between USB PHY and
> > battery charger drivers for a PMIC makes sense.
> >
> > Typically for_each_action_of_desc() gets called via handle_irq_event()
> > at _handle_irq_event_percpu(), but handle_nested_irq() is different
> > because of it's dummy irq_nested_primary_handler().
> >
> > Let's fix the issue by calling the handler for all the entries in
> > the action list.
> >
> > Fixes: 399b5da29b9f ("genirq: Support nested threaded irq handling")
>
> It's not a fix, it's an extension. The nested facility was not meant to
> handle shared interrupts in the first place. I really hope that hardware
> folks finally understand that irq sharing is crap and broken...
Yes totally.
> > + for_each_action_of_desc(desc, action) {
> > + action_ret = action->thread_fn(action->irq, action->dev_id);
> > + if (!noirqdebug)
> > + note_interrupt(desc, action_ret);
>
> This is wrong. See how __handle_irq_event_percpu() does this. But no need
> to resend. See:
>
> http://lkml.kernel.org/r/1488904098-5350-1-git-send-email-ckeepax@opensource.wolfsonmicro.com
Oh OK yeah makes sense, my patch is overwriting action_ret..
Thanks,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-14 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-14 0:52 [PATCH] genirq: Fix handle_nested_irq() for IRQF_SHARED Tony Lindgren
2017-03-14 8:38 ` Thomas Gleixner
2017-03-14 14:48 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.