All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Matthew Wilcox <willy@linux.intel.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear'
Date: Tue, 14 Mar 2017 08:56:34 +0800	[thread overview]
Message-ID: <20170314005634.27c5uggi3zb6i6z5@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com>

Hi Dave,

On Mon, Mar 13, 2017 at 08:57:54AM -0700, Dave Jiang wrote:
>Fengguang,
>I don't believe Andrew has picked up this patch yet:
>http://marc.info/?l=linux-mm&m=148883870428812&w=2
>
>Unless you are seeing issues with that patch.

It looks the patch is not in mainline or linux-next yet:

% git show linus/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT
}

#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
                defined(CONFIG_PARAVIRT))
static inline void native_pud_clear(pud_t *pudp)
{
}

% git show linux-next/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT
}

#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
                defined(CONFIG_PARAVIRT))
static inline void native_pud_clear(pud_t *pudp)
{
}

Thanks,
Fengguang

>On 03/11/2017 03:55 PM, kbuild test robot wrote:
>> Hi Matthew,
>>
>> FYI, the error/warning still remains.
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   84c37c168c0e49a412d7021cda3183a72adac0d0
>> commit: a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 mm, x86: add support for PUD-sized transparent hugepages
>> date:   2 weeks ago
>> config: i386-randconfig-a0-201711 (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>>         git checkout a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517
>>         # save the attached .config to linux build tree
>>         make ARCH=i386
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/mm.h:68:0,
>>                     from include/linux/suspend.h:8,
>>                     from arch/x86/kernel/asm-offsets.c:12:
>>    arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear':
>>>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration]
>>      native_pud_clear(pudp);
>>      ^~~~~~~~~~~~~~~~
>>    cc1: some warnings being treated as errors
>>    make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
>>    make[2]: Target '__build' not remade because of errors.
>>    make[1]: *** [prepare0] Error 2
>>    make[1]: Target 'prepare' not remade because of errors.
>>    make: *** [sub-make] Error 2
>>
>> vim +/native_pud_clear +888 arch/x86/include/asm/pgtable.h
>>
>>    882	}
>>    883	
>>    884	static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp)
>>    885	{
>>    886		pud_t res = *pudp;
>>    887	
>>  > 888		native_pud_clear(pudp);
>>    889		return res;
>>    890	}
>>    891	
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>

WARNING: multiple messages have this Message-ID (diff)
From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Matthew Wilcox <willy@linux.intel.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear'
Date: Tue, 14 Mar 2017 08:56:34 +0800	[thread overview]
Message-ID: <20170314005634.27c5uggi3zb6i6z5@wfg-t540p.sh.intel.com> (raw)
In-Reply-To: <9d16b438-0b64-2292-7de3-1b8daebe621e@intel.com>

Hi Dave,

On Mon, Mar 13, 2017 at 08:57:54AM -0700, Dave Jiang wrote:
>Fengguang,
>I don't believe Andrew has picked up this patch yet:
>http://marc.info/?l=linux-mm&m=148883870428812&w=2
>
>Unless you are seeing issues with that patch.

It looks the patch is not in mainline or linux-next yet:

% git show linus/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT
}

#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
                defined(CONFIG_PARAVIRT))
static inline void native_pud_clear(pud_t *pudp)
{
}

% git show linux-next/master:arch/x86/include/asm/pgtable-3level.h |grep -C3 CONFIG_PARAVIRT
}

#if !defined(CONFIG_SMP) || (defined(CONFIG_HIGHMEM64G) && \
                defined(CONFIG_PARAVIRT))
static inline void native_pud_clear(pud_t *pudp)
{
}

Thanks,
Fengguang

>On 03/11/2017 03:55 PM, kbuild test robot wrote:
>> Hi Matthew,
>>
>> FYI, the error/warning still remains.
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head:   84c37c168c0e49a412d7021cda3183a72adac0d0
>> commit: a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517 mm, x86: add support for PUD-sized transparent hugepages
>> date:   2 weeks ago
>> config: i386-randconfig-a0-201711 (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>>         git checkout a00cc7d9dd93d66a3fb83fc52aa57a4bec51c517
>>         # save the attached .config to linux build tree
>>         make ARCH=i386
>>
>> All errors (new ones prefixed by >>):
>>
>>    In file included from include/linux/mm.h:68:0,
>>                     from include/linux/suspend.h:8,
>>                     from arch/x86/kernel/asm-offsets.c:12:
>>    arch/x86/include/asm/pgtable.h: In function 'native_local_pudp_get_and_clear':
>>>> arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' [-Werror=implicit-function-declaration]
>>      native_pud_clear(pudp);
>>      ^~~~~~~~~~~~~~~~
>>    cc1: some warnings being treated as errors
>>    make[2]: *** [arch/x86/kernel/asm-offsets.s] Error 1
>>    make[2]: Target '__build' not remade because of errors.
>>    make[1]: *** [prepare0] Error 2
>>    make[1]: Target 'prepare' not remade because of errors.
>>    make: *** [sub-make] Error 2
>>
>> vim +/native_pud_clear +888 arch/x86/include/asm/pgtable.h
>>
>>    882	}
>>    883	
>>    884	static inline pud_t native_local_pudp_get_and_clear(pud_t *pudp)
>>    885	{
>>    886		pud_t res = *pudp;
>>    887	
>>  > 888		native_pud_clear(pudp);
>>    889		return res;
>>    890	}
>>    891	
>>
>> ---
>> 0-DAY kernel test infrastructure                Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
>>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-03-14  0:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 22:55 arch/x86/include/asm/pgtable.h:888:2: error: implicit declaration of function 'native_pud_clear' kbuild test robot
2017-03-13 15:57 ` Dave Jiang
2017-03-13 15:57   ` Dave Jiang
2017-03-14  0:56   ` Fengguang Wu [this message]
2017-03-14  0:56     ` Fengguang Wu
  -- strict thread matches above, loose matches on Subject: below --
2017-03-04 23:02 kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170314005634.27c5uggi3zb6i6z5@wfg-t540p.sh.intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.jiang@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.