[PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

[PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

[Borislav Petkov]

From: Borislav Petkov <bp@suse.de>

It is a debugging statement so make it be issued only then.

No functionality change.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Lee Jones <lee.jones@linaro.org>
---
 drivers/mfd/rtsx_pcr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index 98029ee0959e..850590aac008 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
 
 static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
 {
-	dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
+	pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
 			__func__, pcr->msi_en, pcr->pci->irq);
 
 	if (request_irq(pcr->pci->irq, rtsx_pci_isr,
-- 
2.11.0

Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

[Lee Jones]

On Thu, 02 Feb 2017, Borislav Petkov wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> It is a debugging statement so make it be issued only then.
> 
> No functionality change.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/rtsx_pcr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 98029ee0959e..850590aac008 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
>  
>  static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
>  {
> -	dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
> +	pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
>  			__func__, pcr->msi_en, pcr->pci->irq);

I usually disapprove of these kinds of abstractions.

What is the point of it?

Why can't you just use dev_dbg()?

>  	if (request_irq(pcr->pci->irq, rtsx_pci_isr,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

[Borislav Petkov]

On Wed, Feb 08, 2017 at 12:02:22PM +0000, Lee Jones wrote:
> I usually disapprove of these kinds of abstractions.
> 
> What is the point of it?
> 
> Why can't you just use dev_dbg()?

I was simply following what the rest of the driver does. It has 20
pcr_dbg() calls and 5 dev_dbg().

If you want to address that, then a patch ontop should convert all
pcr_dbg() calls to dev_dbg().

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to pcr_dbg()

[Lee Jones]

On Thu, 02 Feb 2017, Borislav Petkov wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> It is a debugging statement so make it be issued only then.
> 
> No functionality change.
> 
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/rtsx_pcr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 98029ee0959e..850590aac008 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -927,7 +927,7 @@ static irqreturn_t rtsx_pci_isr(int irq, void *dev_id)
>  
>  static int rtsx_pci_acquire_irq(struct rtsx_pcr *pcr)
>  {
> -	dev_info(&(pcr->pci->dev), "%s: pcr->msi_en = %d, pci->irq = %d\n",
> +	pcr_dbg(pcr, "%s: pcr->msi_en = %d, pci->irq = %d\n",
>  			__func__, pcr->msi_en, pcr->pci->irq);
>  
>  	if (request_irq(pcr->pci->irq, rtsx_pci_isr,

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog