From: Greg Kurz <groug@kaod.org> To: Stefano Stabellini <sstabellini@kernel.org> Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, anthony.perard@citrix.com, Stefano Stabellini <stefano@aporeto.com>, jgross@suse.com, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 6/9] xen/9pfs: receive requests from the frontend Date: Wed, 15 Mar 2017 11:51:40 +0100 [thread overview] Message-ID: <20170315115140.21e746d3@bahia.lab.toulouse-stg.fr.ibm.com> (raw) In-Reply-To: <1489449360-14411-6-git-send-email-sstabellini@kernel.org> [-- Attachment #1: Type: text/plain, Size: 2807 bytes --] On Mon, 13 Mar 2017 16:55:57 -0700 Stefano Stabellini <sstabellini@kernel.org> wrote: > Upon receiving an event channel notification from the frontend, schedule > the bottom half. From the bottom half, read one request from the ring, > create a pdu and call pdu_submit to handle it. > > For now, only handle one request per ring at a time. > > Signed-off-by: Stefano Stabellini <stefano@aporeto.com> > CC: anthony.perard@citrix.com > CC: jgross@suse.com > CC: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > CC: Greg Kurz <groug@kaod.org> > --- > hw/9pfs/xen-9p-backend.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c > index 0e4a133..741dd31 100644 > --- a/hw/9pfs/xen-9p-backend.c > +++ b/hw/9pfs/xen-9p-backend.c > @@ -94,12 +94,59 @@ static int xen_9pfs_init(struct XenDevice *xendev) > return 0; > } > > +static int xen_9pfs_receive(struct Xen9pfsRing *ring) Coding style for structured types. > +{ > + struct xen_9pfs_header h; > + RING_IDX cons, prod, masked_prod, masked_cons; > + V9fsPDU *pdu; > + > + if (ring->inprogress) { > + return 0; > + } > + > + cons = ring->intf->out_cons; > + prod = ring->intf->out_prod; > + xen_rmb(); > + > + if (xen_9pfs_queued(prod, cons, XEN_9PFS_RING_SIZE) < sizeof(h)) { > + return 0; > + } > + ring->inprogress = true; > + > + masked_prod = xen_9pfs_mask(prod, XEN_9PFS_RING_SIZE); > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + > + xen_9pfs_read_packet(ring->ring.out, masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, (uint8_t*) &h, sizeof(h)); > + > + pdu = pdu_alloc(&ring->priv->state); pdu_alloc() can theoretically return NULL. Maybe add a comment to indicate this won't happen because "for now [we] only handle one request per ring at a time". > + pdu->size = h.size; > + pdu->id = h.id; > + pdu->tag = h.tag; > + ring->out_size = h.size; > + ring->out_cons = cons + h.size; > + > + qemu_co_queue_init(&pdu->complete); > + pdu_submit(pdu); > + > + return 0; > +} > + > static void xen_9pfs_bh(void *opaque) > { > + struct Xen9pfsRing *ring = opaque; Coding style for structured types. > + xen_9pfs_receive(ring); > } > > static void xen_9pfs_evtchn_event(void *opaque) > { > + struct Xen9pfsRing *ring = opaque; Coding style for structured types. > + evtchn_port_t port; > + > + port = xenevtchn_pending(ring->evtchndev); > + xenevtchn_unmask(ring->evtchndev, port); > + > + qemu_bh_schedule(ring->bh); > } > > static int xen_9pfs_free(struct XenDevice *xendev) [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kurz <groug@kaod.org> To: Stefano Stabellini <sstabellini@kernel.org> Cc: jgross@suse.com, qemu-devel@nongnu.org, Stefano Stabellini <stefano@aporeto.com>, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>, anthony.perard@citrix.com, xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 6/9] xen/9pfs: receive requests from the frontend Date: Wed, 15 Mar 2017 11:51:40 +0100 [thread overview] Message-ID: <20170315115140.21e746d3@bahia.lab.toulouse-stg.fr.ibm.com> (raw) In-Reply-To: <1489449360-14411-6-git-send-email-sstabellini@kernel.org> [-- Attachment #1.1: Type: text/plain, Size: 2807 bytes --] On Mon, 13 Mar 2017 16:55:57 -0700 Stefano Stabellini <sstabellini@kernel.org> wrote: > Upon receiving an event channel notification from the frontend, schedule > the bottom half. From the bottom half, read one request from the ring, > create a pdu and call pdu_submit to handle it. > > For now, only handle one request per ring at a time. > > Signed-off-by: Stefano Stabellini <stefano@aporeto.com> > CC: anthony.perard@citrix.com > CC: jgross@suse.com > CC: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > CC: Greg Kurz <groug@kaod.org> > --- > hw/9pfs/xen-9p-backend.c | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > > diff --git a/hw/9pfs/xen-9p-backend.c b/hw/9pfs/xen-9p-backend.c > index 0e4a133..741dd31 100644 > --- a/hw/9pfs/xen-9p-backend.c > +++ b/hw/9pfs/xen-9p-backend.c > @@ -94,12 +94,59 @@ static int xen_9pfs_init(struct XenDevice *xendev) > return 0; > } > > +static int xen_9pfs_receive(struct Xen9pfsRing *ring) Coding style for structured types. > +{ > + struct xen_9pfs_header h; > + RING_IDX cons, prod, masked_prod, masked_cons; > + V9fsPDU *pdu; > + > + if (ring->inprogress) { > + return 0; > + } > + > + cons = ring->intf->out_cons; > + prod = ring->intf->out_prod; > + xen_rmb(); > + > + if (xen_9pfs_queued(prod, cons, XEN_9PFS_RING_SIZE) < sizeof(h)) { > + return 0; > + } > + ring->inprogress = true; > + > + masked_prod = xen_9pfs_mask(prod, XEN_9PFS_RING_SIZE); > + masked_cons = xen_9pfs_mask(cons, XEN_9PFS_RING_SIZE); > + > + xen_9pfs_read_packet(ring->ring.out, masked_prod, &masked_cons, > + XEN_9PFS_RING_SIZE, (uint8_t*) &h, sizeof(h)); > + > + pdu = pdu_alloc(&ring->priv->state); pdu_alloc() can theoretically return NULL. Maybe add a comment to indicate this won't happen because "for now [we] only handle one request per ring at a time". > + pdu->size = h.size; > + pdu->id = h.id; > + pdu->tag = h.tag; > + ring->out_size = h.size; > + ring->out_cons = cons + h.size; > + > + qemu_co_queue_init(&pdu->complete); > + pdu_submit(pdu); > + > + return 0; > +} > + > static void xen_9pfs_bh(void *opaque) > { > + struct Xen9pfsRing *ring = opaque; Coding style for structured types. > + xen_9pfs_receive(ring); > } > > static void xen_9pfs_evtchn_event(void *opaque) > { > + struct Xen9pfsRing *ring = opaque; Coding style for structured types. > + evtchn_port_t port; > + > + port = xenevtchn_pending(ring->evtchndev); > + xenevtchn_unmask(ring->evtchndev, port); > + > + qemu_bh_schedule(ring->bh); > } > > static int xen_9pfs_free(struct XenDevice *xendev) [-- Attachment #1.2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] [-- Attachment #2: Type: text/plain, Size: 127 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-15 10:51 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-13 23:55 [Qemu-devel] [PATCH v2 0/9] xen/9pfs: introduce the Xen 9pfs backend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 2/9] xen: import ring.h from xen Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 8:00 ` [Qemu-devel] " Greg Kurz 2017-03-15 8:00 ` Greg Kurz 2017-03-15 18:36 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 18:36 ` Stefano Stabellini 2017-03-15 19:00 ` [Qemu-devel] " Greg Kurz 2017-03-15 19:00 ` Greg Kurz 2017-03-15 19:04 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 19:04 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 3/9] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 9:06 ` [Qemu-devel] " Greg Kurz 2017-03-15 9:06 ` Greg Kurz 2017-03-15 19:02 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 19:02 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 4/9] xen/9pfs: introduce Xen 9pfs backend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-14 7:11 ` [Qemu-devel] " Juergen Gross 2017-03-14 7:11 ` Juergen Gross 2017-03-14 20:07 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:07 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 5/9] xen/9pfs: connect to the frontend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-14 7:17 ` [Qemu-devel] " Juergen Gross 2017-03-14 7:17 ` Juergen Gross 2017-03-14 20:14 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:14 ` Stefano Stabellini 2017-03-15 9:48 ` [Qemu-devel] " Greg Kurz 2017-03-15 9:48 ` Greg Kurz 2017-03-15 21:30 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:30 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 6/9] xen/9pfs: receive requests from " Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:51 ` Greg Kurz [this message] 2017-03-15 10:51 ` Greg Kurz 2017-03-15 21:56 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:56 ` Stefano Stabellini 2017-03-15 11:53 ` Greg Kurz 2017-03-15 11:53 ` Greg Kurz 2017-03-15 22:03 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 22:03 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 7/9] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:58 ` [Qemu-devel] " Greg Kurz 2017-03-15 10:58 ` Greg Kurz 2017-03-15 21:58 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:58 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 8/9] xen/9pfs: send responses back to the frontend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:59 ` [Qemu-devel] " Greg Kurz 2017-03-15 10:59 ` Greg Kurz 2017-03-15 21:59 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:59 ` Stefano Stabellini 2017-03-13 23:56 ` [Qemu-devel] [PATCH v2 9/9] xen/9pfs: build and register Xen 9pfs backend Stefano Stabellini 2017-03-13 23:56 ` Stefano Stabellini 2017-03-14 10:02 ` [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Paolo Bonzini 2017-03-14 10:02 ` Paolo Bonzini 2017-03-14 19:07 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 19:07 ` Stefano Stabellini 2017-03-14 20:23 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:23 ` Stefano Stabellini 2017-03-15 1:03 ` [Qemu-devel] " Greg Kurz 2017-03-15 1:03 ` Greg Kurz 2017-03-15 7:41 ` [Qemu-devel] " Paolo Bonzini 2017-03-15 7:41 ` Paolo Bonzini 2017-03-15 18:42 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 18:42 ` Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170315115140.21e746d3@bahia.lab.toulouse-stg.fr.ibm.com \ --to=groug@kaod.org \ --cc=aneesh.kumar@linux.vnet.ibm.com \ --cc=anthony.perard@citrix.com \ --cc=jgross@suse.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=stefano@aporeto.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.