* [PATCH] dt-bindings: rng: clocks property on omap_rng is optional
@ 2017-03-07 14:18 Thomas Petazzoni
[not found] ` <1488896308-17731-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-03-07 14:18 UTC (permalink / raw)
To: devicetree, Rob Herring, Ian Campbell, Pawel Moll, Mark Rutland,
Kumar Gala, Deepak Saxena, Matt Mackall, Herbert Xu
Cc: linux-crypto, romain.perier, Jason Cooper, Andrew Lunn,
Sebastian Hesselbarth, Gregory Clement, Nadav Haklai, Hanna Hawa,
Yehuda Yitschak, Thomas Petazzoni, stable
Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76
device variant") update the omap_rng Device Tree binding to add support
for the IP-76 variation of the IP. As part of this change, a "clocks"
property was added, but is indicated as "Required", while it is in fact
"Optional": some SoCs do not require a clock for this IP block.
Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Documentation/devicetree/bindings/rng/omap_rng.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt
index 4714772..20d435da 100644
--- a/Documentation/devicetree/bindings/rng/omap_rng.txt
+++ b/Documentation/devicetree/bindings/rng/omap_rng.txt
@@ -12,6 +12,9 @@ Required properties:
- reg : Offset and length of the register set for the module
- interrupts : the interrupt number for the RNG module.
Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76"
+
+Optional properties:
+
- clocks: the trng clock source
Example:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread[parent not found: <1488896308-17731-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional 2017-03-07 14:18 [PATCH] dt-bindings: rng: clocks property on omap_rng is optional Thomas Petazzoni @ 2017-03-15 17:57 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2017-03-15 17:57 UTC (permalink / raw) To: Thomas Petazzoni Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, Deepak Saxena, Matt Mackall, Herbert Xu, linux-crypto-u79uwXL29TY76Z2rM5mHXA, romain.perier-ZGY8ohtN/8qB+jHODAdFcQ, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Nadav Haklai, Hanna Hawa, Yehuda Yitschak, stable-u79uwXL29TY76Z2rM5mHXA On Tue, Mar 07, 2017 at 03:18:28PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was added, but is indicated as "Required", while it is in fact > "Optional": some SoCs do not require a clock for this IP block. > > Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant") > Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> > --- > Documentation/devicetree/bindings/rng/omap_rng.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > index 4714772..20d435da 100644 > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > @@ -12,6 +12,9 @@ Required properties: > - reg : Offset and length of the register set for the module > - interrupts : the interrupt number for the RNG module. > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > + > +Optional properties: > + Wouldn't just "for ? compatible only" be more correct? > - clocks: the trng clock source > > Example: > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional @ 2017-03-15 17:57 ` Rob Herring 0 siblings, 0 replies; 5+ messages in thread From: Rob Herring @ 2017-03-15 17:57 UTC (permalink / raw) To: Thomas Petazzoni Cc: devicetree, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, Deepak Saxena, Matt Mackall, Herbert Xu, linux-crypto, romain.perier, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Nadav Haklai, Hanna Hawa, Yehuda Yitschak, stable On Tue, Mar 07, 2017 at 03:18:28PM +0100, Thomas Petazzoni wrote: > Commit 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 > device variant") update the omap_rng Device Tree binding to add support > for the IP-76 variation of the IP. As part of this change, a "clocks" > property was added, but is indicated as "Required", while it is in fact > "Optional": some SoCs do not require a clock for this IP block. > > Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant") > Cc: <stable@vger.kernel.org> > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > Documentation/devicetree/bindings/rng/omap_rng.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > index 4714772..20d435da 100644 > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > @@ -12,6 +12,9 @@ Required properties: > - reg : Offset and length of the register set for the module > - interrupts : the interrupt number for the RNG module. > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > + > +Optional properties: > + Wouldn't just "for ? compatible only" be more correct? > - clocks: the trng clock source > > Example: > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional 2017-03-15 17:57 ` Rob Herring @ 2017-03-17 12:57 ` Thomas Petazzoni -1 siblings, 0 replies; 5+ messages in thread From: Thomas Petazzoni @ 2017-03-17 12:57 UTC (permalink / raw) To: Rob Herring Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, Deepak Saxena, Matt Mackall, Herbert Xu, linux-crypto-u79uwXL29TY76Z2rM5mHXA, romain.perier-ZGY8ohtN/8qB+jHODAdFcQ, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Nadav Haklai, Hanna Hawa, Yehuda Yitschak, stable-u79uwXL29TY76Z2rM5mHXA Hello, On Wed, 15 Mar 2017 12:57:37 -0500, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > > index 4714772..20d435da 100644 > > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > > @@ -12,6 +12,9 @@ Required properties: > > - reg : Offset and length of the register set for the module > > - interrupts : the interrupt number for the RNG module. > > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > > + > > +Optional properties: > > + > > Wouldn't just "for ? compatible only" be more correct? I don't know if at the HW point of view the EIP76 will *always* need a clock. Maybe it depends on the integration in the SoC. But anyway, let's mark the clocks property as mandatory for "inside-secure,safexcel-eip76" for the moment, we can always relax this requirement later on if we realize that some EIP76 have been integrated in a way that doesn't require a clock. It is worth mentioning that the actual driver implementation simply makes the clock optional in all cases, without looking at the compatible to figure out if the clock must be there or not. But that's just the current driver implementation. The Device Tree binding specification can be more specific than what the current driver does. Therefore: v2 coming. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional @ 2017-03-17 12:57 ` Thomas Petazzoni 0 siblings, 0 replies; 5+ messages in thread From: Thomas Petazzoni @ 2017-03-17 12:57 UTC (permalink / raw) To: Rob Herring Cc: devicetree, Ian Campbell, Pawel Moll, Mark Rutland, Kumar Gala, Deepak Saxena, Matt Mackall, Herbert Xu, linux-crypto, romain.perier, Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Gregory Clement, Nadav Haklai, Hanna Hawa, Yehuda Yitschak, stable Hello, On Wed, 15 Mar 2017 12:57:37 -0500, Rob Herring wrote: > > diff --git a/Documentation/devicetree/bindings/rng/omap_rng.txt b/Documentation/devicetree/bindings/rng/omap_rng.txt > > index 4714772..20d435da 100644 > > --- a/Documentation/devicetree/bindings/rng/omap_rng.txt > > +++ b/Documentation/devicetree/bindings/rng/omap_rng.txt > > @@ -12,6 +12,9 @@ Required properties: > > - reg : Offset and length of the register set for the module > > - interrupts : the interrupt number for the RNG module. > > Used for "ti,omap4-rng" and "inside-secure,safexcel-eip76" > > + > > +Optional properties: > > + > > Wouldn't just "for ? compatible only" be more correct? I don't know if at the HW point of view the EIP76 will *always* need a clock. Maybe it depends on the integration in the SoC. But anyway, let's mark the clocks property as mandatory for "inside-secure,safexcel-eip76" for the moment, we can always relax this requirement later on if we realize that some EIP76 have been integrated in a way that doesn't require a clock. It is worth mentioning that the actual driver implementation simply makes the clock optional in all cases, without looking at the compatible to figure out if the clock must be there or not. But that's just the current driver implementation. The Device Tree binding specification can be more specific than what the current driver does. Therefore: v2 coming. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-17 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-07 14:18 [PATCH] dt-bindings: rng: clocks property on omap_rng is optional Thomas Petazzoni
[not found] ` <1488896308-17731-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-03-15 17:57 ` Rob Herring
2017-03-15 17:57 ` Rob Herring
2017-03-17 12:57 ` Thomas Petazzoni
2017-03-17 12:57 ` Thomas Petazzoni
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.