From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Lee Jones <lee.jones@linaro.org> Cc: robh+dt@kernel.org, mark.rutland@arm.com, linus.walleij@linaro.org, gnurou@gmail.com, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Date: Fri, 17 Mar 2017 09:25:20 +0000 [thread overview] Message-ID: <20170317092520.GM6986@localhost.localdomain> (raw) In-Reply-To: <20170317091502.kzcrhj7vlku5mtq7@dell> On Fri, Mar 17, 2017 at 09:15:02AM +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Charles Keepax wrote: > > > On Thu, Mar 16, 2017 at 02:00:19PM +0000, Lee Jones wrote: > > > On Wed, 15 Mar 2017, Charles Keepax wrote: > > > > + if (i2c->dev.of_node) { > > > > + const struct of_device_id *id = of_match_device(wm831x_of_match, > > > > + &i2c->dev); > > > > > > Not keen on this. Please declare the variable up with the others. > > > > > > > They are never going to be used anywhere else in the function. > > Again I can if you feel strongly but isn't it really better to > > limit the scope of the variables if they are only being used > > locally. > > I understand the motivation, but if we did that all the time, the code > would look pretty dire IMHO. > Ok I do another spin. > > > > + unsigned long of_type = (unsigned long)id->data; > > > > > > And this one. > > > > > > > + type = (enum wm831x_parent)of_type; > > > > > > Looks like you don't even need of_type. > > > > > > Just cast id->data straight into wm81x_parent. > > > > Pretty sure you will get a warning on 64-bit systems if I do > > that. > > What makes you think that? > commit 942786e6e647cef94cf96dcd836d343be55fc452 Author: Lee Jones <lee.jones@linaro.org> mfd: arizona: Rid data size incompatibility warn when building for 64bit I am fairly sure an enum would get treated the same as an int by the compiler. I will try it and see. Thanks, Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> To: Lee Jones <lee.jones@linaro.org> Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>, <linus.walleij@linaro.org>, <gnurou@gmail.com>, <devicetree@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <patches@opensource.wolfsonmicro.com> Subject: Re: [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Date: Fri, 17 Mar 2017 09:25:20 +0000 [thread overview] Message-ID: <20170317092520.GM6986@localhost.localdomain> (raw) In-Reply-To: <20170317091502.kzcrhj7vlku5mtq7@dell> On Fri, Mar 17, 2017 at 09:15:02AM +0000, Lee Jones wrote: > On Thu, 16 Mar 2017, Charles Keepax wrote: > > > On Thu, Mar 16, 2017 at 02:00:19PM +0000, Lee Jones wrote: > > > On Wed, 15 Mar 2017, Charles Keepax wrote: > > > > + if (i2c->dev.of_node) { > > > > + const struct of_device_id *id = of_match_device(wm831x_of_match, > > > > + &i2c->dev); > > > > > > Not keen on this. Please declare the variable up with the others. > > > > > > > They are never going to be used anywhere else in the function. > > Again I can if you feel strongly but isn't it really better to > > limit the scope of the variables if they are only being used > > locally. > > I understand the motivation, but if we did that all the time, the code > would look pretty dire IMHO. > Ok I do another spin. > > > > + unsigned long of_type = (unsigned long)id->data; > > > > > > And this one. > > > > > > > + type = (enum wm831x_parent)of_type; > > > > > > Looks like you don't even need of_type. > > > > > > Just cast id->data straight into wm81x_parent. > > > > Pretty sure you will get a warning on 64-bit systems if I do > > that. > > What makes you think that? > commit 942786e6e647cef94cf96dcd836d343be55fc452 Author: Lee Jones <lee.jones@linaro.org> mfd: arizona: Rid data size incompatibility warn when building for 64bit I am fairly sure an enum would get treated the same as an int by the compiler. I will try it and see. Thanks, Charles
next prev parent reply other threads:[~2017-03-17 9:25 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-15 15:39 [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Charles Keepax 2017-03-15 15:39 ` Charles Keepax 2017-03-15 15:39 ` [PATCH v4 2/3] gpio: wm831x: Add basic device tree support Charles Keepax 2017-03-15 15:39 ` Charles Keepax 2017-03-15 15:39 ` [PATCH v4 3/3] mfd: wm831x: Add device tree binding document Charles Keepax 2017-03-15 15:39 ` Charles Keepax 2017-03-16 14:00 ` [PATCH v4 1/3] mfd: wm831x: Add basic device tree binding Lee Jones 2017-03-16 14:31 ` Charles Keepax 2017-03-16 14:31 ` Charles Keepax [not found] ` <20170316143144.GL6986-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-03-17 9:15 ` Lee Jones 2017-03-17 9:15 ` Lee Jones 2017-03-17 9:25 ` Charles Keepax [this message] 2017-03-17 9:25 ` Charles Keepax [not found] ` <20170317092520.GM6986-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> 2017-03-17 9:37 ` Lee Jones 2017-03-17 9:37 ` Lee Jones 2017-03-17 9:44 ` Charles Keepax 2017-03-17 9:44 ` Charles Keepax
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170317092520.GM6986@localhost.localdomain \ --to=ckeepax@opensource.wolfsonmicro.com \ --cc=devicetree@vger.kernel.org \ --cc=gnurou@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=patches@opensource.wolfsonmicro.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.