* [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
@ 2017-03-18 11:27 ` Xin Long
0 siblings, 0 replies; 6+ messages in thread
From: Xin Long @ 2017-03-18 11:27 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: davem, Marcelo Ricardo Leitner, Neil Horman, Vlad Yasevich, ja
As tp->dst_pending_confirm's value can only be set 0 or 1, this
patch is to change to define it as a bit instead of __u32.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
include/net/sctp/structs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index 07a0b12..4f64519 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -753,6 +753,8 @@ struct sctp_transport {
/* Is the Path MTU update pending on this tranport */
pmtu_pending:1,
+ dst_pending_confirm:1, /* need to confirm neighbour */
+
/* Has this transport moved the ctsn since we last sacked */
sack_generation:1;
u32 dst_cookie;
@@ -806,8 +808,6 @@ struct sctp_transport {
__u32 burst_limited; /* Holds old cwnd when max.burst is applied */
- __u32 dst_pending_confirm; /* need to confirm neighbour */
-
/* Destination */
struct dst_entry *dst;
/* Source address. */
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
@ 2017-03-18 11:27 ` Xin Long
0 siblings, 0 replies; 6+ messages in thread
From: Xin Long @ 2017-03-18 11:27 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: davem, Marcelo Ricardo Leitner, Neil Horman, Vlad Yasevich, ja
As tp->dst_pending_confirm's value can only be set 0 or 1, this
patch is to change to define it as a bit instead of __u32.
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
include/net/sctp/structs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
index 07a0b12..4f64519 100644
--- a/include/net/sctp/structs.h
+++ b/include/net/sctp/structs.h
@@ -753,6 +753,8 @@ struct sctp_transport {
/* Is the Path MTU update pending on this tranport */
pmtu_pending:1,
+ dst_pending_confirm:1, /* need to confirm neighbour */
+
/* Has this transport moved the ctsn since we last sacked */
sack_generation:1;
u32 dst_cookie;
@@ -806,8 +808,6 @@ struct sctp_transport {
__u32 burst_limited; /* Holds old cwnd when max.burst is applied */
- __u32 dst_pending_confirm; /* need to confirm neighbour */
-
/* Destination */
struct dst_entry *dst;
/* Source address. */
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
2017-03-18 11:27 ` Xin Long
@ 2017-03-18 19:07 ` Neil Horman
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Horman @ 2017-03-18 19:07 UTC (permalink / raw)
To: Xin Long
Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner,
Vlad Yasevich, ja
On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> include/net/sctp/structs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
> /* Is the Path MTU update pending on this tranport */
> pmtu_pending:1,
>
> + dst_pending_confirm:1, /* need to confirm neighbour */
> +
> /* Has this transport moved the ctsn since we last sacked */
> sack_generation:1;
> u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>
> __u32 burst_limited; /* Holds old cwnd when max.burst is applied */
>
> - __u32 dst_pending_confirm; /* need to confirm neighbour */
> -
> /* Destination */
> struct dst_entry *dst;
> /* Source address. */
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
@ 2017-03-18 19:07 ` Neil Horman
0 siblings, 0 replies; 6+ messages in thread
From: Neil Horman @ 2017-03-18 19:07 UTC (permalink / raw)
To: Xin Long
Cc: network dev, linux-sctp, davem, Marcelo Ricardo Leitner,
Vlad Yasevich, ja
On Sat, Mar 18, 2017 at 07:27:23PM +0800, Xin Long wrote:
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> include/net/sctp/structs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h
> index 07a0b12..4f64519 100644
> --- a/include/net/sctp/structs.h
> +++ b/include/net/sctp/structs.h
> @@ -753,6 +753,8 @@ struct sctp_transport {
> /* Is the Path MTU update pending on this tranport */
> pmtu_pending:1,
>
> + dst_pending_confirm:1, /* need to confirm neighbour */
> +
> /* Has this transport moved the ctsn since we last sacked */
> sack_generation:1;
> u32 dst_cookie;
> @@ -806,8 +808,6 @@ struct sctp_transport {
>
> __u32 burst_limited; /* Holds old cwnd when max.burst is applied */
>
> - __u32 dst_pending_confirm; /* need to confirm neighbour */
> -
> /* Destination */
> struct dst_entry *dst;
> /* Source address. */
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
2017-03-18 11:27 ` Xin Long
@ 2017-03-22 1:32 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-03-22 1:32 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman, vyasevich, ja
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 18 Mar 2017 19:27:23 +0800
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport
@ 2017-03-22 1:32 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2017-03-22 1:32 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman, vyasevich, ja
From: Xin Long <lucien.xin@gmail.com>
Date: Sat, 18 Mar 2017 19:27:23 +0800
> As tp->dst_pending_confirm's value can only be set 0 or 1, this
> patch is to change to define it as a bit instead of __u32.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-22 1:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-18 11:27 [PATCH net] sctp: define dst_pending_confirm as a bit in sctp_transport Xin Long
2017-03-18 11:27 ` Xin Long
2017-03-18 19:07 ` Neil Horman
2017-03-18 19:07 ` Neil Horman
2017-03-22 1:32 ` David Miller
2017-03-22 1:32 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.