All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Vignesh R <vigneshr@ti.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Jisheng Zhang <jszhang@marvell.com>
Subject: [PATCH 1/2] tty: serial_core: Add name field to uart_port struct
Date: Tue, 21 Mar 2017 19:06:35 +0530	[thread overview]
Message-ID: <20170321133636.8814-2-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Introduce a field to store name of uart_port that can be used to easily
identify uart port instances on a system that has more than one uart
instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
is number that particular uart instance.
This field will be useful when printing debug info for a particular port
or in register irqs with unique irq name. Port name is populated during
uart_add_one_port().

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/serial_core.c | 2 ++
 include/linux/serial_core.h      | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 0fb3f7cce62a..8b0fff74b190 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2744,6 +2744,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 	state->pm_state = UART_PM_STATE_UNDEFINED;
 	uport->cons = drv->cons;
 	uport->minor = drv->tty_driver->minor_start + uport->line;
+	snprintf(uport->name, sizeof(uport->name), "%s%d", drv->dev_name,
+		 drv->tty_driver->name_base + uport->line);
 
 	/*
 	 * If this port is a console, then the spinlock is already
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 58484fb35cc8..821f97ce3ae2 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -247,6 +247,7 @@ struct uart_port {
 	unsigned char		suspended;
 	unsigned char		irq_wake;
 	unsigned char		unused[2];
+	char			name[20];		/* port name */
 	struct attribute_group	*attr_group;		/* port specific attributes */
 	const struct attribute_group **tty_groups;	/* all attributes (serial core use only) */
 	struct serial_rs485     rs485;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jisheng Zhang <jszhang@marvell.com>, Vignesh R <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] tty: serial_core: Add name field to uart_port struct
Date: Tue, 21 Mar 2017 19:06:35 +0530	[thread overview]
Message-ID: <20170321133636.8814-2-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Introduce a field to store name of uart_port that can be used to easily
identify uart port instances on a system that has more than one uart
instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
is number that particular uart instance.
This field will be useful when printing debug info for a particular port
or in register irqs with unique irq name. Port name is populated during
uart_add_one_port().

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/serial_core.c | 2 ++
 include/linux/serial_core.h      | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 0fb3f7cce62a..8b0fff74b190 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2744,6 +2744,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 	state->pm_state = UART_PM_STATE_UNDEFINED;
 	uport->cons = drv->cons;
 	uport->minor = drv->tty_driver->minor_start + uport->line;
+	snprintf(uport->name, sizeof(uport->name), "%s%d", drv->dev_name,
+		 drv->tty_driver->name_base + uport->line);
 
 	/*
 	 * If this port is a console, then the spinlock is already
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 58484fb35cc8..821f97ce3ae2 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -247,6 +247,7 @@ struct uart_port {
 	unsigned char		suspended;
 	unsigned char		irq_wake;
 	unsigned char		unused[2];
+	char			name[20];		/* port name */
 	struct attribute_group	*attr_group;		/* port specific attributes */
 	const struct attribute_group **tty_groups;	/* all attributes (serial core use only) */
 	struct serial_rs485     rs485;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] tty: serial_core: Add name field to uart_port struct
Date: Tue, 21 Mar 2017 19:06:35 +0530	[thread overview]
Message-ID: <20170321133636.8814-2-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Introduce a field to store name of uart_port that can be used to easily
identify uart port instances on a system that has more than one uart
instance. The name is of the form ttyXN(eg. ttyS0, ttyAMA0,..) where N
is number that particular uart instance.
This field will be useful when printing debug info for a particular port
or in register irqs with unique irq name. Port name is populated during
uart_add_one_port().

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/serial_core.c | 2 ++
 include/linux/serial_core.h      | 1 +
 2 files changed, 3 insertions(+)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 0fb3f7cce62a..8b0fff74b190 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2744,6 +2744,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 	state->pm_state = UART_PM_STATE_UNDEFINED;
 	uport->cons = drv->cons;
 	uport->minor = drv->tty_driver->minor_start + uport->line;
+	snprintf(uport->name, sizeof(uport->name), "%s%d", drv->dev_name,
+		 drv->tty_driver->name_base + uport->line);
 
 	/*
 	 * If this port is a console, then the spinlock is already
diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
index 58484fb35cc8..821f97ce3ae2 100644
--- a/include/linux/serial_core.h
+++ b/include/linux/serial_core.h
@@ -247,6 +247,7 @@ struct uart_port {
 	unsigned char		suspended;
 	unsigned char		irq_wake;
 	unsigned char		unused[2];
+	char			name[20];		/* port name */
 	struct attribute_group	*attr_group;		/* port specific attributes */
 	const struct attribute_group **tty_groups;	/* all attributes (serial core use only) */
 	struct serial_rs485     rs485;
-- 
2.11.0

  reply	other threads:[~2017-03-21 13:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 13:36 [PATCH 0/2] serial: Add name field to uart_port Vignesh R
2017-03-21 13:36 ` Vignesh R
2017-03-21 13:36 ` Vignesh R
2017-03-21 13:36 ` Vignesh R [this message]
2017-03-21 13:36   ` [PATCH 1/2] tty: serial_core: Add name field to uart_port struct Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-22 18:45   ` Andy Shevchenko
2017-03-22 18:45     ` Andy Shevchenko
2017-03-23 12:13     ` Vignesh R
2017-03-23 12:13       ` Vignesh R
2017-03-23 12:13       ` Vignesh R
2017-03-21 13:36 ` [PATCH 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-22 18:48   ` Andy Shevchenko
2017-03-22 18:48     ` Andy Shevchenko
2017-03-22 18:46 ` [PATCH 0/2] serial: Add name field to uart_port Andy Shevchenko
2017-03-22 18:46   ` Andy Shevchenko
2017-03-23 12:22   ` Vignesh R
2017-03-23 12:22     ` Vignesh R
2017-03-23 12:22     ` Vignesh R
2017-03-23 17:07     ` Andy Shevchenko
2017-03-23 17:07       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321133636.8814-2-vigneshr@ti.com \
    --to=vigneshr@ti.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.