All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh R <vigneshr@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, <linux-serial@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Vignesh R <vigneshr@ti.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Jisheng Zhang <jszhang@marvell.com>
Subject: [PATCH 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial irq
Date: Tue, 21 Mar 2017 19:06:36 +0530	[thread overview]
Message-ID: <20170321133636.8814-3-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Using dev_name() as irq name during request_irq() might be misleading in
case of serial over PCI. Therefore identify serial port irqs using
uart_port's name field. This will help mapping irqs to appropriate
ttySN(where N is the serial port index) instances.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index f83b69f30987..48a07e2f617f 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
 		spin_unlock_irq(&i->lock);
 		irq_flags |= up->port.irqflags;
 		ret = request_irq(up->port.irq, serial8250_interrupt,
-				  irq_flags, dev_name(up->port.dev), i);
+				  irq_flags, up->port.name, i);
 		if (ret < 0)
 			serial_do_unlink(i, up);
 	}
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jisheng Zhang <jszhang@marvell.com>, Vignesh R <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial irq
Date: Tue, 21 Mar 2017 19:06:36 +0530	[thread overview]
Message-ID: <20170321133636.8814-3-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Using dev_name() as irq name during request_irq() might be misleading in
case of serial over PCI. Therefore identify serial port irqs using
uart_port's name field. This will help mapping irqs to appropriate
ttySN(where N is the serial port index) instances.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index f83b69f30987..48a07e2f617f 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
 		spin_unlock_irq(&i->lock);
 		irq_flags |= up->port.irqflags;
 		ret = request_irq(up->port.irq, serial8250_interrupt,
-				  irq_flags, dev_name(up->port.dev), i);
+				  irq_flags, up->port.name, i);
 		if (ret < 0)
 			serial_do_unlink(i, up);
 	}
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial irq
Date: Tue, 21 Mar 2017 19:06:36 +0530	[thread overview]
Message-ID: <20170321133636.8814-3-vigneshr@ti.com> (raw)
In-Reply-To: <20170321133636.8814-1-vigneshr@ti.com>

Using dev_name() as irq name during request_irq() might be misleading in
case of serial over PCI. Therefore identify serial port irqs using
uart_port's name field. This will help mapping irqs to appropriate
ttySN(where N is the serial port index) instances.

Signed-off-by: Vignesh R <vigneshr@ti.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index f83b69f30987..48a07e2f617f 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -218,7 +218,7 @@ static int serial_link_irq_chain(struct uart_8250_port *up)
 		spin_unlock_irq(&i->lock);
 		irq_flags |= up->port.irqflags;
 		ret = request_irq(up->port.irq, serial8250_interrupt,
-				  irq_flags, dev_name(up->port.dev), i);
+				  irq_flags, up->port.name, i);
 		if (ret < 0)
 			serial_do_unlink(i, up);
 	}
-- 
2.11.0

  parent reply	other threads:[~2017-03-21 13:37 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 13:36 [PATCH 0/2] serial: Add name field to uart_port Vignesh R
2017-03-21 13:36 ` Vignesh R
2017-03-21 13:36 ` Vignesh R
2017-03-21 13:36 ` [PATCH 1/2] tty: serial_core: Add name field to uart_port struct Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-22 18:45   ` Andy Shevchenko
2017-03-22 18:45     ` Andy Shevchenko
2017-03-23 12:13     ` Vignesh R
2017-03-23 12:13       ` Vignesh R
2017-03-23 12:13       ` Vignesh R
2017-03-21 13:36 ` Vignesh R [this message]
2017-03-21 13:36   ` [PATCH 2/2] serial: 8250: 8250_core: Fix irq name for 8250 serial irq Vignesh R
2017-03-21 13:36   ` Vignesh R
2017-03-22 18:48   ` Andy Shevchenko
2017-03-22 18:48     ` Andy Shevchenko
2017-03-22 18:46 ` [PATCH 0/2] serial: Add name field to uart_port Andy Shevchenko
2017-03-22 18:46   ` Andy Shevchenko
2017-03-23 12:22   ` Vignesh R
2017-03-23 12:22     ` Vignesh R
2017-03-23 12:22     ` Vignesh R
2017-03-23 17:07     ` Andy Shevchenko
2017-03-23 17:07       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170321133636.8814-3-vigneshr@ti.com \
    --to=vigneshr@ti.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=jszhang@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.