All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 00/28] arm/arm64: KVM: Rework the hyp-stub API
@ 2017-03-21 19:20 ` Marc Zyngier
  0 siblings, 0 replies; 112+ messages in thread
From: Marc Zyngier @ 2017-03-21 19:20 UTC (permalink / raw)
  To: linux-arm-kernel, kvm, kvmarm
  Cc: Russell King, Ard Biesheuvel, Catalin Marinas, Keerthy

As noticed by RMK in this thread[1], the hyp-stub API on 32bit ARM
could do with some TLC (it cannot perform a soft-restart at HYP, and
has holes in the hyp-stub support in a number of places). In general,
it would be desirable for the 32bit behaviour to align on 64bit, if
only to ease maintenance.

This series implements the following:
- Add HVC_[GS]ET_VECTORS and HVC_SOFT_RESTART to the 32bit code
- Add HVC_RESET_VECTORS to both arm and arm64, removing the need for
  __hyp_reset_vectors
- Implement add the stub entry points in the KVM init code, which
  didn't implement any so far
- Convert the HYP code to use the init code stubs directly
- Some general cleanup as a result of these changes (which includes
  killing HVC_GET_VECTORS)
- Add some API documentation that covers the above

Patches 12 to 14 would be better squashed into 10 and 11, but I've
kept them separate so that I can take the blame for everything I've
broken.

I've tested this on arm (Cubietruck, Jetson TK1) and arm64 (Seattle),
both as host and guest. Keerthy has been kind enough to test the 32bit
code on DRA7-EVM, AM57XX-EVM and KEYSTONE-K2E-EVM.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-December/473472.html

* From v3:
  - Reworked the way we save/restore lr on arm64, making it EL2's job
  in a consistent way (these are the three initial patches)
  - Collected RBs, TBs and Acks from James, Keerthy and Russell
  - Rebased on 4.11-rc3

* From v2:
  - Kill HVC_GET_VECTORS and the corresponding __hyp_get_vectors

* From v1:
  - Fixed some glaring bugs (reported by Ard and James)
  - Tidy up stub vector export on 32bit (Ard)
  - Nicer VA/PA conversion on 32bit (Ard)
  - Updated cpu_v7_reset documentation
  - Cleaned up HYP reset on PM events
  - Minor stub documentation update

Marc Zyngier (26):
  arm64: hyp-stub: Stop pointlessly clobbering lr
  arm64: KVM: Move lr save/restore to do_el2_call
  arm64: hyp-stub: Don't save lr in the EL1 code
  arm64: hyp-stub: Implement HVC_RESET_VECTORS stub hypercall
  arm64: KVM: Implement HVC_RESET_VECTORS stub hypercall in the init
    code
  arm64: KVM: Implement HVC_GET_VECTORS in the init code
  arm64: KVM: Allow the main HYP code to use the init hyp stub
    implementation
  arm64: KVM: Convert __cpu_reset_hyp_mode to using __hyp_reset_vectors
  arm64: KVM: Implement HVC_SOFT_RESTART in the init code
  ARM: KVM: Convert KVM to use HVC_GET_VECTORS
  ARM: Update cpu_v7_reset documentation
  ARM: hyp-stub: Use r1 for the soft-restart address
  ARM: Expose the VA/IDMAP offset
  ARM: hyp-stub: Implement HVC_RESET_VECTORS stub hypercall
  ARM: KVM: Implement HVC_RESET_VECTORS stub hypercall in the init code
  ARM: KVM: Implement HVC_GET_VECTORS in the init code
  ARM: KVM: Allow the main HYP code to use the init hyp stub
    implementation
  ARM: KVM: Convert __cpu_reset_hyp_mode to using __hyp_reset_vectors
  ARM: KVM: Implement HVC_SOFT_RESTART in the init code
  arm/arm64: KVM: Use __hyp_reset_vectors() directly
  arm/arm64: KVM: Remove kvm_get_idmap_start
  arm/arm64: KVM: Use HVC_RESET_VECTORS to reinit HYP mode
  ARM: decompressor: Remove __hyp_get_vectors usage
  ARM: hyp-stub/KVM: Kill __hyp_get_vectors
  arm64: hyp-stub/KVM: Kill __hyp_get_vectors
  arm/arm64: Add hyp-stub API documentation

Russell King (2):
  ARM: hyp-stub: improve ABI
  ARM: soft-reboot into same mode that we entered the kernel

 Documentation/virtual/kvm/arm/hyp-abi.txt | 45 ++++++++++++++++++++++++++++
 arch/arm/boot/compressed/head.S           |  5 +++-
 arch/arm/include/asm/kvm_asm.h            |  2 --
 arch/arm/include/asm/kvm_host.h           |  6 ----
 arch/arm/include/asm/kvm_mmu.h            |  1 -
 arch/arm/include/asm/proc-fns.h           |  4 +--
 arch/arm/include/asm/virt.h               | 12 +++++++-
 arch/arm/kernel/hyp-stub.S                | 39 +++++++++++++++++++-----
 arch/arm/kernel/reboot.c                  |  7 +++--
 arch/arm/kvm/arm.c                        | 25 ++++++----------
 arch/arm/kvm/hyp/hyp-entry.S              | 29 ++++++++++++++----
 arch/arm/kvm/init.S                       | 49 ++++++++++++++++++++++++++-----
 arch/arm/kvm/interrupts.S                 |  4 ---
 arch/arm/kvm/mmu.c                        |  5 ----
 arch/arm/mm/mmu.c                         |  5 ++++
 arch/arm/mm/proc-v7.S                     | 15 ++++++----
 arch/arm64/include/asm/kvm_asm.h          |  1 -
 arch/arm64/include/asm/kvm_host.h         |  7 -----
 arch/arm64/include/asm/kvm_mmu.h          |  1 -
 arch/arm64/include/asm/virt.h             | 17 +++++++----
 arch/arm64/kernel/hyp-stub.S              | 34 +++++++--------------
 arch/arm64/kvm/hyp-init.S                 | 45 +++++++++++++++++++++-------
 arch/arm64/kvm/hyp.S                      |  2 +-
 arch/arm64/kvm/hyp/hyp-entry.S            | 43 +++++++++++++--------------
 24 files changed, 266 insertions(+), 137 deletions(-)
 create mode 100644 Documentation/virtual/kvm/arm/hyp-abi.txt

-- 
2.11.0

^ permalink raw reply	[flat|nested] 112+ messages in thread

end of thread, other threads:[~2017-04-04  7:36 UTC | newest]

Thread overview: 112+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21 19:20 [PATCH v4 00/28] arm/arm64: KVM: Rework the hyp-stub API Marc Zyngier
2017-03-21 19:20 ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 01/28] arm64: hyp-stub: Stop pointlessly clobbering lr Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 02/28] arm64: KVM: Move lr save/restore to do_el2_call Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-23 11:57   ` Marc Zyngier
2017-03-23 11:57     ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 03/28] arm64: hyp-stub: Don't save lr in the EL1 code Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 04/28] arm64: hyp-stub: Implement HVC_RESET_VECTORS stub hypercall Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 05/28] arm64: KVM: Implement HVC_RESET_VECTORS stub hypercall in the init code Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-24 14:33   ` Christoffer Dall
2017-03-24 14:33     ` Christoffer Dall
2017-03-24 14:45     ` Marc Zyngier
2017-03-24 14:45       ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 06/28] arm64: KVM: Implement HVC_GET_VECTORS " Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 07/28] arm64: KVM: Allow the main HYP code to use the init hyp stub implementation Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-24 14:33   ` Christoffer Dall
2017-03-24 14:33     ` Christoffer Dall
2017-03-24 14:56     ` Marc Zyngier
2017-03-24 14:56       ` Marc Zyngier
2017-04-03 17:28       ` Christoffer Dall
2017-04-03 17:28         ` Christoffer Dall
2017-03-21 19:20 ` [PATCH v4 08/28] arm64: KVM: Convert __cpu_reset_hyp_mode to using __hyp_reset_vectors Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 09/28] arm64: KVM: Implement HVC_SOFT_RESTART in the init code Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 10/28] ARM: hyp-stub: improve ABI Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 11/28] ARM: soft-reboot into same mode that we entered the kernel Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 12/28] ARM: KVM: Convert KVM to use HVC_GET_VECTORS Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 13/28] ARM: Update cpu_v7_reset documentation Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 14/28] ARM: hyp-stub: Use r1 for the soft-restart address Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 15/28] ARM: Expose the VA/IDMAP offset Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 16/28] ARM: hyp-stub: Implement HVC_RESET_VECTORS stub hypercall Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 17/28] ARM: KVM: Implement HVC_RESET_VECTORS stub hypercall in the init code Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 18/28] ARM: KVM: Implement HVC_GET_VECTORS " Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 19/28] ARM: KVM: Allow the main HYP code to use the init hyp stub implementation Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-24 14:34   ` Christoffer Dall
2017-03-24 14:34     ` Christoffer Dall
2017-03-24 15:01     ` Marc Zyngier
2017-03-24 15:01       ` Marc Zyngier
2017-04-03 17:32       ` Christoffer Dall
2017-04-03 17:32         ` Christoffer Dall
2017-04-03 17:51         ` Marc Zyngier
2017-04-03 17:51           ` Marc Zyngier
2017-04-04  7:36           ` Christoffer Dall
2017-04-04  7:36             ` Christoffer Dall
2017-03-21 19:20 ` [PATCH v4 20/28] ARM: KVM: Convert __cpu_reset_hyp_mode to using __hyp_reset_vectors Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 21/28] ARM: KVM: Implement HVC_SOFT_RESTART in the init code Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 22/28] arm/arm64: KVM: Use __hyp_reset_vectors() directly Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 23/28] arm/arm64: KVM: Remove kvm_get_idmap_start Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 24/28] arm/arm64: KVM: Use HVC_RESET_VECTORS to reinit HYP mode Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 25/28] ARM: decompressor: Remove __hyp_get_vectors usage Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-24 14:34   ` Christoffer Dall
2017-03-24 14:34     ` Christoffer Dall
2017-03-24 15:26     ` Marc Zyngier
2017-03-24 15:26       ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 26/28] ARM: hyp-stub/KVM: Kill __hyp_get_vectors Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 27/28] arm64: " Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-21 19:20 ` [PATCH v4 28/28] arm/arm64: Add hyp-stub API documentation Marc Zyngier
2017-03-21 19:20   ` Marc Zyngier
2017-03-24 14:33   ` Christoffer Dall
2017-03-24 14:33     ` Christoffer Dall
2017-03-24 14:42     ` Marc Zyngier
2017-03-24 14:42       ` Marc Zyngier
2017-03-24 15:23       ` Christoffer Dall
2017-03-24 15:23         ` Christoffer Dall
2017-03-24 15:57         ` Marc Zyngier
2017-03-24 15:57           ` Marc Zyngier
2017-03-24 16:03           ` Christoffer Dall
2017-03-24 16:03             ` Christoffer Dall
2017-03-22 13:37 ` [PATCH v4 00/28] arm/arm64: KVM: Rework the hyp-stub API Christoffer Dall
2017-03-22 13:37   ` Christoffer Dall
2017-03-22 16:14   ` Marc Zyngier
2017-03-22 16:14     ` Marc Zyngier
2017-03-22 17:27     ` Christoffer Dall
2017-03-22 17:27       ` Christoffer Dall
2017-03-23 10:53       ` Marc Zyngier
2017-03-23 10:53         ` Marc Zyngier
2017-03-23 14:39         ` Christoffer Dall
2017-03-23 14:39           ` Christoffer Dall
2017-03-23 15:16           ` Marc Zyngier
2017-03-23 15:16             ` Marc Zyngier
2017-03-23 15:45             ` Christoffer Dall
2017-03-23 15:45               ` Christoffer Dall
2017-03-22 16:20 ` Catalin Marinas
2017-03-22 16:20   ` Catalin Marinas
2017-03-24 14:36 ` Christoffer Dall
2017-03-24 14:36   ` Christoffer Dall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.