From: Icenowy Zheng <icenowy@aosc.io> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, linux-kernel <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, linux-sunxi <linux-sunxi@googlegroups.com>, Daniel Vetter <daniel.vetter@intel.com>, Chen-Yu Tsai <wens@csie.org>, linux-clk <linux-clk@vger.kernel.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Date: Tue, 28 Mar 2017 18:05:08 +0800 [thread overview] Message-ID: <20170328100519.145DE203419@relay.mailchannels.net> (raw) 2017年3月27日 上午5:11于 Maxime Ripard <maxime.ripard@free-electrons.com>写道: > > On Fri, Mar 17, 2017 at 11:34:45AM +0800, Chen-Yu Tsai wrote: > > On Thu, Mar 16, 2017 at 1:37 AM, Rob Herring <robh@kernel.org> wrote: > > > On Tue, Mar 07, 2017 at 09:56:26AM +0100, Maxime Ripard wrote: > > >> The Allwinner Timings Controller has two, mutually exclusive, channels. > > >> When the binding has been introduced, it was assumed that there would be > > >> only a single user per channel in the system. > > >> > > >> While this is likely for the channel 0 which only connects to LCD displays, > > >> it turns out that the channel 1 can be connected to multiple controllers in > > >> the SoC (HDMI and TV encoders for example). And while the simultaneous use > > >> of HDMI and TV outputs cannot be achieved, switching from one to the other > > >> at runtime definitely sounds plausible. > > >> > > >> Add an extra property, allwinner,tcon-channel, to specify for a given > > >> endpoint which TCON channel it is connected to, while falling back to the > > >> previous mechanism if that property is missing. > > > > > > I think perhaps TCON channels should have been ports rather than > > > endpoints. The fact that the channels are mutually exclusive can be > > > handled in the driver and doesn't really matter in the binding. How > > > painful would it be to rework things to move TCON channel 1 from port 0, > > > endpoint 1 to port 1? > > > > Having a separate output port for channel 1 was one option we discussed. > > However it wouldn't work well with the kernel's of_graph based crtc > > detection (drm_of_find_possible_crtcs / drm_of_find_possible_crtcs), > > which has the crtcs bound via the output port. As the logic is used > > by multiple drivers, I'm not sure it's easy to rework or test. > > Can't we use a different logic than drm_of_find_possible_crtcs to fill > the same role? > > > Also, we still have to support old device trees using channel 1 from > > output port 0 endpoint 1. This is the TV encoder on sun5i (A10s/A13/R8). And from A83T on we will face channel-1 only TCONs., which do not have channel 0 at all in hardware. > > We could probably work something out if we go that way to deal with > old DTs though. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Icenowy Zheng <icenowy@aosc.io> To: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Mike Turquette <mturquette@baylibre.com>, David Airlie <airlied@linux.ie>, Mark Rutland <mark.rutland@arm.com>, Daniel Vetter <daniel.vetter@intel.com>, linux-sunxi <linux-sunxi@googlegroups.com>, linux-kernel <linux-kernel@vger.kernel.org>, Stephen Boyd <sboyd@codeaurora.org>, devicetree <devicetree@vger.kernel.org>, linux-clk <linux-clk@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh@kernel.org> Subject: Re: [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Date: Tue, 28 Mar 2017 18:05:08 +0800 [thread overview] Message-ID: <20170328100519.145DE203419@relay.mailchannels.net> (raw) CjIwMTflubQz5pyIMjfml6Ug5LiK5Y2INToxMeS6jiBNYXhpbWUgUmlwYXJkIDxtYXhpbWUucmlw YXJkQGZyZWUtZWxlY3Ryb25zLmNvbT7lhpnpgZPvvJoKPgo+IE9uIEZyaSwgTWFyIDE3LCAyMDE3 IGF0IDExOjM0OjQ1QU0gKzA4MDAsIENoZW4tWXUgVHNhaSB3cm90ZTogCj4gPiBPbiBUaHUsIE1h ciAxNiwgMjAxNyBhdCAxOjM3IEFNLCBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPiB3cm90 ZTogCj4gPiA+IE9uIFR1ZSwgTWFyIDA3LCAyMDE3IGF0IDA5OjU2OjI2QU0gKzAxMDAsIE1heGlt ZSBSaXBhcmQgd3JvdGU6IAo+ID4gPj4gVGhlIEFsbHdpbm5lciBUaW1pbmdzIENvbnRyb2xsZXIg aGFzIHR3bywgbXV0dWFsbHkgZXhjbHVzaXZlLCBjaGFubmVscy4gCj4gPiA+PiBXaGVuIHRoZSBi aW5kaW5nIGhhcyBiZWVuIGludHJvZHVjZWQsIGl0IHdhcyBhc3N1bWVkIHRoYXQgdGhlcmUgd291 bGQgYmUgCj4gPiA+PiBvbmx5IGEgc2luZ2xlIHVzZXIgcGVyIGNoYW5uZWwgaW4gdGhlIHN5c3Rl bS4gCj4gPiA+PiAKPiA+ID4+IFdoaWxlIHRoaXMgaXMgbGlrZWx5IGZvciB0aGUgY2hhbm5lbCAw IHdoaWNoIG9ubHkgY29ubmVjdHMgdG8gTENEIGRpc3BsYXlzLCAKPiA+ID4+IGl0IHR1cm5zIG91 dCB0aGF0IHRoZSBjaGFubmVsIDEgY2FuIGJlIGNvbm5lY3RlZCB0byBtdWx0aXBsZSBjb250cm9s bGVycyBpbiAKPiA+ID4+IHRoZSBTb0MgKEhETUkgYW5kIFRWIGVuY29kZXJzIGZvciBleGFtcGxl KS4gQW5kIHdoaWxlIHRoZSBzaW11bHRhbmVvdXMgdXNlIAo+ID4gPj4gb2YgSERNSSBhbmQgVFYg b3V0cHV0cyBjYW5ub3QgYmUgYWNoaWV2ZWQsIHN3aXRjaGluZyBmcm9tIG9uZSB0byB0aGUgb3Ro ZXIgCj4gPiA+PiBhdCBydW50aW1lIGRlZmluaXRlbHkgc291bmRzIHBsYXVzaWJsZS4gCj4gPiA+ PiAKPiA+ID4+IEFkZCBhbiBleHRyYSBwcm9wZXJ0eSwgYWxsd2lubmVyLHRjb24tY2hhbm5lbCwg dG8gc3BlY2lmeSBmb3IgYSBnaXZlbiAKPiA+ID4+IGVuZHBvaW50IHdoaWNoIFRDT04gY2hhbm5l bCBpdCBpcyBjb25uZWN0ZWQgdG8sIHdoaWxlIGZhbGxpbmcgYmFjayB0byB0aGUgCj4gPiA+PiBw cmV2aW91cyBtZWNoYW5pc20gaWYgdGhhdCBwcm9wZXJ0eSBpcyBtaXNzaW5nLiAKPiA+ID4gCj4g PiA+IEkgdGhpbmsgcGVyaGFwcyBUQ09OIGNoYW5uZWxzIHNob3VsZCBoYXZlIGJlZW4gcG9ydHMg cmF0aGVyIHRoYW4gCj4gPiA+IGVuZHBvaW50cy4gVGhlIGZhY3QgdGhhdCB0aGUgY2hhbm5lbHMg YXJlIG11dHVhbGx5IGV4Y2x1c2l2ZSBjYW4gYmUgCj4gPiA+IGhhbmRsZWQgaW4gdGhlIGRyaXZl ciBhbmQgZG9lc24ndCByZWFsbHkgbWF0dGVyIGluIHRoZSBiaW5kaW5nLiBIb3cgCj4gPiA+IHBh aW5mdWwgd291bGQgaXQgYmUgdG8gcmV3b3JrIHRoaW5ncyB0byBtb3ZlIFRDT04gY2hhbm5lbCAx IGZyb20gcG9ydCAwLCAKPiA+ID4gZW5kcG9pbnQgMSB0byBwb3J0IDE/IAo+ID4gCj4gPiBIYXZp bmcgYSBzZXBhcmF0ZSBvdXRwdXQgcG9ydCBmb3IgY2hhbm5lbCAxIHdhcyBvbmUgb3B0aW9uIHdl IGRpc2N1c3NlZC4gCj4gPiBIb3dldmVyIGl0IHdvdWxkbid0IHdvcmsgd2VsbCB3aXRoIHRoZSBr ZXJuZWwncyBvZl9ncmFwaCBiYXNlZCBjcnRjIAo+ID4gZGV0ZWN0aW9uIChkcm1fb2ZfZmluZF9w b3NzaWJsZV9jcnRjcyAvIGRybV9vZl9maW5kX3Bvc3NpYmxlX2NydGNzKSwgCj4gPiB3aGljaCBo YXMgdGhlIGNydGNzIGJvdW5kIHZpYSB0aGUgb3V0cHV0IHBvcnQuIEFzIHRoZSBsb2dpYyBpcyB1 c2VkIAo+ID4gYnkgbXVsdGlwbGUgZHJpdmVycywgSSdtIG5vdCBzdXJlIGl0J3MgZWFzeSB0byBy ZXdvcmsgb3IgdGVzdC4gCj4KPiBDYW4ndCB3ZSB1c2UgYSBkaWZmZXJlbnQgbG9naWMgdGhhbiBk cm1fb2ZfZmluZF9wb3NzaWJsZV9jcnRjcyB0byBmaWxsIAo+IHRoZSBzYW1lIHJvbGU/IAo+Cj4g PiBBbHNvLCB3ZSBzdGlsbCBoYXZlIHRvIHN1cHBvcnQgb2xkIGRldmljZSB0cmVlcyB1c2luZyBj aGFubmVsIDEgZnJvbSAKPiA+IG91dHB1dCBwb3J0IDAgZW5kcG9pbnQgMS4gVGhpcyBpcyB0aGUg VFYgZW5jb2RlciBvbiBzdW41aSAoQTEwcy9BMTMvUjgpLiAKCkFuZCBmcm9tIEE4M1Qgb24gd2Ug d2lsbCBmYWNlIGNoYW5uZWwtMSBvbmx5IFRDT05zLiwgd2hpY2ggZG8gbm90CmhhdmUgY2hhbm5l bCAwIGF0IGFsbCBpbiBoYXJkd2FyZS4KCj4KPiBXZSBjb3VsZCBwcm9iYWJseSB3b3JrIHNvbWV0 aGluZyBvdXQgaWYgd2UgZ28gdGhhdCB3YXkgdG8gZGVhbCB3aXRoIAo+IG9sZCBEVHMgdGhvdWdo LiAKPgo+IE1heGltZSAKPgo+IC0tIAo+IE1heGltZSBSaXBhcmQsIEZyZWUgRWxlY3Ryb25zIAo+ IEVtYmVkZGVkIExpbnV4IGFuZCBLZXJuZWwgZW5naW5lZXJpbmcgCj4gaHR0cDovL2ZyZWUtZWxl Y3Ryb25zLmNvbQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18gCj4gbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QgCj4gbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnIAo+IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbCAK
next reply other threads:[~2017-03-28 10:05 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-28 10:05 Icenowy Zheng [this message] 2017-03-28 10:05 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Icenowy Zheng 2017-03-29 12:31 ` Maxime Ripard 2017-03-29 12:31 ` Maxime Ripard 2017-03-29 12:31 ` Maxime Ripard -- strict thread matches above, loose matches on Subject: below -- 2017-03-28 10:05 Icenowy Zheng 2017-03-07 8:56 [PATCH 0/15] drm: sun4i: Add support for the HDMI controller Maxime Ripard 2017-03-07 8:56 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Maxime Ripard 2017-03-07 8:56 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Maxime Ripard 2017-03-07 8:56 ` Maxime Ripard 2017-03-08 3:38 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai 2017-03-08 3:38 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Chen-Yu Tsai 2017-03-08 3:38 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai 2017-03-15 17:37 ` Rob Herring 2017-03-15 17:37 ` Rob Herring 2017-03-15 17:37 ` Rob Herring 2017-03-17 3:34 ` Chen-Yu Tsai 2017-03-17 3:34 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner, tcon-channel property Chen-Yu Tsai 2017-03-17 3:34 ` [PATCH 7/15] dt-bindings: display: sun4i: Add allwinner,tcon-channel property Chen-Yu Tsai 2017-03-26 21:11 ` Maxime Ripard 2017-03-26 21:11 ` Maxime Ripard 2017-03-26 21:11 ` Maxime Ripard
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170328100519.145DE203419@relay.mailchannels.net \ --to=icenowy@aosc.io \ --cc=daniel.vetter@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=maxime.ripard@free-electrons.com \ --cc=mturquette@baylibre.com \ --cc=sboyd@codeaurora.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.