From: Dong Aisheng <dongas86@gmail.com> To: Leonard Crestez <leonard.crestez@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, linux-arm-kernel@lists.infradead.org, Fabio Estevam <fabio.estevam@nxp.com>, Fugang Duan <fugang.duan@nxp.com>, Octavian Purdila <octavian.purdila@nxp.com>, Florian Fainelli <f.fainelli@gmail.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Date: Thu, 30 Mar 2017 14:47:48 +0800 [thread overview] Message-ID: <20170330064748.GC19596@b29396-OptiPlex-7040> (raw) In-Reply-To: <1490699810.3546.10.camel@nxp.com> On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > > Hi Leonard, > > > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > > Add this driver to the default imx config since the device is present on > > > one of the evaluation boards. > > Upstream currently no evaluation board support. > > > > This may leave to Shawn to decide whether apply it. > > Really? But the dts for this eval board is included in upstream. Shouldn't the > default config try to work with the default imx*.dts files included? > Oh.. i saw the board wrong, sorry for the noise. Regards Dong Aisheng > > > This used to work mostly fine with the generic phy driver but since > > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > > I guess you should get a checkpatch error here. > > Because I didn't reference that other commit right? Sorry about this. > > Should I submit again with an improved commit message? > > > > performs a soft reset on startup. This causes netboot to sometimes > > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried > > > and > > Probably another checkpatch warning. > > Why, line too long? > > > > This was generated with "make savedefconfig" and it includes a few > > > additional minor cleanups. > > > > > It is a bit strange, after apply your patch, i still get a lot difference > > as follows when savedefconfig: > > > > I don't know what's wrong. Toolchains difference? > > Maybe, kconfig acts strangely sometimes. It's not clear option ordering is > guaranteed to be stable. I don't think it matters though. > > -- > Regards, > Leonard
WARNING: multiple messages have this Message-ID (diff)
From: dongas86@gmail.com (Dong Aisheng) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Date: Thu, 30 Mar 2017 14:47:48 +0800 [thread overview] Message-ID: <20170330064748.GC19596@b29396-OptiPlex-7040> (raw) In-Reply-To: <1490699810.3546.10.camel@nxp.com> On Tue, Mar 28, 2017 at 02:16:50PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 14:43 +0800, Dong Aisheng wrote: > > Hi Leonard, > > > > On Wed, Mar 22, 2017 at 04:27:37PM +0200, Leonard Crestez wrote: > > > > > > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > > > Add this driver to the default imx config since the device is present on > > > one of the evaluation boards. > > Upstream currently no evaluation board support. > > > > This may leave to Shawn to decide whether apply it. > > Really? But the dts for this eval board is included in upstream. Shouldn't the > default config try to work with the default imx*.dts files included? > Oh.. i saw the board wrong, sorry for the noise. Regards Dong Aisheng > > > This used to work mostly fine with the generic phy driver but since > > > commit 0878fff1f42c18e448ab5b8b4f6a3eb32365b5b6 that driver no longer > > I guess you should get a checkpatch error here. > > Because I didn't reference that other commit right? Sorry about this. > > Should I submit again with an improved commit message? > > > > performs a soft reset on startup. This causes netboot to sometimes > > > timeout on DHCP because RX doesn't work right. DHCP is eventually retried > > > and > > Probably another checkpatch warning. > > Why, line too long? > > > > This was generated with "make savedefconfig" and it includes a few > > > additional minor cleanups. > > > > > It is a bit strange, after apply your patch, i still get a lot difference > > as follows when savedefconfig: > >? > > I don't know what's wrong. Toolchains difference? > > Maybe, kconfig acts strangely sometimes. It's not clear option ordering is > guaranteed to be stable. I don't think it matters though. > > -- > Regards, > Leonard
next prev parent reply other threads:[~2017-03-29 14:51 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-22 14:27 [PATCH] ARM: imx_v6_v7_defconfig: Select SMSC_PHY Leonard Crestez 2017-03-22 14:27 ` Leonard Crestez 2017-03-22 15:28 ` Fabio Estevam 2017-03-22 15:28 ` Fabio Estevam 2017-03-22 21:09 ` Florian Fainelli 2017-03-22 21:09 ` Florian Fainelli 2017-03-23 1:17 ` Andy Duan 2017-03-23 1:17 ` Andy Duan 2017-03-24 6:43 ` Dong Aisheng 2017-03-24 6:43 ` Dong Aisheng 2017-03-28 11:16 ` Leonard Crestez 2017-03-28 11:16 ` Leonard Crestez 2017-03-29 2:57 ` Shawn Guo 2017-03-29 2:57 ` Shawn Guo 2017-03-30 6:47 ` Dong Aisheng [this message] 2017-03-30 6:47 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170330064748.GC19596@b29396-OptiPlex-7040 \ --to=dongas86@gmail.com \ --cc=f.fainelli@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=fugang.duan@nxp.com \ --cc=kernel@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=octavian.purdila@nxp.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.