* [PATCH] Eudyptula challenge
@ 2017-03-31 8:40 Chewie Lin
2017-03-31 8:40 ` [PATCH] drivers: fixed a checkpatch warning Chewie Lin
0 siblings, 1 reply; 8+ messages in thread
From: Chewie Lin @ 2017-03-31 8:40 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Hi,
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
fixed a checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] drivers: fixed a checkpatch warning
2017-03-31 8:40 [PATCH] Eudyptula challenge Chewie Lin
@ 2017-03-31 8:40 ` Chewie Lin
2017-03-31 9:04 ` Greg KH
2017-03-31 18:53 ` Joe Perches
0 siblings, 2 replies; 8+ messages in thread
From: Chewie Lin @ 2017-03-31 8:40 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
fixed a coding style error/warning.
Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
status = usb_reset_device(priv->usb);
if (status)
dev_warn(&priv->usb->dev,
- "usb_device_reset fail status=%d\n", status);
+ "%s=%d\n", "usb_device_reset fail status", status);
}
static void vnt_free_int_bufs(struct vnt_private *priv)
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: fixed a checkpatch warning
2017-03-31 8:40 ` [PATCH] drivers: fixed a checkpatch warning Chewie Lin
@ 2017-03-31 9:04 ` Greg KH
2017-03-31 18:53 ` Joe Perches
1 sibling, 0 replies; 8+ messages in thread
From: Greg KH @ 2017-03-31 9:04 UTC (permalink / raw)
To: Chewie Lin; +Cc: forest, devel, linux-kernel
On Fri, Mar 31, 2017 at 01:40:29AM -0700, Chewie Lin wrote:
> fixed a coding style error/warning.
Worst changelog and subject: line ever :)
Please go read the links that my patchbot sent you last time you
submitted this change. You didn't do so for some odd reason :(
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: fixed a checkpatch warning
2017-03-31 8:40 ` [PATCH] drivers: fixed a checkpatch warning Chewie Lin
2017-03-31 9:04 ` Greg KH
@ 2017-03-31 18:53 ` Joe Perches
2017-04-01 3:28 ` Chewie Lin
1 sibling, 1 reply; 8+ messages in thread
From: Joe Perches @ 2017-03-31 18:53 UTC (permalink / raw)
To: Chewie Lin, greg, forest, devel, linux-kernel
On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote:
> fixed a coding style error/warning.
>
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
> drivers/staging/vt6656/main_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> status = usb_reset_device(priv->usb);
> if (status)
> dev_warn(&priv->usb->dev,
> - "usb_device_reset fail status=%d\n", status);
> + "%s=%d\n", "usb_device_reset fail status", status);
Yeah, what Greg said.
Also most likely this should be
dev_warn(&priv->usb->dev,
"usb_reset_device fail status=%d\n", status);
Note the function is usb_device_reset, but the
function call that failed is usb_reset_device.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drivers: fixed a checkpatch warning
2017-03-31 18:53 ` Joe Perches
@ 2017-04-01 3:28 ` Chewie Lin
0 siblings, 0 replies; 8+ messages in thread
From: Chewie Lin @ 2017-04-01 3:28 UTC (permalink / raw)
To: Joe Perches; +Cc: greg, forest, devel, linux-kernel
On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote:
> On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote:
> > fixed a coding style error/warning.
> >
> > Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> > ---
> > drivers/staging/vt6656/main_usb.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> > index 9e074e9..2d9e7af 100644
> > --- a/drivers/staging/vt6656/main_usb.c
> > +++ b/drivers/staging/vt6656/main_usb.c
> > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> > status = usb_reset_device(priv->usb);
> > if (status)
> > dev_warn(&priv->usb->dev,
> > - "usb_device_reset fail status=%d\n", status);
> > + "%s=%d\n", "usb_device_reset fail status", status);
>
> Yeah, what Greg said.
>
> Also most likely this should be
>
> dev_warn(&priv->usb->dev,
> "usb_reset_device fail status=%d\n", status);
>
> Note the function is usb_device_reset, but the
> function call that failed is usb_reset_device.
yep, I had the comic book guy from the Simpsons voice when I read that. :)
I submitted a separate patch, maybe I should have reply-to this instead?
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Eudyptula challenge
@ 2017-03-31 10:01 Chewie Lin
0 siblings, 0 replies; 8+ messages in thread
From: Chewie Lin @ 2017-03-31 10:01 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Hi greg k-h and forest:
Sorry about all the spam I've been sending earlier. One more try.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
fixed a checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] eudyptula challenge
@ 2017-03-31 20:58 Chewie Lin
0 siblings, 0 replies; 8+ messages in thread
From: Chewie Lin @ 2017-03-31 20:58 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Hi greg and forest:
I hate to bother but one more, with better changelog.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] eudyptula challenge
@ 2017-04-01 1:59 Chewie Lin
0 siblings, 0 replies; 8+ messages in thread
From: Chewie Lin @ 2017-04-01 1:59 UTC (permalink / raw)
To: greg, forest, devel, linux-kernel
Hi all:
Better and improved changelog version 3.
I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem. Thanks for taking time on this trivial patch.
sl424
Chewie Lin (1):
drivers/staging/vt6656/main_usb.c: checkpatch warning
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.10.0
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-04-01 3:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 8:40 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 8:40 ` [PATCH] drivers: fixed a checkpatch warning Chewie Lin
2017-03-31 9:04 ` Greg KH
2017-03-31 18:53 ` Joe Perches
2017-04-01 3:28 ` Chewie Lin
2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 20:58 [PATCH] eudyptula challenge Chewie Lin
2017-04-01 1:59 Chewie Lin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.