All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Eudyptula challenge
@ 2017-03-31 10:01 Chewie Lin
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
  0 siblings, 1 reply; 7+ messages in thread
From: Chewie Lin @ 2017-03-31 10:01 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Hi greg k-h and forest:

Sorry about all the spam I've been sending earlier. One more try.
I'm submitting this patch as part of Eudyptula challenge to fix a 
coding style problem.  Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
  fixed a checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
@ 2017-03-31 10:01 ` Chewie Lin
  2017-03-31 10:32   ` Kim Phillips
  2017-03-31 12:33   ` Greg KH
  0 siblings, 2 replies; 7+ messages in thread
From: Chewie Lin @ 2017-03-31 10:01 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

fix a checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names

Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
-- 
2.10.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
@ 2017-03-31 10:32   ` Kim Phillips
  2017-03-31 12:33   ` Greg KH
  1 sibling, 0 replies; 7+ messages in thread
From: Kim Phillips @ 2017-03-31 10:32 UTC (permalink / raw)
  To: Chewie Lin; +Cc: greg, forest, devel, linux-kernel

On Fri, 31 Mar 2017 03:01:12 -0700
Chewie Lin <linsh@oregonstate.edu> wrote:

> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names

__func__, so:

> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);

"%s=%d\n", __func__ " fail status", status);

?

Kim

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
  2017-03-31 10:32   ` Kim Phillips
@ 2017-03-31 12:33   ` Greg KH
  1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2017-03-31 12:33 UTC (permalink / raw)
  To: Chewie Lin; +Cc: forest, devel, linux-kernel

On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
> 
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
>  drivers/staging/vt6656/main_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
>  	status = usb_reset_device(priv->usb);
>  	if (status)
>  		dev_warn(&priv->usb->dev,
> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);

Your patch does not match your description at all :(

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] eudyptula challenge
@ 2017-04-01  1:59 Chewie Lin
  0 siblings, 0 replies; 7+ messages in thread
From: Chewie Lin @ 2017-04-01  1:59 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Hi all:

Better and improved changelog version 3. 

I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem.  Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
	drivers/staging/vt6656/main_usb.c: checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] eudyptula challenge
@ 2017-03-31 20:58 Chewie Lin
  0 siblings, 0 replies; 7+ messages in thread
From: Chewie Lin @ 2017-03-31 20:58 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Hi greg and forest:

I hate to bother but one more, with better changelog.

I'm submitting this patch as part of Eudyptula challenge to fix a
coding style problem.  Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
	drivers/staging/vt6656/main_usb.c: checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] Eudyptula challenge
@ 2017-03-31  8:40 Chewie Lin
  0 siblings, 0 replies; 7+ messages in thread
From: Chewie Lin @ 2017-03-31  8:40 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Hi,

I'm submitting this patch as part of Eudyptula challenge to fix a 
coding style problem.  Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
  fixed a checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-01  1:59 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-03-31 10:32   ` Kim Phillips
2017-03-31 12:33   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-04-01  1:59 [PATCH] eudyptula challenge Chewie Lin
2017-03-31 20:58 Chewie Lin
2017-03-31  8:40 [PATCH] Eudyptula challenge Chewie Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.