All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Eudyptula challenge
@ 2017-03-31 10:01 Chewie Lin
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
  0 siblings, 1 reply; 7+ messages in thread
From: Chewie Lin @ 2017-03-31 10:01 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Hi greg k-h and forest:

Sorry about all the spam I've been sending earlier. One more try.
I'm submitting this patch as part of Eudyptula challenge to fix a 
coding style problem.  Thanks for taking time on this trivial patch.

sl424

Chewie Lin (1):
  fixed a checkpatch warning

 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.10.0

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
@ 2017-03-31 10:01 ` Chewie Lin
  2017-03-31 10:32   ` Kim Phillips
  2017-03-31 12:33   ` Greg KH
  0 siblings, 2 replies; 7+ messages in thread
From: Chewie Lin @ 2017-03-31 10:01 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

fix a checkpatch warning:
WARNING: Prefer using "%s", __func__ to embedded function names

Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9..2d9e7af 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s=%d\n", "usb_device_reset fail status", status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
-- 
2.10.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
@ 2017-03-31 10:32   ` Kim Phillips
  2017-03-31 12:33   ` Greg KH
  1 sibling, 0 replies; 7+ messages in thread
From: Kim Phillips @ 2017-03-31 10:32 UTC (permalink / raw)
  To: Chewie Lin; +Cc: greg, forest, devel, linux-kernel

On Fri, 31 Mar 2017 03:01:12 -0700
Chewie Lin <linsh@oregonstate.edu> wrote:

> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names

__func__, so:

> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);

"%s=%d\n", __func__ " fail status", status);

?

Kim

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
  2017-03-31 10:32   ` Kim Phillips
@ 2017-03-31 12:33   ` Greg KH
  1 sibling, 0 replies; 7+ messages in thread
From: Greg KH @ 2017-03-31 12:33 UTC (permalink / raw)
  To: Chewie Lin; +Cc: forest, devel, linux-kernel

On Fri, Mar 31, 2017 at 03:01:12AM -0700, Chewie Lin wrote:
> fix a checkpatch warning:
> WARNING: Prefer using "%s", __func__ to embedded function names
> 
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
>  drivers/staging/vt6656/main_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9..2d9e7af 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
>  	status = usb_reset_device(priv->usb);
>  	if (status)
>  		dev_warn(&priv->usb->dev,
> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s=%d\n", "usb_device_reset fail status", status);

Your patch does not match your description at all :(

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-04-18  4:14   ` Greg KH
@ 2017-04-18  4:47     ` Chewie Lin
  0 siblings, 0 replies; 7+ messages in thread
From: Chewie Lin @ 2017-04-18  4:47 UTC (permalink / raw)
  To: Greg KH; +Cc: forest, devel, linux-kernel

On Tue, Apr 18, 2017 at 06:14:11AM +0200, Greg KH wrote:
> On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote:
> > Swap string in the dev_warn() call with __func__ argument, instead of
> > explicitly calling the function name in the string:
> > 
> >         WARNING: Prefer using "%s", __func__ to embedded function names
> >         #417: FILE: main_usb.c:417:
> >         +                        "usb_device_reset fail status=%d\n", status);
> > 
> >         total: 0 errors, 1 warnings, 1058 lines checked
> > 
> > And after fix:
> > 
> >         main_usb.c has no obvious style problems and is ready for submission.
> > 
> > Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> > ---
> >  drivers/staging/vt6656/main_usb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> > index 9e074e9daf4e..71c4511b4cff 100644
> > --- a/drivers/staging/vt6656/main_usb.c
> > +++ b/drivers/staging/vt6656/main_usb.c
> > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
> >  	status = usb_reset_device(priv->usb);
> >  	if (status)
> >  		dev_warn(&priv->usb->dev,
> > -			 "usb_device_reset fail status=%d\n", status);
> > +			 "%s fail status=%d\n", __func__, status);
> 
> But the call that failed was called usb_device_reset(), right?  Why is
> this function even needed at all, have the caller call the correct
> function instead please, and then this whole function can be deleted.
> 

thanks greg. 
Yes, I think that's a good approach as well. I initially wanted to fix a 
coding style problem without touching the function calls, but I can 
definitely do that as well. 

linsh

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-04-17 23:58 ` [PATCH 1/1] " Chewie Lin
@ 2017-04-18  4:14   ` Greg KH
  2017-04-18  4:47     ` Chewie Lin
  0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2017-04-18  4:14 UTC (permalink / raw)
  To: Chewie Lin; +Cc: forest, devel, linux-kernel

On Mon, Apr 17, 2017 at 04:58:48PM -0700, Chewie Lin wrote:
> Swap string in the dev_warn() call with __func__ argument, instead of
> explicitly calling the function name in the string:
> 
>         WARNING: Prefer using "%s", __func__ to embedded function names
>         #417: FILE: main_usb.c:417:
>         +                        "usb_device_reset fail status=%d\n", status);
> 
>         total: 0 errors, 1 warnings, 1058 lines checked
> 
> And after fix:
> 
>         main_usb.c has no obvious style problems and is ready for submission.
> 
> Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
> ---
>  drivers/staging/vt6656/main_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 9e074e9daf4e..71c4511b4cff 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
>  	status = usb_reset_device(priv->usb);
>  	if (status)
>  		dev_warn(&priv->usb->dev,
> -			 "usb_device_reset fail status=%d\n", status);
> +			 "%s fail status=%d\n", __func__, status);

But the call that failed was called usb_device_reset(), right?  Why is
this function even needed at all, have the caller call the correct
function instead please, and then this whole function can be deleted.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning
  2017-04-17 23:58 [PATCH 0/1] " Chewie Lin
@ 2017-04-17 23:58 ` Chewie Lin
  2017-04-18  4:14   ` Greg KH
  0 siblings, 1 reply; 7+ messages in thread
From: Chewie Lin @ 2017-04-17 23:58 UTC (permalink / raw)
  To: greg, forest, devel, linux-kernel

Swap string in the dev_warn() call with __func__ argument, instead of
explicitly calling the function name in the string:

        WARNING: Prefer using "%s", __func__ to embedded function names
        #417: FILE: main_usb.c:417:
        +                        "usb_device_reset fail status=%d\n", status);

        total: 0 errors, 1 warnings, 1058 lines checked

And after fix:

        main_usb.c has no obvious style problems and is ready for submission.

Signed-off-by: Chewie Lin <linsh@oregonstate.edu>
---
 drivers/staging/vt6656/main_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 9e074e9daf4e..71c4511b4cff 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv)
 	status = usb_reset_device(priv->usb);
 	if (status)
 		dev_warn(&priv->usb->dev,
-			 "usb_device_reset fail status=%d\n", status);
+			 "%s fail status=%d\n", __func__, status);
 }
 
 static void vnt_free_int_bufs(struct vnt_private *priv)
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-18  4:47 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-31 10:01 [PATCH] Eudyptula challenge Chewie Lin
2017-03-31 10:01 ` [PATCH 1/1] drivers/staging/vt6656/main_usb.c: checkpatch warning Chewie Lin
2017-03-31 10:32   ` Kim Phillips
2017-03-31 12:33   ` Greg KH
2017-04-17 23:58 [PATCH 0/1] " Chewie Lin
2017-04-17 23:58 ` [PATCH 1/1] " Chewie Lin
2017-04-18  4:14   ` Greg KH
2017-04-18  4:47     ` Chewie Lin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.