All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fscrypt: remove fscrypt_symlink_data_len()
@ 2017-04-04 21:43 Eric Biggers
  2017-04-06 19:22 ` Richard Weinberger
  2017-04-30  6:16 ` Theodore Ts'o
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Biggers @ 2017-04-04 21:43 UTC (permalink / raw)
  To: linux-fscrypt
  Cc: linux-fsdevel, Theodore Y . Ts'o, Jaegeuk Kim, Eric Biggers

From: Eric Biggers <ebiggers@google.com>

fscrypt_symlink_data_len() is never called and can be removed.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 include/linux/fscrypt_common.h | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/include/linux/fscrypt_common.h b/include/linux/fscrypt_common.h
index 10c1abfbac6c..0a30c106c1e5 100644
--- a/include/linux/fscrypt_common.h
+++ b/include/linux/fscrypt_common.h
@@ -46,17 +46,6 @@ struct fscrypt_symlink_data {
 	char encrypted_path[1];
 } __packed;
 
-/**
- * This function is used to calculate the disk space required to
- * store a filename of length l in encrypted symlink format.
- */
-static inline u32 fscrypt_symlink_data_len(u32 l)
-{
-	if (l < FS_CRYPTO_BLOCK_SIZE)
-		l = FS_CRYPTO_BLOCK_SIZE;
-	return (l + sizeof(struct fscrypt_symlink_data) - 1);
-}
-
 struct fscrypt_str {
 	unsigned char *name;
 	u32 len;
-- 
2.12.2.715.g7642488e1d-goog

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] fscrypt: remove fscrypt_symlink_data_len()
  2017-04-04 21:43 [PATCH] fscrypt: remove fscrypt_symlink_data_len() Eric Biggers
@ 2017-04-06 19:22 ` Richard Weinberger
  2017-04-30  6:16 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2017-04-06 19:22 UTC (permalink / raw)
  To: Eric Biggers
  Cc: linux-fscrypt, linux-fsdevel, Theodore Y . Ts'o, Jaegeuk Kim,
	Eric Biggers

On Tue, Apr 4, 2017 at 11:43 PM, Eric Biggers <ebiggers3@gmail.com> wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> fscrypt_symlink_data_len() is never called and can be removed.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  include/linux/fscrypt_common.h | 11 -----------
>  1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/fscrypt_common.h b/include/linux/fscrypt_common.h
> index 10c1abfbac6c..0a30c106c1e5 100644
> --- a/include/linux/fscrypt_common.h
> +++ b/include/linux/fscrypt_common.h
> @@ -46,17 +46,6 @@ struct fscrypt_symlink_data {
>         char encrypted_path[1];
>  } __packed;
>
> -/**
> - * This function is used to calculate the disk space required to
> - * store a filename of length l in encrypted symlink format.
> - */
> -static inline u32 fscrypt_symlink_data_len(u32 l)
> -{
> -       if (l < FS_CRYPTO_BLOCK_SIZE)
> -               l = FS_CRYPTO_BLOCK_SIZE;
> -       return (l + sizeof(struct fscrypt_symlink_data) - 1);
> -}
> -

Reviewed-by: Richard Weinberger <richard@nod.at>

-- 
Thanks,
//richard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: fscrypt: remove fscrypt_symlink_data_len()
  2017-04-04 21:43 [PATCH] fscrypt: remove fscrypt_symlink_data_len() Eric Biggers
  2017-04-06 19:22 ` Richard Weinberger
@ 2017-04-30  6:16 ` Theodore Ts'o
  1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2017-04-30  6:16 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-fscrypt, linux-fsdevel, Jaegeuk Kim, Eric Biggers

On Tue, Apr 04, 2017 at 02:43:34PM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> fscrypt_symlink_data_len() is never called and can be removed.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks, applied.

				- Ted

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-30  6:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 21:43 [PATCH] fscrypt: remove fscrypt_symlink_data_len() Eric Biggers
2017-04-06 19:22 ` Richard Weinberger
2017-04-30  6:16 ` Theodore Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.