[U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

[U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

[Nobuhiro Iwamatsu]

The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal,
but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number
from hexadecimal to integer.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 common/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/Kconfig b/common/Kconfig
index 8f73c8f757..fe5bb69409 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -90,7 +90,7 @@ config BOOTSTAGE_STASH_ADDR
 
 config BOOTSTAGE_STASH_SIZE
 	hex "Size of boot timing stash region"
-	default 4096
+	default 0x1000
 	help
 	  This should be large enough to hold the bootstage stash. A value of
 	  4096 (4KiB) is normally plenty.
-- 
2.11.0

[U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

[Wolfgang Denk]

Dear Nobuhiro,

In message <20170401224812.11646-1-iwamatsu@nigauri.org> you wrote:
> The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal,
> but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number
> from hexadecimal to integer.
...
> -	default 4096
> +	default 0x1000
>  	help
>  	  This should be large enough to hold the bootstage stash. A value of
>  	  4096 (4KiB) is normally plenty.

Would it make sense to also fix the help message, and maybe even to
add a note to the help message that this should be a hex number?

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Always borrow money from a pessimist; they don't expect  to  be  paid
back.

[U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

[Tom Rini]

On Sun, Apr 02, 2017 at 11:22:42AM +0200, Wolfgang Denk wrote:
> Dear Nobuhiro,
> 
> In message <20170401224812.11646-1-iwamatsu@nigauri.org> you wrote:
> > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal,
> > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number
> > from hexadecimal to integer.
> ...
> > -	default 4096
> > +	default 0x1000
> >  	help
> >  	  This should be large enough to hold the bootstage stash. A value of
> >  	  4096 (4KiB) is normally plenty.
> 
> Would it make sense to also fix the help message, and maybe even to
> add a note to the help message that this should be a hex number?

Yes, perhaps s/4096/0x1000/ in the help message will be clear enough
since Kconfig tooling will take care of saying "THIS IS HEX!" somwwhere
relevant.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170405/f30d03e3/attachment.sig>

[U-Boot] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

[Tom Rini]

On Sun, Apr 02, 2017 at 07:48:12AM +0900, Nobuhiro Iwamatsu wrote:

> The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal,
> but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number
> from hexadecimal to integer.
> 
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/2a9fd1c3/attachment.sig>